Re: 02/02: build-system/r: Use invoke.

Re: 02/02: build-system/r: Use invoke.

[Mark H Weaver]

Hi Ricardo,

rekado@elephly.net (Ricardo Wurmus) writes:

> rekado pushed a commit to branch core-updates
> in repository guix.
>
> commit babeea3f9f46c1f1f812e590f46283e91684f327
> Author: Ricardo Wurmus <rekado@elephly.net>
> Date:   Thu May 31 09:16:01 2018 +0200
>
>     build-system/r: Use invoke.
>     
>     * guix/build/r-build-system.scm (invoke-r): Use invoke.
>     (pipe-to-r): Raise invoke-error on non-zero return value.
>     (check): Unconditionally return #t.

Thanks for this!  However:

>  (define (pipe-to-r command params)
>    (let ((port (apply open-pipe* OPEN_WRITE "R" params)))
>      (display command port)
> -    (zero? (status:exit-val (close-pipe port)))))
> +    (let ((code (status:exit-val (close-pipe port))))
> +      (unless (zero? code)
> +        (raise (condition ((@@ (guix build utils) &invoke-error)
> +                           (program "R")
> +                           (arguments (string-append params " " command))
> +                           (exit-status (status:exit-val code))
> +                           (term-signal (status:term-sig code))
> +                           (stop-signal (status:stop-sig code)))))))))

The 'arguments' field should be a list, not a string.

      Thanks!
        Mark

Re: 02/02: build-system/r: Use invoke.

[Mark H Weaver]

Mark H Weaver <mhw@netris.org> writes:

> rekado@elephly.net (Ricardo Wurmus) writes:
>
>>  (define (pipe-to-r command params)
>>    (let ((port (apply open-pipe* OPEN_WRITE "R" params)))
>>      (display command port)
>> -    (zero? (status:exit-val (close-pipe port)))))
>> +    (let ((code (status:exit-val (close-pipe port))))
>> +      (unless (zero? code)
>> +        (raise (condition ((@@ (guix build utils) &invoke-error)
>> +                           (program "R")
>> +                           (arguments (string-append params " " command))
>> +                           (exit-status (status:exit-val code))
>> +                           (term-signal (status:term-sig code))
>> +                           (stop-signal (status:stop-sig code)))))))))
>
> The 'arguments' field should be a list, not a string.

Actually, the more serious problem is that 'params' is itself a list, so
when you apply 'string-append' to it, that will raise an exception, but
not the exception that you wanted.

      Mark

Re: 02/02: build-system/r: Use invoke.

[Ricardo Wurmus]

Hi Mark,

>> commit babeea3f9f46c1f1f812e590f46283e91684f327
>> Author: Ricardo Wurmus <rekado@elephly.net>
>> Date:   Thu May 31 09:16:01 2018 +0200
>>
>>     build-system/r: Use invoke.
>>
>>     * guix/build/r-build-system.scm (invoke-r): Use invoke.
>>     (pipe-to-r): Raise invoke-error on non-zero return value.
>>     (check): Unconditionally return #t.
>
> Thanks for this!  However: […]
> The 'arguments' field should be a list, not a string.

Thanks for pointing this out!  I’ll push a fix to the new core-updates
branch shortly.

--
Ricardo