all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#32836: emacs-magit is broken (and probably others) due to package renaming
@ 2018-09-25 13:54 Björn Höfling
  2018-09-25 15:04 ` Pierre Neidhardt
  0 siblings, 1 reply; 9+ messages in thread
From: Björn Höfling @ 2018-09-25 13:54 UTC (permalink / raw)
  To: 32836; +Cc: Pierre Neidhardt

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

Commit

5c8031ff7382ec9079040d08ae5a05b4dd2352b7

mass-renamed emacs-packages from "foo" to "emacs-foo". Unfortunately,
some package definitions use the package-name for building the URL.
That is for example the case in emacs-magit:

(define-public emacs-magit
  (package
    (name "emacs-magit")
    (version "2.13.0")
    (source (origin
             (method url-fetch)
             (uri (string-append
                   "https://github.com/magit/magit/releases/download/"
                   version "/" name "-" version ".tar.gz"))

Thus, it can no longer be built:

Starting download of /gnu/store/h01ag9sr8nxiqbnlblmxplnv43a2005j-emacs-magit-2.13.0.tar.gz
From https://github.com/magit/magit/releases/download/2.13.0/emacs-magit-2.13.0.tar.gz...
ERROR: download failed "https://github.com/magit/magit/releases/download/2.13.0/emacs-magit-2.13.0.tar.gz" 404 "Not Found"

Pierre, could you have a look into it?

Thanks

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#32836: emacs-magit is broken (and probably others) due to package renaming
  2018-09-25 13:54 bug#32836: emacs-magit is broken (and probably others) due to package renaming Björn Höfling
@ 2018-09-25 15:04 ` Pierre Neidhardt
  2018-09-25 19:29   ` Taylan Kammer
  2018-09-25 22:23   ` Alex Kost
  0 siblings, 2 replies; 9+ messages in thread
From: Pierre Neidhardt @ 2018-09-25 15:04 UTC (permalink / raw)
  To: Björn Höfling; +Cc: 32836

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Oopsy, missed that indeed! xD
Sorry for the trouble, will fix as soon as possible.

By the way, I think using "name" for URLs is a bad practice, we only need
"version" there.  What do you people think?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#32836: emacs-magit is broken (and probably others) due to package renaming
  2018-09-25 19:29   ` Taylan Kammer
@ 2018-09-25 17:58     ` Pierre Neidhardt
  2018-09-26  9:38       ` Ludovic Courtès
  2018-09-26 22:37       ` Björn Höfling
  0 siblings, 2 replies; 9+ messages in thread
From: Pierre Neidhardt @ 2018-09-25 17:58 UTC (permalink / raw)
  To: Taylan Kammer; +Cc: 32836

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

OK, I'll add this recommendation to the Guix packaging tutorial.

I've pushed the fix upstream.  Only magit and groovy-modes were affected.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#32836: emacs-magit is broken (and probably others) due to package renaming
  2018-09-25 15:04 ` Pierre Neidhardt
@ 2018-09-25 19:29   ` Taylan Kammer
  2018-09-25 17:58     ` Pierre Neidhardt
  2018-09-25 22:23   ` Alex Kost
  1 sibling, 1 reply; 9+ messages in thread
From: Taylan Kammer @ 2018-09-25 19:29 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: 32836

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Oopsy, missed that indeed! xD
> Sorry for the trouble, will fix as soon as possible.
>
> By the way, I think using "name" for URLs is a bad practice, we only need
> "version" there.  What do you people think?

I agree.  Whenever I've seen 'name' being used in URL definitions in the
past I wondered what the point is, since our naming doesn't necessarily
align with the name of the file to be downloaded.

Taylan

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#32836: emacs-magit is broken (and probably others) due to package renaming
  2018-09-25 15:04 ` Pierre Neidhardt
  2018-09-25 19:29   ` Taylan Kammer
@ 2018-09-25 22:23   ` Alex Kost
  2018-09-26 16:21     ` Nils Gillmann
  1 sibling, 1 reply; 9+ messages in thread
From: Alex Kost @ 2018-09-25 22:23 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: 32836

Pierre Neidhardt (2018-09-25 17:04 +0200) wrote:

> Oopsy, missed that indeed! xD
> Sorry for the trouble, will fix as soon as possible.
>
> By the way, I think using "name" for URLs is a bad practice, we only need
> "version" there.  What do you people think?

I totally agree!  I don't like this practice very much.

-- 
Alex

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#32836: emacs-magit is broken (and probably others) due to package renaming
  2018-09-25 17:58     ` Pierre Neidhardt
@ 2018-09-26  9:38       ` Ludovic Courtès
  2018-09-26 22:37       ` Björn Höfling
  1 sibling, 0 replies; 9+ messages in thread
From: Ludovic Courtès @ 2018-09-26  9:38 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: 32836-done

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> OK, I'll add this recommendation to the Guix packaging tutorial.

Sounds good.

> I've pushed the fix upstream.  Only magit and groovy-modes were affected.

Thanks for the quick fix!

Ludo’.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#32836: emacs-magit is broken (and probably others) due to package renaming
  2018-09-25 22:23   ` Alex Kost
@ 2018-09-26 16:21     ` Nils Gillmann
  2018-09-26 17:05       ` Pierre Neidhardt
  0 siblings, 1 reply; 9+ messages in thread
From: Nils Gillmann @ 2018-09-26 16:21 UTC (permalink / raw)
  To: Alex Kost; +Cc: 32836, Pierre Neidhardt

Alex Kost transcribed 331 bytes:
> Pierre Neidhardt (2018-09-25 17:04 +0200) wrote:
> 
> > Oopsy, missed that indeed! xD
> > Sorry for the trouble, will fix as soon as possible.
> >
> > By the way, I think using "name" for URLs is a bad practice, we only need
> > "version" there.  What do you people think?
> 
> I totally agree!  I don't like this practice very much.
> 
> -- 
> Alex
> 
> 
> 

Very often the name we use, except for language specific packages, is the same
as upstream uses. "name" can be shorter than "whatever-long-name".

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#32836: emacs-magit is broken (and probably others) due to package renaming
  2018-09-26 16:21     ` Nils Gillmann
@ 2018-09-26 17:05       ` Pierre Neidhardt
  0 siblings, 0 replies; 9+ messages in thread
From: Pierre Neidhardt @ 2018-09-26 17:05 UTC (permalink / raw)
  To: Nils Gillmann; +Cc: 32836, Alex Kost

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]


> Very often the name we use, except for language specific packages, is the same
> as upstream uses. "name" can be shorter than "whatever-long-name".

It often works, but at the cost of raising issues like this thread.
I think it's more important to make the URL reliable than to make it short :)

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#32836: emacs-magit is broken (and probably others) due to package renaming
  2018-09-25 17:58     ` Pierre Neidhardt
  2018-09-26  9:38       ` Ludovic Courtès
@ 2018-09-26 22:37       ` Björn Höfling
  1 sibling, 0 replies; 9+ messages in thread
From: Björn Höfling @ 2018-09-26 22:37 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: 32836

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

On Tue, 25 Sep 2018 19:58:04 +0200
Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> OK, I'll add this recommendation to the Guix packaging tutorial.
> 
> I've pushed the fix upstream.  Only magit and groovy-modes were
> affected.
> 

Looks good. Thanks for fixing!

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-09-26 22:38 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-25 13:54 bug#32836: emacs-magit is broken (and probably others) due to package renaming Björn Höfling
2018-09-25 15:04 ` Pierre Neidhardt
2018-09-25 19:29   ` Taylan Kammer
2018-09-25 17:58     ` Pierre Neidhardt
2018-09-26  9:38       ` Ludovic Courtès
2018-09-26 22:37       ` Björn Höfling
2018-09-25 22:23   ` Alex Kost
2018-09-26 16:21     ` Nils Gillmann
2018-09-26 17:05       ` Pierre Neidhardt

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.