From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPAA5-0003AD-4w for guix-patches@gnu.org; Tue, 20 Nov 2018 12:50:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPAA1-0000GF-Vh for guix-patches@gnu.org; Tue, 20 Nov 2018 12:50:09 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPAA1-0000Ft-Qr for guix-patches@gnu.org; Tue, 20 Nov 2018 12:50:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPAA1-0002oT-DY for guix-patches@gnu.org; Tue, 20 Nov 2018 12:50:05 -0500 Subject: [bug#33390] [PATCH 1/4] qtwebkit: Fix pri install directory. Resent-Message-ID: References: <20181115041715.15993-1-ericbavier@centurylink.net> <20181115041715.15993-2-ericbavier@centurylink.net> <87h8gcso59.fsf@cbaines.net> <20181119222244.26c47f9e@centurylink.net> From: Christopher Baines In-reply-to: <20181119222244.26c47f9e@centurylink.net> Date: Tue, 20 Nov 2018 17:48:55 +0000 Message-ID: <87ftvvskqg.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Eric Bavier Cc: 33390@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eric Bavier writes: >> > From: Eric Bavier >> > >> > This lets qmake find qtwebkit components, allowing packages like pytho= n-pyqt >> > to find qtwebkit and enable support. >> > >> > * gnu/packages/qt.scm (qtwebkit)[arguments]: Add "ECM_MKSPECS_INSTALL_= DIR" >> > to #:configure-flags. Link with "--no-keep-memory". >> > --- >> > gnu/packages/qt.scm | 11 ++++++++++- >> > 1 file changed, 10 insertions(+), 1 deletion(-) >> > >> > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm >> > index d48769982..36f8aef69 100644 >> > --- a/gnu/packages/qt.scm >> > +++ b/gnu/packages/qt.scm >> > @@ -10,6 +10,7 @@ >> > ;;; Copyright =C2=A9 2017, 2018 Tobias Geerinckx-Rice >> > ;;; Copyright =C2=A9 2018 Nicolas Goaziou >> > ;;; Copyright =C2=A9 2018 Hartmut Goebel >> > +;;; Copyright =C2=A9 2018 Eric Bavier >> > ;;; >> > ;;; This file is part of GNU Guix. >> > ;;; >> > @@ -2171,7 +2172,15 @@ different kinds of sliders, and much more.") >> > #:configure-flags (list ;"-DENABLE_API_TESTS=3DTRUE" >> > "-DPORT=3DQt" >> > "-DUSE_LIBHYPHEN=3DOFF" >> > - "-DUSE_SYSTEM_MALLOC=3DON"))) >> > + "-DUSE_SYSTEM_MALLOC=3DON" >> > + ;; XXX: relative dir installs to build= dir? >> > + (string-append "-DECM_MKSPECS_INSTALL_= DIR=3D" >> > + %output "/lib/qt5/mkspe= cs/modules") >> > + ;; Sacrifice a little speed in order t= o link >> > + ;; libraries and test executables in a >> > + ;; reasonable amount of memory. >> > + "-DCMAKE_SHARED_LINKER_FLAGS=3D-Wl,--n= o-keep-memory" >> > + "-DCMAKE_EXE_LINKER_FLAGS=3D-Wl,--no-k= eep-memory"))) >> > (home-page "https://www.webkit.org") >> > (synopsis "Web browser engine and classes to render and interact = with web >> > content") >> >> I've tested this, and this fixed the qtwebkit build for me, which >> currently doesn't work on master. So I'm all for merging it. > > Thanks for testing it. I assume it was the linker flags that fixed the > build on your machine? For clarity, I suppose that change should be > moved to a separate patch. WDYT? I don't mind eitherway, I'm just happy that the package builds again with the patch :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlv0SQdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcFTA/+Po3qjBm63Ll0tEK7mcwykvg20rNP/Myzio8ulgL5eazVP2OErGVH1/Ft PvwBa+jwZZHTTgJFpW2t/ZXu2vNlWb1nhYr52zlocK+VnIsBFIcwXvLqhGiXSOZg j4OsuNE3q8RvM7kdk3G5tukwAlevDLcnGfYg/1hwcWbLIZeU7bXPd6gNiO/d/VAJ 0SKMO06akyQMyJJjj4LyieHu/RHVjne5jP/+ufHovPShewVSX4TkhT8yx4e9nemy KbxuQV0uDikxCOcsJ6ilh4i+C2/ZvojAtvg7bF0yQJPob7Dv3fxx6U2kX0UBvZ/X 9l1UAz2HQgiQJ4xyQmCURjXCaza7hf0B/yDCtJ5G7mLtulNcZYrnPzdQwp1oAiKZ WK3EWT8WtamSAbGtjZWhQFGhkCWaa79VVuuYpmwxkYCsE9otcBA0HvePiy5JkM45 zugEht/19qJJvlpODQ4lU79M2/WOlt0FN0JLp+3JXVP+gP3m5cWTo0XiZNduWo24 C4a67vbLkzHuZ7Ku8M9yjE1EysUNRW/O2YN2JGFh+pKpDeE+m+Qz5BWcxJHOTH6B br/aCqgdEAwHhB2Sk1MH3N2oINT2pb2fUj4QPcQKzVgZFIrpjspKo3xzVknmcfjH FZVAfExJOiXxfttoRve+3WaF4/O/+GG8aw4o0hWVo4QRWECdhBY= =Tl00 -----END PGP SIGNATURE----- --=-=-=--