From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 02/02: doc: Example vm-image doesn't need firmware.
Date: Tue, 25 Dec 2018 16:02:37 +0100
Message-ID: <87ftulfy42.fsf@gnu.org>
References: <20181224091640.25366.13759@vcs0.savannah.gnu.org>
	<20181224091641.731F420496@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:42952)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gboED-0000le-Ef
	for guix-devel@gnu.org; Tue, 25 Dec 2018 10:02:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gboEC-000811-K2
	for guix-devel@gnu.org; Tue, 25 Dec 2018 10:02:41 -0500
Received: from hera.aquilenet.fr ([2a0c:e300::1]:43334)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1gboEC-000802-Ea
	for guix-devel@gnu.org; Tue, 25 Dec 2018 10:02:40 -0500
In-Reply-To: <20181224091641.731F420496@vcs0.savannah.gnu.org> (guix-commits's
	message of "Mon, 24 Dec 2018 04:16:41 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Efraim Flashner <efraim@flashner.co.il>

Hi,

guix-commits@gnu.org skribis:

> efraim pushed a commit to branch master
> in repository guix.
>
> commit 3c515b22255c8ca4a727ba230168cf1083979086
> Author: Efraim Flashner <efraim@flashner.co.il>
> Date:   Tue Dec 11 16:42:56 2018 +0200
>
>     doc: Example vm-image doesn't need firmware.
>=20=20=20=20=20
>     * gnu/system/examples/vm-image.tmpl (firmware): New field, explicitly
>     empty list.
> ---
>  gnu/system/examples/vm-image.tmpl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/system/examples/vm-image.tmpl b/gnu/system/examples/vm-i=
mage.tmpl
> index 36e2727..f149f67 100644
> --- a/gnu/system/examples/vm-image.tmpl
> +++ b/gnu/system/examples/vm-image.tmpl
> @@ -24,6 +24,8 @@ partprobe, and then 2) resizing the filesystem with res=
ize2fs.\n"))
>    (timezone "Etc/UTC")
>    (locale "en_US.utf8")
>=20=20
> +(firmware '())

Two things: (1) the indentation is off ;-), and (2) shouldn=E2=80=99t we set
=E2=80=98firmware=E2=80=99 directly in =E2=80=98virtualized-operating-syste=
m=E2=80=99 in (gnu system
vm)?

Thanks,
Ludo=E2=80=99.