From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:59230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnCt9-0000xF-Uo for guix-patches@gnu.org; Fri, 25 Jan 2019 20:36:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gnCt8-0000Pa-R2 for guix-patches@gnu.org; Fri, 25 Jan 2019 20:36:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gnCt8-0000NY-CE for guix-patches@gnu.org; Fri, 25 Jan 2019 20:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gnCt7-0008UT-WF for guix-patches@gnu.org; Fri, 25 Jan 2019 20:36:02 -0500 Subject: [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating. Resent-Message-ID: References: <8736pzpnhg.fsf@elephly.net> <20190111094208.28327-1-rekado@elephly.net> <87bm49itkj.fsf@gnu.org> <87k1isvhbe.fsf@elephly.net> <87y378moax.fsf@gnu.org> From: Ricardo Wurmus In-reply-to: <87y378moax.fsf@gnu.org> Date: Fri, 25 Jan 2019 22:48:58 +0100 Message-ID: <87fttgv25x.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34040@debbugs.gnu.org Ludovic Court=C3=A8s writes: >>> Alternately, we could change =E2=80=98input-changes=E2=80=99 to =E2=80= =98inputs=E2=80=99, which would be >>> absolute, not relative, and thus =E2=80=98package-update=E2=80=99 would= take care of >>> calling =E2=80=98changed-inputs=E2=80=99 etc. >> >> That would also work, but I think I prefer an updater to report changes >> rather than a new list of inputs. > > OTOH if we return a complete list of inputs, then we don=E2=80=99t have t= o worry > about the cost of =E2=80=98changed-inputs=E2=80=99 since that would only = be called on > demand; also there=E2=80=99d be a single call site for =E2=80=98changed-i= nputs=E2=80=99. The potentially expensive part is to get the inputs, though. Getting a list of new inputs means that the importer needs to be run. For CRAN packages this requires downloading the tarball and unpacking parts of it. -- Ricardo