From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:34638)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hEXIN-0002A0-UD
	for guix-patches@gnu.org; Thu, 11 Apr 2019 06:51:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hEXIN-0006we-0S
	for guix-patches@gnu.org; Thu, 11 Apr 2019 06:51:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40372)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hEXIM-0006wD-QE
	for guix-patches@gnu.org; Thu, 11 Apr 2019 06:51:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hEXIM-0004Qo-Ih
	for guix-patches@gnu.org; Thu, 11 Apr 2019 06:51:02 -0400
Subject: [bug#35110] [PATCH v2 1/2] Add (guix build-system linux-module).
Resent-Message-ID: <handler.35110.B35110.155497985417021@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190402192729.5262-1-dannym@scratchpost.org>
	<20190405110550.24168-1-dannym@scratchpost.org>
	<20190405110550.24168-2-dannym@scratchpost.org>
Date: Thu, 11 Apr 2019 12:50:42 +0200
In-Reply-To: <20190405110550.24168-2-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Fri, 5 Apr 2019 13:05:49 +0200")
Message-ID: <87ftqo3jel.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 35110@debbugs.gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * guix/build/linux-module-build-system.scm: New file.
> * guix/build-system/linux-module.scm: New file.
> * Makefile.am (MODULES): Add them.

Awesome!

> +(define* (configure #:key inputs #:allow-other-keys)
> +  #t)
> +;  (let ((source (string-append (assoc-ref inputs "linux")
> +;                               "/Module.symvers")))
> +;    (if (file-exists? source)
> +;        (install-file source out-lib-build))
> +;    #t))

I think you should either remove this comment or add an explanation
and/or a TODO.

Could you also add a note in doc/guix.texi under =E2=80=9CBuild Systems=E2=
=80=9D?

Otherwise LGTM, thank you!

Ludo=E2=80=99.