From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: guile-bash updated source url Date: Wed, 08 May 2019 00:25:02 -0400 Message-ID: <87ftpp3746.fsf@netris.org> References: <87imurbq18.fsf@gnu.org> <87ef5cse3h.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:46180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOEAc-0001P7-Ic for guix-devel@gnu.org; Wed, 08 May 2019 00:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOEAb-0002M8-Do for guix-devel@gnu.org; Wed, 08 May 2019 00:27:06 -0400 In-Reply-To: <87ef5cse3h.fsf@netris.org> (Mark H. Weaver's message of "Sun, 05 May 2019 18:58:15 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel@gnu.org FYI, David might not have seen my reply below, because my mail server is unable to perform DNS lookups for his domain, and thus is unable to look up the MX record to deliver mail to him. I'm not yet sure what's going wrong, maybe something in my firewall configuration. Mark Mark H Weaver writes: > Hi David, > > david.larsson@selfhosted.xyz writes: > >> On Fri, 3 May 2019, Ludovic Court=C3=A8s wrote: >> >>> david.larsson@selfhosted.xyz skribis: >>> >>>> This is my first contribution to guix and it's just a minor fix for >>>> the guile-bash package which had an outdated source url. I was able to >>>> retrieve the same revision of the package via the software-heritage >>>> project's website and upload it to gitlab. Then I installed it >>>> successfully via guix package -f my-guile-bash.scm using the gitlab >>>> url, then copied it to the existing guile-xyz.scm in gnu/packages. >>> >>> [...] >>> >>>> --- a/gnu/packages/guile-xyz.scm >>>> +++ b/gnu/packages/guile-xyz.scm >>>> @@ -294,23 +294,21 @@ dictionary and suggesting spelling corrections.") >>>> (license license:gpl3+))) >>>> >>>> (define-public guile-bash >>>> - ;; This project is currently retired. It was initially announced h= ere: >>>> - ;; . >>>> - (let ((commit "1eabc563ca5692b3e08d84f1f0e6fd2283284469") >>>> + (let ((commit "49099fe6a592aa3b8001e826b939869fe5811785") >>>> (revision "0")) >>> >>> Why is the commit different? Looks like it=E2=80=99s more than just a = mirror. >>> >>> If you made changes on top of the original code, that=E2=80=99s actuall= y great. >>> However, I=E2=80=99d prefer to first see a patch that simply changes th= e URL, >>> not the commit and hash, and later updates to a different revision. >>> >>> Does that make sense? >>> >> >> I made a commit since I was unable figure out how to create a >> git-mirror from the Software Heritage website but was able to retrieve >> the correct commit as a tarball. Then I guix init'ed the folder, and >> made a commit in order to push it to gitlab. > > Hmm. If I understand correctly, it sounds like this will discard the > entire previous git history. If you want to maintain this package and > host the repository yourself (as opposed to us relying on Software > Heritage), I would advocate trying again until you can properly clone > the existing repository. We can help if needed. It's important to get > this right now, because git history cannot be rewritten after the fact, > and it's important to preserve the existing history. > > Thanks, > Mark