* [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests
@ 2019-05-28 12:41 Robert Vollmert
2019-06-01 12:55 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Robert Vollmert @ 2019-05-28 12:41 UTC (permalink / raw)
To: 35944; +Cc: Robert Vollmert
Tests fail reliably for me on a system with 2GB of available RAM, in
`issue93.a.hs` and `issue93.n.hs`.
* gnu/packages/haskell.scm (ghc-happy): Disable tests
---
gnu/packages/haskell.scm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33c9c6484d..7ef32537c8 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1325,6 +1325,8 @@ postfix notation. For more information on stack based languages, see
(base32
"138xpxdb7x62lpmgmb6b3v3vgdqqvqn4273jaap3mjmc2gla709y"))))
(build-system haskell-build-system)
+ (arguments
+ `(#:tests? #f)) ; Test require excessive amounts of memory
(home-page "https://hackage.haskell.org/package/happy")
(synopsis "Parser generator for Haskell")
(description "Happy is a parser generator for Haskell. Given a grammar
--
2.20.1 (Apple Git-117)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests
2019-05-28 12:41 [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests Robert Vollmert
@ 2019-06-01 12:55 ` Ludovic Courtès
[not found] ` <A84C7AE6-3BAD-4E9D-BE2A-FE1C8B409071@vllmrt.net>
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-06-01 12:55 UTC (permalink / raw)
To: Robert Vollmert; +Cc: 35944
Robert Vollmert <rob@vllmrt.net> skribis:
> Tests fail reliably for me on a system with 2GB of available RAM, in
> `issue93.a.hs` and `issue93.n.hs`.
They fail because they run out of memory?
What would it take to skip just these two tests instead of skipping all
the tests?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests
[not found] ` <A84C7AE6-3BAD-4E9D-BE2A-FE1C8B409071@vllmrt.net>
@ 2019-06-01 14:40 ` Robert Vollmert
2019-06-01 21:30 ` bug#35944: " Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Robert Vollmert @ 2019-06-01 14:40 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 35944
> On 1. Jun 2019, at 14:56, Robert Vollmert <rob@vllmrt.net> wrote:
>> On 1. Jun 2019, at 14:55, Ludovic Courtès <ludo@gnu.org> wrote:
>> They fail because they run out of memory?
>
> Indeed, the OOM killer strikes.
>
>> What would it take to skip just these two tests instead of skipping all
>> the tests?
>
> I’ll look into it.
Below is a patch that does that. I’m now running into similar issues when
compiling ghc-scientific; should OOM test failures at 2G of memory generally
be considered worth fixing? As an alternative, would it be feasible to
implement a --skip-tests flag for guix build?
From 7b7029d99df7df2ccdbfb4026edd91daa2a5763e Mon Sep 17 00:00:00 2001
From: Robert Vollmert <rob@vllmrt.net>
Date: Tue, 28 May 2019 21:10:24 +0200
Subject: [PATCH] gnu: ghc-happy: Skip memory-hungry tests.
Tests fail reliably for me on a system with 2GB of available RAM, in
`issue93.a.hs` and `issue93.n.hs`.
* gnu/packages/haskell.scm (ghc-happy): Skip test "issue93".
---
gnu/packages/haskell.scm | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33c9c6484d..be9ab00bfd 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1325,6 +1325,14 @@ postfix notation. For more information on stack based languages, see
(base32
"138xpxdb7x62lpmgmb6b3v3vgdqqvqn4273jaap3mjmc2gla709y"))))
(build-system haskell-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'skip-test-issue93
+ (lambda _
+ (substitute* "tests/Makefile"
+ ((" issue93.y ") " "))
+ #t)))))
(home-page "https://hackage.haskell.org/package/happy")
(synopsis "Parser generator for Haskell")
(description "Happy is a parser generator for Haskell. Given a grammar
--
2.20.1 (Apple Git-117)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#35944: [PATCH] gnu: packages: haskell: happy: Disable tests
2019-06-01 14:40 ` Robert Vollmert
@ 2019-06-01 21:30 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2019-06-01 21:30 UTC (permalink / raw)
To: Robert Vollmert; +Cc: 35944-done
Hi,
Robert Vollmert <rob@vllmrt.net> skribis:
> Below is a patch that does that. I’m now running into similar issues when
> compiling ghc-scientific; should OOM test failures at 2G of memory generally
> be considered worth fixing?
I’d say yes, as long as we’re just talking about a small fraction of the
GHC packages.
> As an alternative, would it be feasible to implement a --skip-tests
> flag for guix build?
That would amount to building a different derivation, so that’s not
really a solution.
> From 7b7029d99df7df2ccdbfb4026edd91daa2a5763e Mon Sep 17 00:00:00 2001
> From: Robert Vollmert <rob@vllmrt.net>
> Date: Tue, 28 May 2019 21:10:24 +0200
> Subject: [PATCH] gnu: ghc-happy: Skip memory-hungry tests.
>
> Tests fail reliably for me on a system with 2GB of available RAM, in
> `issue93.a.hs` and `issue93.n.hs`.
>
> * gnu/packages/haskell.scm (ghc-happy): Skip test "issue93".
I copied the explanation as a comment and applied.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-01 21:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-28 12:41 [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests Robert Vollmert
2019-06-01 12:55 ` Ludovic Courtès
[not found] ` <A84C7AE6-3BAD-4E9D-BE2A-FE1C8B409071@vllmrt.net>
2019-06-01 14:40 ` Robert Vollmert
2019-06-01 21:30 ` bug#35944: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.