all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#37708] [PATCH] gnu: add uchardet
@ 2019-10-11 20:21 Reza Alizadeh Majd
  2019-10-12  8:17 ` Jonathan Brielmaier
       [not found] ` <7721cc22-fc20-41ab-affb-3a44d0947746@pantherx.org>
  0 siblings, 2 replies; 5+ messages in thread
From: Reza Alizadeh Majd @ 2019-10-11 20:21 UTC (permalink / raw)
  To: 37708

From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
From: Reza Alizadeh Majd <r.majd@pantherx.org>
Date: Fri, 11 Oct 2019 23:23:21 +0330
Subject: [PATCH] gnu: add uchardet

* gnu/packages/freedesktop.scm (uchardet) New variable.
---
 gnu/packages/freedesktop.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 401f54bb14..51848be170 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Pierre Neidhardt <mail@ambrevar.xyz>
 ;;; Copyright © 2018 Stefan Stefanović <stefanx2ovic@gmail.com>
+;;; Copyright © 2019 Reza Alizadeh Majd <r.majd@pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1409,3 +1410,24 @@ This package also contains two related utilities:
 their MIME type.
 @end itemize")
     (license license:perl-license)))
+
+(define-public uchardet
+  (package
+    (name "uchardet")
+    (version "0.0.6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://www.freedesktop.org/software/" 
+                            name "/releases/" name "-" version ".tar.xz"))
+        (sha256
+          (base32 
"0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
+    (build-system cmake-build-system)
+    (arguments `(#:tests? #f))
+    (home-page "https://www.freedesktop.org/wiki/Software/uchardet/")
+    (synopsis "encoding detector library")
+    (description "uchardet is an encoding detector library, which takes a 
+sequence of bytes in an unknown character encoding without any additional 
+information, and attempts to determine the encoding of the text. Returned 
+encoding names are iconv-compatible.")
+    (license license:gpl2+)))
-- 
Regards
Reza Alizadeh Majd
PantherX Team

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#37708] [PATCH] gnu: add uchardet
  2019-10-11 20:21 [bug#37708] [PATCH] gnu: add uchardet Reza Alizadeh Majd
@ 2019-10-12  8:17 ` Jonathan Brielmaier
  2019-10-12  8:49   ` Reza Alizadeh Majd
       [not found] ` <7721cc22-fc20-41ab-affb-3a44d0947746@pantherx.org>
  1 sibling, 1 reply; 5+ messages in thread
From: Jonathan Brielmaier @ 2019-10-12  8:17 UTC (permalink / raw)
  To: Reza Alizadeh Majd, 37708

On 11.10.19 22:21, Reza Alizadeh Majd wrote:> +    (description
"uchardet is an encoding detector library, which takes
> a +sequence of bytes in an unknown character encoding without any
> additional +information, and attempts to determine the encoding of the
> text. Returned +encoding names are iconv-compatible.")

What does this "+" do here? Are they broken texinfo syntax?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#37708] [PATCH] gnu: add uchardet
  2019-10-12  8:17 ` Jonathan Brielmaier
@ 2019-10-12  8:49   ` Reza Alizadeh Majd
  0 siblings, 0 replies; 5+ messages in thread
From: Reza Alizadeh Majd @ 2019-10-12  8:49 UTC (permalink / raw)
  To: Jonathan Brielmaier; +Cc: 37708

it seems that my mail client brokes the patch content provided in first 
message. please consider to check the attached patch file in my second 
email.


On Saturday, October 12, 2019 11:47:15 AM +0330, Jonathan Brielmaier wrote:
> On 11.10.19 22:21, Reza Alizadeh Majd wrote:> +    (description
> "uchardet is an encoding detector library, which takes
>> a +sequence of bytes in an unknown character encoding without any
>> additional +information, and attempts to determine the encoding of the
>> text. Returned +encoding names are iconv-compatible.")
>
> What does this "+" do here? Are they broken texinfo syntax?
>
>

-- 
Regards
Reza Alizadeh Majd
PantherX Team

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#37708: [PATCH] gnu: add uchardet
       [not found] ` <7721cc22-fc20-41ab-affb-3a44d0947746@pantherx.org>
@ 2019-10-12 13:16   ` Ludovic Courtès
  2019-10-12 14:48     ` [bug#37708] " Reza Alizadeh Majd
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2019-10-12 13:16 UTC (permalink / raw)
  To: Reza Alizadeh Majd; +Cc: 37708-done

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

Hi Reza,

Reza Alizadeh Majd <r.majd@pantherx.org> skribis:

> From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <r.majd@pantherx.org>
> Date: Fri, 11 Oct 2019 23:23:21 +0330
> Subject: [PATCH] gnu: add uchardet
>
> * gnu/packages/freedesktop.scm (uchardet) New variable.

Applied with the modifications below, which address ‘guix lint’ warnings
(remember to run it next time :-)), enable tests, and clarify the
license.

Thank you for the patch!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1450 bytes --]

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 17736aa537..4339f14f35 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1423,16 +1423,18 @@ their MIME type.
     (source
       (origin
         (method url-fetch)
-        (uri (string-append "https://www.freedesktop.org/software/" 
+        (uri (string-append "https://www.freedesktop.org/software/"
                             name "/releases/" name "-" version ".tar.xz"))
         (sha256
           (base32 "0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f))
     (home-page "https://www.freedesktop.org/wiki/Software/uchardet/")
-    (synopsis "encoding detector library")
-    (description "uchardet is an encoding detector library, which takes a 
-sequence of bytes in an unknown character encoding without any additional 
-information, and attempts to determine the encoding of the text. Returned 
+    (synopsis "Encoding detector library")
+    (description "uchardet is an encoding detector library, which takes a
+sequence of bytes in an unknown character encoding without any additional
+information, and attempts to determine the encoding of the text.  Returned
 encoding names are iconv-compatible.")
+
+    ;; This combines code under MPL 1.1, LGPL 2.1+, and GPL 2.0+, so the
+    ;; combination is GPL 2.0+.
     (license license:gpl2+)))

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#37708] [PATCH] gnu: add uchardet
  2019-10-12 13:16   ` bug#37708: " Ludovic Courtès
@ 2019-10-12 14:48     ` Reza Alizadeh Majd
  0 siblings, 0 replies; 5+ messages in thread
From: Reza Alizadeh Majd @ 2019-10-12 14:48 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 37708-done

Hi Ludo, 

On Sat, Oct 12, 2019, at 4:46 PM, Ludovic Courtès wrote: 
> Applied with the modifications below, which address ‘guix lint’ warnings
> (remember to run it next time :-)), enable tests, and clarify the
> license.

Thanks for your notice about `guix lint`. I will keep that in mind for my later patch submissions.

-- 
Regards
Reza Alizadeh Majd
PantherX Team

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-10-12 14:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-11 20:21 [bug#37708] [PATCH] gnu: add uchardet Reza Alizadeh Majd
2019-10-12  8:17 ` Jonathan Brielmaier
2019-10-12  8:49   ` Reza Alizadeh Majd
     [not found] ` <7721cc22-fc20-41ab-affb-3a44d0947746@pantherx.org>
2019-10-12 13:16   ` bug#37708: " Ludovic Courtès
2019-10-12 14:48     ` [bug#37708] " Reza Alizadeh Majd

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.