From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50470) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSg63-0003sH-VK for guix-patches@gnu.org; Thu, 07 Nov 2019 06:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSg62-0001dh-M3 for guix-patches@gnu.org; Thu, 07 Nov 2019 06:37:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:32916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSg61-0001dQ-TI for guix-patches@gnu.org; Thu, 07 Nov 2019 06:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iSg61-0004jn-Li for guix-patches@gnu.org; Thu, 07 Nov 2019 06:37:01 -0500 Subject: [bug#38097] Add gnome-xyz for themes and shell extensions Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:50328) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSg5M-0003Ak-4F for guix-patches@gnu.org; Thu, 07 Nov 2019 06:36:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSg5L-0001UB-1F for guix-patches@gnu.org; Thu, 07 Nov 2019 06:36:20 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:40458) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSg5K-0001Tw-QR for guix-patches@gnu.org; Thu, 07 Nov 2019 06:36:18 -0500 Received: by mail-wr1-x434.google.com with SMTP id i10so2619063wrs.7 for ; Thu, 07 Nov 2019 03:36:18 -0800 (PST) References: From: Mathieu Othacehe In-reply-to: Date: Thu, 07 Nov 2019 12:36:14 +0100 Message-ID: <87ftizc40h.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 38097@debbugs.gnu.org Hello, Overall this looks fine, thanks. The indentation of the first patch is wrong. Also you have several lines hitting the 78 columns limit. You need to wrap them manually. I'm ok with the introduction of (gnu packages gnome-xyz) and using it for Matcha theme. Can you please send an updated version? Thanks, Mathieu > This patch series adds (gnu packages gnome-xyz) for GNOME themes[1] and > extensions[2]. I've initialized it with some packages that I > personally use. Another potential candidate for inclusion into this > file would for instance be the Matcha GTK theme (bug#38095). > > I'm not 100% sure on the licenses. In some places, I only found > LICENSE files without a comment specifying "or later" elsewhere -- > perhaps I've overlooked some. For now, I'm using the stricter versions > (sans "+"). > > [1] https://www.gnome-look.org/ > [2] https://extensions.gnome.org/