all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 39518-done@debbugs.gnu.org
Subject: bug#39518: [PATCH] add S-O-B
Date: Sun, 09 Feb 2020 20:37:45 +0100	[thread overview]
Message-ID: <87ftfj1rhy.fsf@nckx> (raw)
In-Reply-To: <CAEwRq=q7ZuF3iS8Z3hYirsjAufDO_qd-tvRMRwxEybWvLNcNcA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Vincent Legoll 写道：
> here is is patch with S-O-B

This is not necessary.  Signed-off-by is used in Guix when 
committing a patch by another author (usually because the author 
themselves lacks commit access):

  From: Vincent Legoll <vincent.legoll@gmail.com>
  Subject: <blah>

  <blaah>

  Signed-off-by: Tobias Geerinckx-Rice <me@tobias.gr>

You never add it for yourself.  So I've applied your first 
version, added my own S-O-B, and tweaked the commit message:

- Split it into 2 parts: a 1-line summary and a ≥1-line 
  enumeration of the changes.
- Capitalised the sentences.

Pushed as 13c6f9c9885092fe693ad29b0fe1e807de11a548.

Thanks!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2020-02-09 19:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09  9:06 [bug#39518] [PATCH] update musl URL Vincent Legoll
2020-02-09  9:13 ` [bug#39518] [PATCH] add S-O-B Vincent Legoll
2020-02-09 19:37   ` Tobias Geerinckx-Rice via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftfj1rhy.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=39518-done@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.