From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#39646: bug#39648: Reverse my commits on GNOME meta-package Date: Sat, 22 Feb 2020 18:08:28 +0100 Message-ID: <87ftf2y2gj.fsf@gnu.org> References: <6bad163b0ed969c5c1117f9fa7446631060a8d4d.camel@disroot.org> <875zg56nq4.fsf@nckx> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:40070) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5YH1-0000Tv-9R for bug-guix@gnu.org; Sat, 22 Feb 2020 12:09:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5YGz-0003bL-QB for bug-guix@gnu.org; Sat, 22 Feb 2020 12:09:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5YGz-0003bF-N2 for bug-guix@gnu.org; Sat, 22 Feb 2020 12:09:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5YGz-0000tw-JY for bug-guix@gnu.org; Sat, 22 Feb 2020 12:09:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <875zg56nq4.fsf@nckx> (Tobias Geerinckx-Rice's message of "Mon, 17 Feb 2020 20:02:59 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Tobias Geerinckx-Rice Cc: 39646@debbugs.gnu.org, 39648@debbugs.gnu.org, Raghav Gururajan --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Tobias & all! Tobias Geerinckx-Rice skribis: > Raghav Gururajan =E5=86=99=E9=81=93=EF=BC=9A >> Could you please reverse my following commits: >> >> 1) d36fa50fbf8169018193774782fd21f1b13b9c0e >> >> 2) 7922b6f795eb575084546ec9bfb9d40508a9378e >> >> 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f >> >> 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b > > Copy-pasted from #guix: > > Whoa there, that's drastic, let's put that on hold. > > The first two only add packages (did they break anything? what?), the > third has no effect on packages if your commit message is accurate. > > The fourth is the only one that removes packages, and even that might > be better tweaked (this time: with comments noting what each non-core > package brings to the GNOME table) than flat-out reverted. > > What do you think? I agree. As a stop-gap measure, I propose to commit the following change real soon. I=E2=80=99ve tested it in a VM; it addresses the points = Andy raised by re-adding the important bits mentioned in . Raghav, don=E2=80=99t worry, we all make mistakes! We can refine this calm= ly later on. Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 3c63ab283d..c64b182869 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -7906,7 +7906,29 @@ world.") ("yelp" ,yelp) ;; Others ("hicolor-icon-theme" ,hicolor-icon-theme) - ("gnome-online-accounts" ,gnome-online-accounts))) + ("gnome-online-accounts" ,gnome-online-accounts) + + ;; Packages not part of GNOME proper but that are needed for a good + ;; experience. See . + ;; XXX: Find out exactly which ones are needed and why. + ("font-cantarell" ,font-cantarell) + ("font-dejavu" ,font-dejavu) + ("at-spi2-core" ,at-spi2-core) + ("dbus" ,dbus) + ("dconf" ,dconf) + ("desktop-file-utils" ,desktop-file-utils) + ("gnome-default-applications" ,gnome-default-applications) + ("gnome-themes-standard" ,gnome-themes-standard) + ("gst-plugins-base" ,gst-plugins-base) + ("gst-plugins-good" ,gst-plugins-good) + ("gucharmap" ,gucharmap) + ("pinentry-gnome3" ,pinentry-gnome3) + ("pulseaudio" ,pulseaudio) + ("shared-mime-info" ,shared-mime-info) + ("system-config-printer" ,system-config-printer) + ("xdg-user-dirs" ,xdg-user-dirs) + ("yelp" ,yelp) + ("zenity" ,zenity))) (synopsis "The GNU desktop environment") (home-page "https://www.gnome.org/") (description --=-=-=--