From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:59511)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5u23-0001lS-CM
 for guix-patches@gnu.org; Sun, 23 Feb 2020 11:23:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5u22-0002Cw-IJ
 for guix-patches@gnu.org; Sun, 23 Feb 2020 11:23:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:45551)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j5u22-0002Cs-FQ
 for guix-patches@gnu.org; Sun, 23 Feb 2020 11:23:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5u22-0008Ah-CC
 for guix-patches@gnu.org; Sun, 23 Feb 2020 11:23:02 -0500
Subject: [bug#37868] [PATCH v2 1/2] build-system/linux-module: Disable depmod.
Resent-Message-ID: <handler.37868.B37868.158247493231292@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191112172048.61ba69eb@scratchpost.org>
 <20200218094207.6196-1-dannym@scratchpost.org>
 <20200218094207.6196-2-dannym@scratchpost.org>
Date: Sun, 23 Feb 2020 17:22:02 +0100
In-Reply-To: <20200218094207.6196-2-dannym@scratchpost.org> (Danny
 Milosavljevic's message of "Tue, 18 Feb 2020 10:42:06 +0100")
Message-ID: <87ftf1s28l.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Mark H Weaver <mhw@netris.org>, 37868@debbugs.gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * guix/build/linux-module-build-system.scm (install): Disable depmod.

[...]

> -            (string-append "DEPMOD=3D" kmod "/bin/depmod")
> +            "DEPMOD=3Dtrue" ; disable depmod.

Could you make the comment something like:

  ;; Disable depmod because X and Y.

Think of our future selves.  :-)

Otherwise LGTM.

Ludo=E2=80=99.