From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:56445)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5yRv-0003wT-TC
 for guix-patches@gnu.org; Sun, 23 Feb 2020 16:06:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5yRu-0001El-R8
 for guix-patches@gnu.org; Sun, 23 Feb 2020 16:06:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:45692)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j5yRu-0001Eh-Ok
 for guix-patches@gnu.org; Sun, 23 Feb 2020 16:06:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5yRu-0000kB-KG
 for guix-patches@gnu.org; Sun, 23 Feb 2020 16:06:02 -0500
Subject: [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than
 absolute and relative threshold.
Resent-Message-ID: <handler.39734.B39734.15824919472826@debbugs.gnu.org>
From: Pierre Neidhardt <mail@ambrevar.xyz>
In-Reply-To: <87tv3hs2u0.fsf@gnu.org>
References: <20200222104653.1324-1-mail@ambrevar.xyz> <874kvizxi6.fsf@gnu.org>
 <87tv3ig8bc.fsf@ambrevar.xyz> <87h7zhttk1.fsf@gnu.org>
 <874kvhfrqk.fsf@ambrevar.xyz> <875zfxtlrk.fsf@gnu.org>
 <87pne5e581.fsf@ambrevar.xyz> <87tv3hs2u0.fsf@gnu.org>
Date: Sun, 23 Feb 2020 22:05:36 +0100
Message-ID: <87ftf1dnfj.fsf@ambrevar.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 39734@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> So back to the original patch=E2=80=A6 I think we should use =E2=80=98siz=
e->number=E2=80=99 for
> the absolute threshold.
>
> I=E2=80=99m also still mildly reluctant to the addition of
> =E2=80=98GUIX_DISK_SPACE_WARNING_ABSOLUTE=E2=80=99 (one more variable and=
 a weird
> name=E2=80=94=E2=80=9Cabsolute warning=E2=80=9D?).  An option could be to=
 allow
> =E2=80=98GUIX_DISK_SPACE_WARNING=E2=80=99 to optionally contain both thre=
sholds.  These
> would be valid values:
>
>   1GiB;10%
>   15            ;15% relative, and default absolute
>   15%           ;same
>   1G            ;1G absolute, and default relative

The above logic implies that we test against size->number, and if it
fails then we set the relative threshold.

But a size->number quits Guile.  Should we error out instead?

=2D-=20
Pierre Neidhardt
https://ambrevar.xyz/

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5S6SAACgkQm9z0l6S7
zH9TOgf/aT0W2CaU7E6N3WzGEveBvAiQYvAsZKN1Yx6Dh2I2rphyIuCtTG7jxaYt
d1bw77vhspqkysyvXAtXU5mUsqCuwx547BoblBfeMeaNN2Kdh2p8MNsPW2eYcptW
+Cm57uv7MGHFoi5g/ZBWd17J9xuInOqeKbKJIVXIfvxbGqyEMAX5hbMYveRnnNfF
TlfRAQQn7f3lKSRNA1YRiDBPYcHskOpd7XLIMRGkmdvt/+vsJkn4fiC7FeczlutB
2ERanfO1W+uD0KHxOf16HwnEThqOGun0cWPwqjLrbNT+HkNnP5CQeUZse91dGnNq
v8GHNWqVrnO6PySPM0TIMRzrzN3E3g==
=HyVW
-----END PGP SIGNATURE-----
--=-=-=--