From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#40482: Test failure in tests/packages.scm after merging master into core-updates Date: Tue, 07 Apr 2020 13:31:24 +0200 Message-ID: <87ftdfo7lf.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:52572) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLmSb-0004TR-5t for bug-guix@gnu.org; Tue, 07 Apr 2020 07:32:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLmSZ-0005D7-Bn for bug-guix@gnu.org; Tue, 07 Apr 2020 07:32:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLmSY-0005C7-Jw for bug-guix@gnu.org; Tue, 07 Apr 2020 07:32:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jLmSY-0001op-Gk for bug-guix@gnu.org; Tue, 07 Apr 2020 07:32:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:52471) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLmS1-0003t9-3j for bug-guix@gnu.org; Tue, 07 Apr 2020 07:31:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLmRz-0004X4-Vt for bug-guix@gnu.org; Tue, 07 Apr 2020 07:31:29 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56303) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLmRz-0004Wc-Mj for bug-guix@gnu.org; Tue, 07 Apr 2020 07:31:27 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3CF785C026A for ; Tue, 7 Apr 2020 07:31:27 -0400 (EDT) Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id C72BA306D0EF for ; Tue, 7 Apr 2020 07:31:26 -0400 (EDT) List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: 40482@debbugs.gnu.org --=-=-= Content-Type: text/plain On the current "core-updates" branch (commit a533c5a1835cbeafaf595c4474e2ce6adde7de8d), one test starts to fail if commits 190ddfe21e3d87719733d12fb9b5eb176125a49f and a187cc562890895ad41dfad00eb1d5c4a4b00936 are applied: --8<---------------cut here---------------start------------->8--- test-name: package-transitive-supported-systems, implicit inputs location: tests/packages.scm:362 source: + (test-equal + "package-transitive-supported-systems, implicit inputs" + %supported-systems + (let ((p (dummy-package + "foo" + (build-system gnu-build-system) + (supported-systems + `("does-not-exist" "foobar" ,@%supported-systems))))) + (parameterize + ((%current-system "armhf-linux")) + (package-transitive-supported-systems p)))) expected-value: ("x86_64-linux" "i686-linux" "armhf-linux" "aarch64-linux" "mips64el-linux" "i586-gnu") actual-value: ("x86_64-linux" "i686-linux") result: FAIL --8<---------------cut here---------------end--------------->8--- After some trial and error I found that simply removing the test added by commit a187cc562890895ad41dfad00eb1d5c4a4b00936 will make the above test pass! Moving the test further down the file (after the one above) will _also_ succeed. Apparently there is some side effect caused by running the new test that leaks into the test mentioned above. For completeness, here is the new test that makes the above fail. --8<---------------cut here---------------start------------->8--- test-name: transaction-upgrade-entry, grafts location: tests/packages.scm:151 source: + (test-assert + "transaction-upgrade-entry, grafts" + (with-build-handler + (const 'failed!) + (parameterize + ((%graft? #t)) + (let* ((old (dummy-package "foo" (version "1"))) + (bar (dummy-package + "bar" + (version "0") + (replacement old))) + (new (dummy-package + "foo" + (version "1") + (inputs `(("bar" ,bar))))) + (tx (mock ((gnu packages) + find-best-packages-by-name + (const (list new))) + (transaction-upgrade-entry + %store + (manifest-entry + (inherit (package->manifest-entry old)) + (item (string-append + (%store-prefix) + "/" + (make-string 32 #\e) + "-foo-1"))) + (manifest-transaction))))) + (and (match (manifest-transaction-install tx) + ((($ "foo" "1" "out" item)) + (eq? item new))) + (null? (manifest-transaction-remove tx))))))) actual-value: #t result: PASS --8<---------------cut here---------------end--------------->8--- --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6MZIwACgkQoqBt8qM6 VPppswgAkO0w+VlKLDhsNDuGoGvhJyxLXj3uNiu+Aa/MPmUZ4JVfn7KR6A6GE78k IqRl6iI4bqEPq7R/2sKAm7hEiGvVW29IuqqJrO6u0hTeRU4tmjnTRl132HoXw6jr nRXVyFwHLxDOrmME2f8IaPOc0Lne0UWDJR/bYs9E4gobr6s5RMyKBi9R+ECULQvK kGpnbOSgBHm9/2l+zCX6DUS2yn1+nJcH51rk4hhF9S8gz0mnDmQhDErkl5AB8oeM 2qAdUy/4wtmjgpggzv1ACe4rmaDtOxFTr95gNzL0mkerb16OWutu1ymee3VQyKjr Np1BZse+9p3xpq7DPjyDcV2CtytFLw== =P/+/ -----END PGP SIGNATURE----- --=-=-=--