From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41247) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOiYF-0005qk-4x for guix-patches@gnu.org; Wed, 15 Apr 2020 09:58:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOiYD-0008QP-U7 for guix-patches@gnu.org; Wed, 15 Apr 2020 09:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOiYD-0008QI-OP for guix-patches@gnu.org; Wed, 15 Apr 2020 09:58:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOiYD-0007r9-Mz for guix-patches@gnu.org; Wed, 15 Apr 2020 09:58:01 -0400 Subject: [bug#40426] [PATCH] Add g-golf Resent-Message-ID: Message-ID: <87ftd426p6.fsf@nckx> References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> In-reply-to: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> Date: Wed, 15 Apr 2020 15:57:03 +0200 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: Vitaliy Shatrov Cc: 40426@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Vitaliy, Vitaliy Shatrov via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > str1ngs and nly want it to be submitted to guix, and i was=20 > proudly take this task. Package was copied "as-is", and tested=20 > as per Guix manual. Thank you! > There is desire to package be named "g-golf", and not as=20 > "guile-g-golf", as the package name stands for "Gnome: Guile=20 > Object Library For". Too clever for me :-) It's a Guile library; hence the correct=20 Guix name (and variable) is =E2=80=98guile-g-golf=E2=80=99. We have plenty= of=20 =E2=80=98python-pyfoo=E2=80=99 packages to keep it company. > Subject: [PATCH] gnu: Add g-golf > > * gnu/packages/guile-xyz.scm (g-golf): New variable Nitpick: both lines should end with a full stop. > +(define-public g-golf Could you add a comment here explaining why we use a git commit,=20 instead of a release tarball or tag? I assume there are none;=20 that would do as comment. However=E2=80=A6 > + (let ((commit "4a4edf25e4877df9182c77843bdd98ab59e13ef7")) > + (package > + (name "g-golf") > + (version (git-version "1" "683" commit)) =E2=80=A6=E2=80=981=E2=80=99 means the project has released version 1 prior= to this=20 commit, or at least regards this commit as part of the =E2=80=981=E2=80=99 = series.=20 I didn't spot any version number on the home page, NEWS file, git=20 tags, =E2=80=A6 If there is no =E2=80=981=E2=80=99 release, use =E2=80=980.0.0=E2=80=99. The second field (REVISION) should be =E2=80=980=E2=80=99, since this is th= e first=20 *Guix* revision of this package. The idea is that you increment=20 the revision each time you change COMMIT, so Guix knows which=20 commit is newer and can =E2=80=98guix package -u=E2=80=99 properly. Since the 2 should be updated together, bind them together: (let ((commit "f00") (revision "0")) =E2=80=A6 You obviously got =E2=80=98683=E2=80=99 from somewhere though. Where? > + `(#:tests? #t Does the guile-build-system disable tests by default? (I skimmed=20 the code but didn't find anything.) Otherwise, this can be=20 omitted. > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'tests-work-arounds Prefer =E2=80=98verb-thing=E2=80=99; makes it much easier to skim unfamilia= r=20 packages. In this case we're not really working around the tests themselves,=20 so I'd go with the boring =E2=80=98patch-tests=E2=80=99. + (lambda* (#:key inputs #:allow-other-keys) + ;; In build environment, There is no /dev/tty + (substitute* + "test-suite/tests/gobject.scm" + (("/dev/tty") "/dev/null")))) For now, all phases must return #t. SUBSTITUTE* doesn't, so we=20 need (lambda =E2=80=A6 =E2=80=A6 (substitute* "test-suite/tests/gobject.scm" (("/dev/tty") "/dev/null")) #t) No need to put the file name on its own line here. + (add-before 'configure 'substitute-libs Bytes are cheap: =E2=80=98libraries=E2=80=99. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6XEq8ACgkQ2Imw8BjF STwwfQ/9GmS0s95NsVTc9ZZHJsk88DdNeq1QxtAqkou6Et0fz67nYiGIwwxpgIWM iqqtAtXB/sL0oulycjoJD1r66I9Sv2+mrl6/2Ov1PIe+BLREjhU20K8Ab0RuH3OK VtGewQpPMA4awXG5mS2R6EanKe83Mqk9p8kx2HUgifuiAjSDU5OX657Ai3urjAPc cm8X1pSPTaq2APLb4sHrMIFMdTG7y/KbQ7zH50m521H5HNNVEwUz59+Sl5y2rFmD Dp9DIZlggs6WgAnuj1bwu1v4YvfZ1b1AN02CSFZxJR97+QMCB0pIkkjTIlK5PUTX fuB/3J/glZw1sQldsw5lLo5b1SUsLSnIbJzL5ZwhWHK9is/vCfwaXmiKw1p+Z8Wk pAAkFTGR8DRPcVuYvBzOekjX1yjwffhkxv90solxz6/zrikRWeXs0aNfrAdMAaoN Y1Lkn/MLX7xuHPAFLFzUfU3MVvCsgP3mUSREkczCuAunf9J/ENKnvbakyIRvOv1i Ro4iH2mHFfjo6IZXUmMpHxHDpEGjZhalJ/az2kqk96up1t6fRMgfrmMbAuSTsa5U O0pkeRLt3pxEqKrk01aOSwlLz/ARYBD7g5XtiSCYGq9uqTQaudVlCRX2IrDT9gB3 UP2q7L+Ao6KuB26PKFO2t3yM+yU91R11aPK06cVGhfcfr9Q00RE= =4vjA -----END PGP SIGNATURE----- --=-=-=--