From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:38144)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBMR-0003MK-8w
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:08:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBMQ-0004Wn-Ss
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:08:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39743)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jRBMQ-0004Wi-HG
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:08:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBMQ-0006D7-A9
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:08:02 -0400
Subject: [bug#40677] [PATCH 03/18] gnu: jami.scm: Add and use a generalized
 procedure for applying patches made by Savoir-faire linux to Jami
 dependencies.
Resent-Message-ID: <handler.40677.B40677.158754647123856@debbugs.gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
References: <20200421161032.1847-1-tona_kosmicznego_smiecia@interia.pl>
 <20200421161032.1847-3-tona_kosmicznego_smiecia@interia.pl>
Date: Wed, 22 Apr 2020 11:07:41 +0200
In-Reply-To: <20200421161032.1847-3-tona_kosmicznego_smiecia@interia.pl> (Jan
 Wielkiewicz's message of "Tue, 21 Apr 2020 18:10:17 +0200")
Message-ID: <87ftcvq46a.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
Cc: 40677@debbugs.gnu.org


> +;; Savoir-Faire Linux modifies many libraries to add features
> +;; to Jami. This procedure makes applying patches to a given
> +;; package easy.
> +(define-public jami-apply-dependency-patches

This does not need to be public.

> -     `(("savoir-faire-linux-patches" ,(jami-source))
> +     `(("SFL-patches" ,(jami-source))

I do prefer the old version without upper case.

> +       #:modules ((guix build utils)
> +                  ,@(@@ (guix build-system gnu) %default-modules))

pjproject is using the gnu-build-system which should provide all those
modules, so I don't think you need this.

Thanks,

Mathieu