From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8B3jNpxCQGHRdAAAgWs5BA (envelope-from ) for ; Tue, 14 Sep 2021 08:35:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0MppMpxCQGHwMgAAbx9fmQ (envelope-from ) for ; Tue, 14 Sep 2021 06:35:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CC5C223E for ; Tue, 14 Sep 2021 08:35:08 +0200 (CEST) Received: from localhost ([::1]:39944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ227-0004Du-PU for larch@yhetil.org; Tue, 14 Sep 2021 02:35:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ222-0004DW-Px for guix-patches@gnu.org; Tue, 14 Sep 2021 02:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ222-0008Mj-Gw for guix-patches@gnu.org; Tue, 14 Sep 2021 02:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ222-0006q2-86 for guix-patches@gnu.org; Tue, 14 Sep 2021 02:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50504] [PATCH] home-services: Add Mcron. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Sep 2021 06:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50504 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 50504@debbugs.gnu.org Cc: Oleg Pykhalov , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 50504-submit@debbugs.gnu.org id=B50504.163160129726273 (code B ref 50504); Tue, 14 Sep 2021 06:35:02 +0000 Received: (at 50504) by debbugs.gnu.org; 14 Sep 2021 06:34:57 +0000 Received: from localhost ([127.0.0.1]:47319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ21w-0006ph-Pq for submit@debbugs.gnu.org; Tue, 14 Sep 2021 02:34:57 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:34791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ21u-0006pS-To for 50504@debbugs.gnu.org; Tue, 14 Sep 2021 02:34:55 -0400 Received: by mail-lf1-f49.google.com with SMTP id l11so26508668lfe.1 for <50504@debbugs.gnu.org>; Mon, 13 Sep 2021 23:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=+rpJPwi99jGNkQMQqEy1MFC1f8GnkbNgmwk6pTafWUA=; b=MGxVD52Dk+oqnybnIzU23Q8bJoJBvH9+pJ9cZ+TzdvDqZozhtgupbdue10pCNcxcI3 M1Nvext7zOnoCX+YbVky5bmCOzefmr6UoANx1M8Ndl/sdgnNANi76l94FAVEUSgfdfGu IozSfQjDPP4fmvTcO2UZPm6PRuW3W62uiKjy3JEUhphD+q6tT4ZMcy75A3tCDLtZUpSN 2e4JF++vKjAmReviioc3drrKFsxI+HmFyFOz8ipdurWjtQEklDzpiQfUS5Pgdaoyovfh wMdPv/7ikM0GWdGvngej0ZtItvOqBcUZBTI8h0cqn0tlH0mMvQMGisZpF1du56qh34uG E5gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=+rpJPwi99jGNkQMQqEy1MFC1f8GnkbNgmwk6pTafWUA=; b=jIM/yXEtNr51o1sYccPhYMuuzrjqBREDM3UMICCCwkrAz5ZnVYIuy+HLatqnTGPKWn 6iFhBxlFA7Ww2vOYwm/8jJwc0htmcxBP+31obTIeZzWokEh9Wz4i3DJYFRiZ8X+dKJ1A cQED3E5+0kjNI8sbDyskv0eGvkhKzCdkLed8j4f3s5fYwvqxObZuNj0OaFzKJvbWW5f2 fWOFbojT8N70Ar6CNUrkjvPE9w2FFHg1KcX2I1ppOhMZikF1WhOII63GScbGPddJNkrJ ouArnETuTFZ9Z6lMhKcKRAs68ccS1+XhPzvV/H6sfvDwVO8jW5F5X3z8ACiV0p6RiWhe nQiA== X-Gm-Message-State: AOAM5301nUlRDOJbQP5/HfcEr1lGJpIaDK/quXgQD5hpNC+MJ0hMpkwz wBNvXOROzA8CexXAPdKlbP47Ig== X-Google-Smtp-Source: ABdhPJyvvfhjyMm4L/1jNNUGam3jdHSdegNvTZcB+AFl0089YQU6adCq0im3wQEynappX8v8gqOWcA== X-Received: by 2002:a19:8c4c:: with SMTP id i12mr11956647lfj.445.1631601288862; Mon, 13 Sep 2021 23:34:48 -0700 (PDT) Received: from localhost (109-252-93-92.nat.spd-mgts.ru. [109.252.93.92]) by smtp.gmail.com with ESMTPSA id a11sm620360lfo.5.2021.09.13.23.34.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 23:34:48 -0700 (PDT) From: Andrew Tropin In-Reply-To: <87zgsgtpr4.fsf@yoctocell.xyz> References: <8735qc66mt.fsf@trop.in> <87a6kkxpcp.fsf@yoctocell.xyz> <87a6khrn3x.fsf@trop.in> <87zgsgtpr4.fsf@yoctocell.xyz> Date: Tue, 14 Sep 2021 09:34:45 +0300 Message-ID: <87fsu7mzqy.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631601308; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+rpJPwi99jGNkQMQqEy1MFC1f8GnkbNgmwk6pTafWUA=; b=ANLHqQi6KP6dgqCpsxiE9p0kwYFPprbSsAjgmePYzXlEsFNvFcgBHfFmy5Ouj7pp6nESuc PBe43YlTIXVFb5PSNxuDRFX5ROBvrMUWAaPchKacKPi1tNYePN61dS6QfiRmcLN6Dq2JT0 al0cCVaFjD6ICPFGG964oyLplB5dkDHz2V6Y5jpksCOiEmCWNIU1GxbFWB9t01GkTDtti1 OFuJXLy+An5FHmMo8h66+WR5+E66fpKSOb7KSxkf0TQDFC+Ogj7G38humM4HJ4Ou9B5niF lSVQE3twOoegjMMrRavmeGP12W4DcA1KZQcXs3Zl0hUKrr3kmYGuOFcPJ2mcNA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631601308; a=rsa-sha256; cv=none; b=AAK7MS1tmQI1Ulxm2Sa9CVPBVMcf5rOlAi2x3rszTelip+9aUhH9JqradCHl0D1GXhVT/X O+JfuBPzqZ8+0xJm2lW6AD64JG7JsJ81hMQpsqpZyf4mF/yCPZYf3p8fF6nbqbwAaL33/h XtmWg5yti4Z/J6qFaMe+SOmAWlmwvJtKfzPhUXHXZH22neT2szdwmcK0TB2jN56jlWbM9e T6/Vd8vIlD1YYrz4f5MA+rPkeGti8xmW4WzBCVrKbNXnJs2ZmY9DUFxkcWz6m6CAEAGyPQ viijRJ9oY2E9bWwbT5fqVSqtIy6tN/n9T4y/DemAKYZ2O41roENAVMT0uXtcJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=MGxVD52D; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.50 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=MGxVD52D; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8CC5C223E X-Spam-Score: -0.50 X-Migadu-Scanner: scn1.migadu.com X-TUID: bM8XkekDZslr --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-09-13 18:16, Xinglu Chen wrote: > On Mon, Sep 13 2021, Andrew Tropin wrote: > >> On 2021-09-10 20:22, Xinglu Chen wrote: >> >>> On Fri, Sep 10 2021, Andrew Tropin wrote: >>> >>>> * gnu/home-services/mcron.scm: New file. >>>> * gnu/local.mk: Add this. >>>> * doc/guix.texi: Add documentation about Mcron Home Service. >>>> --- >>>> >>>> This is the last of home services I consider "must-have" for wip-guix-= home. >>>> >>>> It reuses two functions from (gnu services mcron) via @@, which can be >>>> considered as a hack, the alternative solution is to expose those func= tions >>>> via #:export, I can do it if it's a preffered way or suggest other ide= as, >>>> please. The discussion on this topic: https://issues.guix.gnu.org/472= 38 >>>> Included Ludovic and Xinglu in CC. >>> >>> An alternative would be put it the (gnu service mcron) to share more >>> code between system service and home service. This was discussed >>> briefly on rde-devel[1]. It might be worth discussing this issue on >>> guix-devel before we add too many home service. >>> >> >> I'll make a thread on possible modules naming for home services later >> this week and will discuss this thing too. > > Cool! > >>>> I took a brief look at the testing approach, seems the most relevant is >>>> guix-system.sh and it is just a shell script, which runs a few guix sy= stem >>>> subcommand and check if they fail or succeed. Please let me know, wha= t is a >>>> preferred way for writing tests and I'll try to provide some tests for= Guix >>>> Home in the separate patch. >>> >>> The =E2=80=98guix-system.sh=E2=80=99 script seems to only test the =E2= =80=98guix system=E2=80=99 >>> command, which doesn=E2=80=99t seem that related to the home services. = I guess >>> we could check the contents of the generated config files. There is >>> (gnu build marionette) which creates a VM; we could then check that the >>> relevant process is running. Maybe there is a better approach, though. >>> >> >> It was a general question about tests for Guix Home, not Mcron home >> service, sorry for the confusion. > > No worries! To clarify, you were referring to the =E2=80=98guix home=E2= =80=99 command > line utilities when you wrote =E2=80=9CGuix Home=E2=80=9D, right? If so,= they could > probably be based on the =E2=80=98guix-system.sh=E2=80=99 test. To the whole Guix Home and found `guix-system.sh` to be most relevant, but later I saw that there are some tests for services too, both in tests/services and gnu/tests. Probably I need to look at them more carefully and write some in the same way. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmFAQoUACgkQIgjSCVjB 3rAoTA/+NjLhgnoPMepmFhVYmTXYVgu/TtPSpsA8INHbBGR1V/CTKo5GqIPg/sdR 40Kgj9ugnBnnQKh1KpPDq/qIKSPV3qmKGeB/sNU8sRfedTXYgxpDO6xvWxITQTxb HZNxDDxA2h6tuNOOy3NjvtmLYZYKLhYUeI4ueCPe8DcVGa/FNcDlGUhiVrQmbaez +HP9fV1Cq/dJs3jXjaRQLR2fuGG0K8YQNKiyLYwBsesW6ME/Khpo5ap9UnjMHYgI RtDrBYJIugXcB9TJpvUMbdXu6MuAP6Y6ZFa4rkAFq7Z26ezLfATggksoFHkG7BXA ogyxOEOxcOoT5or9zcpTqukK4d8kqENMIIKPCEVIjrAi0WdKGkXoRNFKzCZt5RZ2 xnPB0vblF1TXVVTrrx5Q5n6KnEcMHK+lsFmPp/GHRRcOCIG/B2nh85NTFrY0/Eno wJYE+h3SZd8onnfBQYXuQgP3Ns+dfO3x50Qkymf59OI4SpL7Owk0LDyg2RrorqH3 mbz2qZDi+MnuZxlyfb8pBP09ergCIsVvVPrzYi6AFZJswExD6CfFelo8nO1q8w8N m1NiI9SvelJQv9oDD183UdzpoypH9jXfpBQLpeDOSONfyegkVbR1T4Ds/1mQkfCw xYHFSwdYM5bhMWeUCisIXhVJIJtCGyeitiAv98HWIJ3GAlHLcKw= =Bd9e -----END PGP SIGNATURE----- --=-=-=--