From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MJ0hKv89VmFRaAEAgWs5BA (envelope-from ) for ; Fri, 01 Oct 2021 00:45:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4EWqJf89VmGUNAAAbx9fmQ (envelope-from ) for ; Thu, 30 Sep 2021 22:45:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC4BA2CD53 for ; Fri, 1 Oct 2021 00:45:18 +0200 (CEST) Received: from localhost ([::1]:56478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mW4nk-0001MU-Ui for larch@yhetil.org; Thu, 30 Sep 2021 18:45:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mW4nW-0001MH-0v for guix-patches@gnu.org; Thu, 30 Sep 2021 18:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mW4nV-0005vB-OF for guix-patches@gnu.org; Thu, 30 Sep 2021 18:45:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mW4nV-0000H9-II for guix-patches@gnu.org; Thu, 30 Sep 2021 18:45:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50722] [PATCH] gnu: Update amsynth to 1.12.2 Resent-From: Thomas Albers Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 30 Sep 2021 22:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50722 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 50722@debbugs.gnu.org Received: via spool by 50722-submit@debbugs.gnu.org id=B50722.1633041857996 (code B ref 50722); Thu, 30 Sep 2021 22:45:01 +0000 Received: (at 50722) by debbugs.gnu.org; 30 Sep 2021 22:44:17 +0000 Received: from localhost ([127.0.0.1]:54278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mW4mi-0000Fw-6h for submit@debbugs.gnu.org; Thu, 30 Sep 2021 18:44:17 -0400 Received: from vmd69031.contaboserver.net ([161.97.172.214]:42184 helo=mail.thomaslabs.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mW4mf-0000Fm-Pl for 50722@debbugs.gnu.org; Thu, 30 Sep 2021 18:44:11 -0400 Received: from laptop.thomaslabs.org (ip2505fce3.dynamic.kabel-deutschland.de [37.5.252.227]) by mail.thomaslabs.org (Postfix) with ESMTPSA id 0B1F39C005C; Fri, 1 Oct 2021 00:44:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thomaslabs.org; s=mail; t=1633041848; bh=+afXSagk2JOlJF58f+U+vH2c0dtUa5H/gavm3xQVarw=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=WK0BTFOCcKrSmXPxrcsnhaBszkH8YzqxnhOtDWMY+DAJ2gwhveHWVS2LJXDVJwVA1 YRmj6g6wH2ixTGndAQDA3jCn7rkas5pv0euD9wvE25CiB6i9v89+VkaeRkb7bAbJwX o18GMjXJ4bMOLMzEQB+g3Eiz9DJalslVEAk0dwvN3QH2NdTIgb+7z88Tb+ot+f+UeT 1aZxKBjvnfzJVE7leuup4D9lKM5sP6t4zdOOtQEGxz+DvI0/sEw4BGnFuRQdyoul7R JEbJh+OHK28AUI3m4zuGLGm/+FhVDq2QuPUx+2Bu8wpVz7puTS1c5xo+IzSU5pA35c D4g7t8RrGoNSw== References: <20210921141701.6928-1-thomas@thomaslabs.org> User-agent: mu4e 1.6.6; emacs 27.2 Date: Fri, 01 Oct 2021 00:43:22 +0200 In-reply-to: Message-ID: <87fstlzntc.fsf@thomaslabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thomas Albers X-ACL-Warn: , Thomas Albers via Guix-patches From: Thomas Albers via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633041919; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QfjrANePqaz3q1+9cXmXFSxanbt779R2i9xab2lvEgQ=; b=tOk0rkasCRNt7s05niCCeb4oYhECaryuatM7cXHB9jX43jhmv9l9SZGxGClXGHEtevydQt uB1B2xlt1wLX9I7tfWoWWRRQVTAm3xzPZNCbYMd9RRrlLO9QLowqk+KHWLCJAMp1dsFMs2 LmU/+siOaHx65Q3fvlHJphndF60vUk36vUh3VJTiAGsqylPwNbSaQbI6lJLwcEV85vyJEL V4Aaw0+MuSubQBGkaRMXR8b4kRLGc6VLAa4lLFzzGe7BCLvZWGhPSmwZoTBzItCvBtf1UH OcoCJ6MgwTTfWc+nHJAi4AwtpJyV+Ng/ivbPmYhygOctFeTR6Jr910rfc7ZfXA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633041919; a=rsa-sha256; cv=none; b=WuAct57JaUuSL8HHG0zU7r3uXhRuMHkCvLUxK5FcNgAAHrWM7lPVow2pcHQuE3xQRwQy9e 8Ocwhz8ASvGqaas5aiqEwHZDmiZtsawYg6W9JY6jvwKe1lWxzaAFBHjvavpQj+5rL+c4h5 oGgo1HpAbGUlgCU1QitBW9144eq0+3WZZUuk4e5n2t4U7lPcAiZdIwhfR4qOHHSssbaXgY Ov/bUQXpESMk0a4TPdTTu93LyygR1+jTGf6psR7Z/9ht/j7BkRRY6jvabVh0MyaV2x7ugS G8WxmpxQTmdv0lM/oKW/IikdKOSS1qdz3Y5adWaTEf6+pVSZhNZuHjCKgWgJXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=thomaslabs.org header.s=mail header.b=WK0BTFOC; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=thomaslabs.org header.s=mail header.b=WK0BTFOC; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BC4BA2CD53 X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: twWcZVw2G8RD Hello Efraim, I've found the cause for the LASH runtime error. LASH was never used by amsynth. As of version 1.7.1 the `lash.c` source file had a `#ifdef WITH_LASH` block for enabling lash support, WITH_LASH was however never defined. This can be easily checked by adding `#error "LASH is actually being used"` immediately after the #ifdef. Starting with version 1.9 the lash related functions actually get included into the binary and cause the error complaining about the lash server not being available. Because LASH was never used to begin with, I've decided to remove it. I am sending a new patch including this changes. Greetings, Thomas Efraim Flashner writes: > [[PGP Signed Part:Undecided]] > Couple of comments about the patch: > > gsettings-desktop-schemas don't seem to be needed at build time, and it > launched fine for me when I removed it from the build entirely. > > When I launuched it from the command line I got errors about not being > able to connect to lash. > > Is the lash bit a regression from the currently packaged version? Are > you sure gsettings-desktop-schemas is actually needed? > > Thanks. > > > On Tue, Sep 21, 2021 at 04:17:01PM +0200, Thomas Albers via Guix-patches = via wrote: >> --- >> gnu/packages/music.scm | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm >> index ff1330d228..fe64b2af1b 100644 >> --- a/gnu/packages/music.scm >> +++ b/gnu/packages/music.scm >> @@ -43,6 +43,7 @@ >> ;;; Copyright =C2=A9 2021 Felix Gruber >> ;;; Copyright =C2=A9 2021 Simon Streit >> ;;; Copyright =C2=A9 2021 Xinglu Chen >> +;;; Copyright =C2=A9 2021 Thomas Albers Raviola >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -2354,16 +2355,16 @@ special variant of additive synthesis.") >> (define-public amsynth >> (package >> (name "amsynth") >> - (version "1.7.1") >> + (version "1.12.2") >> (source >> (origin >> (method url-fetch) >> (uri (string-append "https://github.com/amsynth/amsynth/releases= /" >> "download/release-" version >> - "/amsynth-" version ".tar.bz2")) >> + "/amsynth-" version ".tar.gz")) >> (sha256 >> (base32 >> - "1882pfcmf3rqg3vd4qflzkppcv158d748i603spqjbxqi8z7x7w0")))) >> + "0lhp7fymm2fids02y43cy422jzmdiraszll1mk3gzlbfwg33ds1i")))) >> (build-system gnu-build-system) >> (arguments >> `(#:phases >> @@ -2372,13 +2373,12 @@ special variant of additive synthesis.") >> (lambda _ >> (substitute* "src/GUI/editor_pane.c" >> (("/usr/bin/unzip") (which "unzip"))) >> - (substitute* "src/GUI/GUI.cc" >> + (substitute* "src/GUI/MainMenu.cpp" >> (("/usr/bin/which") (which "which"))) >> #t))))) >> (inputs >> `(("alsa-lib" ,alsa-lib) >> ("gtk+" ,gtk+-2) >> - ("gtkmm" ,gtkmm-2) >> ("jack" ,jack-1) >> ("lash" ,lash) >> ("libsndfile" ,libsndfile) >> @@ -2386,6 +2386,8 @@ special variant of additive synthesis.") >> ;; External commands invoked at run time. >> ("unzip" ,unzip) >> ("which" ,which))) >> + (propagated-inputs >> + `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas))) >> (native-inputs >> `(("intltool" ,intltool) >> ("pkg-config" ,pkg-config))) >> -- >> 2.33.0 >> >> >> >>