From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cOwOFwvSKWIkgQEAgWs5BA (envelope-from ) for ; Thu, 10 Mar 2022 11:25:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oOSjEwvSKWIIagEAauVa8A (envelope-from ) for ; Thu, 10 Mar 2022 11:25:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13B3E34C37 for ; Thu, 10 Mar 2022 11:25:15 +0100 (CET) Received: from localhost ([::1]:40878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSFys-0003Uv-1a for larch@yhetil.org; Thu, 10 Mar 2022 05:25:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSFxh-0001wf-V5 for guix-patches@gnu.org; Thu, 10 Mar 2022 05:24:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSFxh-0005Xq-Ly for guix-patches@gnu.org; Thu, 10 Mar 2022 05:24:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSFxh-0003yK-JT for guix-patches@gnu.org; Thu, 10 Mar 2022 05:24:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54180] [PATCH 00/12] Home: Clarify and better test symlink-manager.scm Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Mar 2022 10:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54180@debbugs.gnu.org Received: via spool by 54180-submit@debbugs.gnu.org id=B54180.164690779115187 (code B ref 54180); Thu, 10 Mar 2022 10:24:01 +0000 Received: (at 54180) by debbugs.gnu.org; 10 Mar 2022 10:23:11 +0000 Received: from localhost ([127.0.0.1]:33346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSFws-0003wt-Ue for submit@debbugs.gnu.org; Thu, 10 Mar 2022 05:23:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSFwr-0003wf-BD for 54180@debbugs.gnu.org; Thu, 10 Mar 2022 05:23:09 -0500 Received: from [2001:470:142:3::e] (port=53566 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSFwm-0005Oo-1f; Thu, 10 Mar 2022 05:23:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DWM36XAC0Ku/Xf/QsUgYEdQjP+zg6rAAIXSbzh7/3bA=; b=VOHu2Xa/Alwgk6Lbbf20 Zzg2dEnczzrPrxnHkJSJNp2RwQn7Ln7XtEISRaFSNsBJmw2mCbZvtrZKT4HfPmkelTdlf4tYYFCjd cS0S+DSsQ2rT0WxCcVKtvAPAA6FOckjTWol1/edcTIZL2NFqkx7cxUpvkyqyEwK4U2RHHnkA/N/3f bDXhCTlFN7D69ANR6qHIWrjJkFwj1uY25A/kFN8tCFMIijw7LjRV7qxJSYmVD4C6k8fRjnUjbPp8t STNj0NlZGtr2LI2IdpoDvlC7eyIPeaHP3Iuxz0fEbEAxfIy/bDc2sAV6z15MGgkquKDHP1wYf+oVR Uoy74gbh5Kk8BQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56800 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSFwl-0002JR-GE; Thu, 10 Mar 2022 05:23:03 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220227135342.10296-1-ludo@gnu.org> <20220227135342.10296-9-ludo@gnu.org> <87a6e4m47k.fsf_-_@gnu.org> Date: Thu, 10 Mar 2022 11:23:01 +0100 In-Reply-To: (Maxime Devos's message of "Sat, 05 Mar 2022 23:27:46 +0100") Message-ID: <87fsnqyum2.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646907915; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DWM36XAC0Ku/Xf/QsUgYEdQjP+zg6rAAIXSbzh7/3bA=; b=pZ3A9hkJyg8S3WsN3df40l7/IZ3nfkOPB6bKuXYOVJ9PkQ/1PWSxfxkd5jmKgoik4Kmw5q i/uC5TxeWfcDljoyVjMvN5UG5JMj2vk0cmJ+E2t0eYCELdl/eZ5Thj5hQBPh7UcTEQbkWW o7rtNRNzeDsX0fc5sVDwDdghgEoLIQ/KUf2oN5xw0VjaWGfCMnhVdJO+5vhJ+0h2gJjPye jWidyZswDQep68hSiL6zJdkqszlrM/oTNXCqFs218cmwJ0PF7O12Aw93NpJvV/LphIeYu1 F5YmRm6vebrIvbTmcAal/8t8V8ZpiYHn2SRHHGTfs/OXrTwkoxmEumGeKni6Ig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646907915; a=rsa-sha256; cv=none; b=FByOhmdiu1MB8nMJ/lFc4DPgghLGeQNYpIkHz74D4DhXAHI36jUhj8PIiL2W666zSlhywP emZd/GqDftcwbMT60lZP4CWZChUOLxcqLPtqOhJWWA5+UPGcgOCBv9J8Zzx7xY6eEyWH1q GzpzGd6SAmp3n1H4NSUSFtRn5ojtH3Mq+mWaXxtnYsVCb7G7snx8fT5jXVObVjiUrAZlHu /QBVP5h+SapW6sitoj4KOR1BtIeRJJObfhVYEVb40sctGm+gZmTsIIuHN7MVf+48fk2sQm s7+2ju49+zEan8ptUyfu8jpAB7Ylk26I43c3RLamKrth07CkpS9eUHMqrcx5Tw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="VOHu2Xa/"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="VOHu2Xa/"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 13B3E34C37 X-Spam-Score: -5.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: fQD+u/JHUrel Hi Maxime, Maxime Devos skribis: > Ludovic Court=C3=A8s schreef op za 05-03-2022 om 23:20 [+0100]: >> It=E2=80=99s useful to have integration tests that exercise the commands= ; unit >> tests would also be welcome, but that=E2=80=99s what we have so far. > > Integreation tests don't have to be in bash. We can have integration > tests in Scheme, by=C2=A0running the 'guix-FOO' procedures from (guix > scripts ...), like tests/substitute.scm and tests/publish.scm do. Yes, you=E2=80=99re right, but this patch series is not about rewriting the integration tests. :-) The way I see it, we can choose and combine different strategies: Bash tests (the good thing is that they=E2=80=99re as close as can be to what us= ers run), Scheme integration tests like you write when more fine-grain control is needed, and of course unit tests. Ludo=E2=80=99.