[bug#55864] Added the emacs-org-auto-tangle package

[bug#55864] Added the emacs-org-auto-tangle package

[Haider Mirza]

[-- Attachment #1.1: Type: text/plain, Size: 218 bytes --]

Good Morning/Afternoon,
Here is a patch to add the Emacs Orgmode package specialized for lazy
people (org-auto-tangle).
Please let me know if there's any way this package definition can be improved!

Regards,
Haider.


[-- Attachment #1.2: 0001-Added-the-emacs-org-auto-tangle-package.patch --]
[-- Type: text/x-patch, Size: 1900 bytes --]

From c78b82bce0c2e77369db9432826c34d5d228734d Mon Sep 17 00:00:00 2001
From: Haider Mirza <x7and7@gmail.com>
Date: Wed, 8 Jun 2022 22:14:56 +0100
Subject: [PATCH] Added the emacs-org-auto-tangle package

---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2633b775a6..cf4f9171a0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -113,6 +113,7 @@
 ;;; Copyright © 2022 Peter Polidoro <peter@polidoro.io>
 ;;; Copyright © 2022 Luis Felipe López Acevedo <luis.felipe.la@protonmail.com>
 ;;; Copyright © 2022 Thomas Albers Raviola <thomas@thomaslabs.org>
+;;; Copyright © 2022 Haider Mirza <haider@haider.gq>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5486,6 +5487,27 @@ (define-public emacs-org-inline-pdf
 inline PDF preview in Org buffers by using pdf2svg.")
     (license license:gpl3+)))
 
+(define-public emacs-org-auto-tangle
+  (package
+   (name "emacs-org-auto-tangle")
+   (version "0.4.1")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/yilkalargaw/org-auto-tangle.git")
+		  (commit version)))
+            (sha256
+             (base32
+              "1zb7vcmhmjiqpbbhqrqci689rnpn10p985cs5jk9sgg66xsbrgs3"))))
+   (build-system emacs-build-system)
+    (propagated-inputs
+     (list emacs-async))
+   (home-page "https://github.com/yilkalargaw/org-auto-tangle")
+   (synopsis "Automatically tangle code blocks on save")
+   (description
+    "This package (i.e org-auto-tangle) is a very simple emacs package that allows you to automatically tangle org files on save.")
+      (license license:bsd-2)))
+
 (define-public emacs-org-rich-yank
   (package
     (name "emacs-org-rich-yank")
-- 
2.36.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

[bug#55864] Added the emacs-org-auto-tangle package

[Liliana Marie Prikler]

Hello, Haider

Am Mittwoch, dem 08.06.2022 um 22:34 +0100 schrieb Haider Mirza:

> [PATCH] Added the emacs-org-auto-tangle package
> 
> ---
You're missing a ChangeLog here.  Note that with magit+yasnippet you
can generate such commit messages "automatically" after loading the
snippet definitions from /path/to/guix/etc/snippets.  Simply type
"add", then TAB.

> +   (build-system emacs-build-system)
> +    (propagated-inputs
> +     (list emacs-async))
This indentation appears off, also you can squash propagated-inputs
into a single line.

> +   (description
> +    "This package (i.e org-auto-tangle) is a very simple emacs
> package that allows you to automatically tangle org files on save.")
"This package" is enough of a qualifier.  Alternatively, write
@code{org-auto-tangle}. "is a very simple emacs package that" is very
useless filler.  Write "This package allows you..." or similar.  Note
the value of fill-column as per .dir-locals.el

Cheers

[bug#55864] Added the emacs-org-auto-tangle package

[Haider Mirza]

[-- Attachment #1.1: Type: text/plain, Size: 962 bytes --]

Hello Liliana!
I think that I have fixed all of your recommendations with the package definition.

I love the yasnippet function, would you (Guix in general) mind if I use
their yasnippet config as reference (It is in the Guix repository after all)

Also, if you don't mind answering a question of mine, in Magit the saved
Patch doesn't this section:

> From 7d98fb3263173f1b7f0368b2afcd4ae64ce37568 Mon Sep 17 00:00:00 2001
> From: Haider Mirza <x7and7@gmail.com>
> Date: Wed, 8 Jun 2022 22:14:56 +0100
> Subject: [PATCH] gnu: Add emacs-org-auto-tangle.

> *  (emacs-org-auto-tangle): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
Is this a problem on my side or am I running the wrong command (in the
commit buffer running W+s)

And Like I said before, let me know if there's any way this package definition can
be further improved! (First time making a patch)

Thanks for your help,
Haider.

[-- Attachment #1.2: 0001-gnu-Add-emacs-org-auto-tangle.patch --]
[-- Type: text/x-patch, Size: 1935 bytes --]

From 7d98fb3263173f1b7f0368b2afcd4ae64ce37568 Mon Sep 17 00:00:00 2001
From: Haider Mirza <x7and7@gmail.com>
Date: Wed, 8 Jun 2022 22:14:56 +0100
Subject: [PATCH] gnu: Add emacs-org-auto-tangle.

*  (emacs-org-auto-tangle): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2633b775a6..cf4f9171a0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -113,6 +113,7 @@
 ;;; Copyright © 2022 Peter Polidoro <peter@polidoro.io>
 ;;; Copyright © 2022 Luis Felipe López Acevedo <luis.felipe.la@protonmail.com>
 ;;; Copyright © 2022 Thomas Albers Raviola <thomas@thomaslabs.org>
+;;; Copyright © 2022 Haider Mirza <haider@haider.gq>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5486,6 +5487,27 @@ (define-public emacs-org-inline-pdf
 inline PDF preview in Org buffers by using pdf2svg.")
     (license license:gpl3+)))
 
+(define-public emacs-org-auto-tangle
+  (package
+   (name "emacs-org-auto-tangle")
+   (version "0.4.1")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/yilkalargaw/org-auto-tangle.git")
+		  (commit version)))
+            (sha256
+             (base32
+              "1zb7vcmhmjiqpbbhqrqci689rnpn10p985cs5jk9sgg66xsbrgs3"))))
+   (build-system emacs-build-system)
+    (propagated-inputs
+     (list emacs-async))
+   (home-page "https://github.com/yilkalargaw/org-auto-tangle")
+   (synopsis "Automatically tangle code blocks on save")
+   (description
+    "This package (i.e org-auto-tangle) is a very simple emacs package that allows you to automatically tangle org files on save.")
+      (license license:bsd-2)))
+
 (define-public emacs-org-rich-yank
   (package
     (name "emacs-org-rich-yank")
-- 
2.36.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

[bug#55864] Added the emacs-org-auto-tangle package

[Haider Mirza]

[-- Attachment #1.1: Type: text/plain, Size: 55 bytes --]

Sorry, I included the wrong patch :/

Regards,
Haider.

[-- Attachment #1.2: 0001-gnu-Add-emacs-org-auto-tangle.patch --]
[-- Type: text/x-patch, Size: 1966 bytes --]

From 04f1320d53b23f972a1be82e8d8b47128ea27d22 Mon Sep 17 00:00:00 2001
From: Haider Mirza <x7and7@gmail.com>
Date: Fri, 10 Jun 2022 20:08:19 +0100
Subject: [PATCH] gnu: Add emacs-org-auto-tangle.

* gnu/packages/emacs-xyz.scm (emacs-org-auto-tangle): New variable.
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6077e52c4a..6ccfc14814 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -113,6 +113,7 @@
 ;;; Copyright © 2022 Peter Polidoro <peter@polidoro.io>
 ;;; Copyright © 2022 Luis Felipe López Acevedo <luis.felipe.la@protonmail.com>
 ;;; Copyright © 2022 Thomas Albers Raviola <thomas@thomaslabs.org>
+;;; Copyright © 2022 Haider Mirza <haider@haider.gq>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -18639,6 +18640,26 @@ (define-public emacs-bing-dict
 Chinese to English.")
     (license license:gpl3+)))
 
+(define-public emacs-org-auto-tangle
+  (package
+   (name "emacs-org-auto-tangle")
+   (version "0.4.1")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/yilkalargaw/org-auto-tangle.git")
+		  (commit version)))
+            (sha256
+             (base32
+              "1zb7vcmhmjiqpbbhqrqci689rnpn10p985cs5jk9sgg66xsbrgs3"))))
+   (build-system emacs-build-system)
+    (propagated-inputs (list emacs-async))
+   (home-page "https://github.com/yilkalargaw/org-auto-tangle")
+   (synopsis "Automatically tangle code blocks on save")
+   (description
+    "org-auto-tangle is a Emacs Orgmode package that allows you to automatically run org-babel-tangle when saving an orgmode document.")
+      (license license:bsd-2)))
+
 (define-public emacs-org-auto-expand
   (let ((commit "4938d5f6460e2f8f051ba9ac000b291bfa43ef62")
         (revision "1"))
-- 
2.36.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

[bug#55864] Added the emacs-org-auto-tangle package

[Haider Mirza]

[-- Attachment #1.1: Type: text/plain, Size: 55 bytes --]

Sorry, I included the wrong patch :/

Regards,
Haider.

[-- Attachment #1.2: 0001-gnu-Add-emacs-org-auto-tangle.patch --]
[-- Type: text/x-patch, Size: 1966 bytes --]

From 04f1320d53b23f972a1be82e8d8b47128ea27d22 Mon Sep 17 00:00:00 2001
From: Haider Mirza <x7and7@gmail.com>
Date: Fri, 10 Jun 2022 20:08:19 +0100
Subject: [PATCH] gnu: Add emacs-org-auto-tangle.

* gnu/packages/emacs-xyz.scm (emacs-org-auto-tangle): New variable.
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6077e52c4a..6ccfc14814 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -113,6 +113,7 @@
 ;;; Copyright © 2022 Peter Polidoro <peter@polidoro.io>
 ;;; Copyright © 2022 Luis Felipe López Acevedo <luis.felipe.la@protonmail.com>
 ;;; Copyright © 2022 Thomas Albers Raviola <thomas@thomaslabs.org>
+;;; Copyright © 2022 Haider Mirza <haider@haider.gq>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -18639,6 +18640,26 @@ (define-public emacs-bing-dict
 Chinese to English.")
     (license license:gpl3+)))
 
+(define-public emacs-org-auto-tangle
+  (package
+   (name "emacs-org-auto-tangle")
+   (version "0.4.1")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/yilkalargaw/org-auto-tangle.git")
+		  (commit version)))
+            (sha256
+             (base32
+              "1zb7vcmhmjiqpbbhqrqci689rnpn10p985cs5jk9sgg66xsbrgs3"))))
+   (build-system emacs-build-system)
+    (propagated-inputs (list emacs-async))
+   (home-page "https://github.com/yilkalargaw/org-auto-tangle")
+   (synopsis "Automatically tangle code blocks on save")
+   (description
+    "org-auto-tangle is a Emacs Orgmode package that allows you to automatically run org-babel-tangle when saving an orgmode document.")
+      (license license:bsd-2)))
+
 (define-public emacs-org-auto-expand
   (let ((commit "4938d5f6460e2f8f051ba9ac000b291bfa43ef62")
         (revision "1"))
-- 
2.36.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

bug#55864: Added the emacs-org-auto-tangle package

[Liliana Marie Prikler]

Am Freitag, dem 10.06.2022 um 20:15 +0100 schrieb Haider Mirza:
> Sorry, I included the wrong patch :/
I cleaned up your patch and pushed it.

> Is this a problem on my side or am I running the wrong command (in
> the commit buffer running W+s)
There was probably something wrong with your workflow given that you
had to fix things up.  If you start from a blank slate, you shouldn't
experience this, but magit doesn't always have the right diffs as far
as I know.

Cheers