From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sGnUOfTw7GJ0ewEAbAwnHQ (envelope-from ) for ; Fri, 05 Aug 2022 12:29:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kFOhOfTw7GKZBgAA9RJhRA (envelope-from ) for ; Fri, 05 Aug 2022 12:29:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7CE4BD50 for ; Fri, 5 Aug 2022 12:29:08 +0200 (CEST) Received: from localhost ([::1]:51702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJuZo-0003sG-02 for larch@yhetil.org; Fri, 05 Aug 2022 06:29:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJtqE-0001jE-F2 for guix-patches@gnu.org; Fri, 05 Aug 2022 05:42:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38281) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJtqE-0001wO-49 for guix-patches@gnu.org; Fri, 05 Aug 2022 05:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJtqD-0007y2-UT for guix-patches@gnu.org; Fri, 05 Aug 2022 05:42:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56880] [PATCH] gnu: system: file-systems: Add shared flag. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Aug 2022 09:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 56880@debbugs.gnu.org Received: via spool by 56880-submit@debbugs.gnu.org id=B56880.165969251230611 (code B ref 56880); Fri, 05 Aug 2022 09:42:01 +0000 Received: (at 56880) by debbugs.gnu.org; 5 Aug 2022 09:41:52 +0000 Received: from localhost ([127.0.0.1]:56263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJtq4-0007xe-0S for submit@debbugs.gnu.org; Fri, 05 Aug 2022 05:41:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJtpz-0007xP-VA for 56880@debbugs.gnu.org; Fri, 05 Aug 2022 05:41:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJtpu-0001uT-HU; Fri, 05 Aug 2022 05:41:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=zDT4yOmQThr+47J3hXkxOikYNio/GPK7SwlEMxDKqg0=; b=ffwjI6LpU2L37Im/1/d1 QaQSjaFC1I9rQImleRCc/rElRXHytrRw8mOYrIYKLpw7Gi8dRb2R4iqIcasPlFKzplxeXB1MnVTed K44DrbE9KJo0lIzOsMUkquI9PT9hX+oqAuGTTygJgS14EyKmgNaclSaJpUfcyzPn3Lg07ps0qXajk gOxI86Ea1y68g1O11e4GulCZS178baHGJX3D4dwuptzdsXLiQqO/c5p7LbjHcNXqIVzbwNQ/sfR7U 64go7gE1eMfQ52/iLomyOTVxp8iO8jxfCzxEIYEoBlPZ4YE+LEN+pHXX7Hwl1fYS1MPCMi7IxCwrW qpyHiyX0Iu34kw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=46632 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJtpu-0006mH-6F; Fri, 05 Aug 2022 05:41:42 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220802112309.28423-1-go.wigust@gmail.com> <87fsids689.fsf@gnu.org> <87czdgqh67.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 18 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de l'Amande X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 05 Aug 2022 11:41:38 +0200 In-Reply-To: <87czdgqh67.fsf@gmail.com> (Oleg Pykhalov's message of "Thu, 04 Aug 2022 16:20:16 +0300") Message-ID: <87fsibhvsd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659695348; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zDT4yOmQThr+47J3hXkxOikYNio/GPK7SwlEMxDKqg0=; b=bVqxqZQQX6azrNEmiY/W1KVZs1U/BA370sOiOuw7xRwr5F3XSRFBDUzbICyGcLelQHxUOa H4iZRTIwhbS8twDA+oO8BnTnppFYrcMJx72UdpnaSk8Ppwxy443cdakrPqkYFVdum7hLtG KsmMqkLLe2LZlH8VGpPfWlXSflo5HAq1ftCKghLhZUEDP3G9QOUPzII1VYZ72mLeqRqLHq nFjWyxnkfv43PulF8NI8/I0QC5wYAvdMrQopkzTihV+9riDG8XtmqyIJp+tiStL71IlNcO JZUeSb1u2jwiIEexpVFL26GwqTVobjLYq2QRM7XN1cO7iGcukan2i0I+oSP6eQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659695348; a=rsa-sha256; cv=none; b=aYD5kfj772a0ToSNfjIxvabZEFUIWTJFEQ2gBtjzlp4X251g2YJwG3Cjs9Ke/g+HT/I38E bUAKJFTNJpyra6cWpDCrsMHFgqb1IqMeRuPzqC0E1MiDMbsr+pbpBhBk6KhKZbx6M81+4a HGgWnDpDgH+/P0s9byMEZsxB+4qPFPZVnF4OK9A+HFodviPE7NDT/RVh8fvAX+07VL3od3 gPLcEFpg83uhHwrsakY3FIm3z9fHfS/fN49NeEfO9p8H5DHxaiaRQgXGg7ZPOdIHVhOq7y YrmK5BAFDIoYwSjkDyoGQ7xlW2PJjArnwz/iVciV1MW4cdWtyoN6I7fjhk3zUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ffwjI6Lp; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ffwjI6Lp; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C7CE4BD50 X-Spam-Score: -4.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: IBHqe4XDvngh Hi, Oleg Pykhalov skribis: > Ludovic Court=C3=A8s writes: > > [=E2=80=A6] > >>> (option-string->mount-flags): Handle shared flag. > > I looked again on this procedure before merge. With applied patch it > will return a wrong bitmask according to the manual page: > > mount(2) > > The only other flags that can be specified while changing the propag= a=E2=80=90 > tion type are MS_REC (described below) and MS_SILENT (which is i= g=E2=80=90 > nored). > > Also I tried to invoke 'mount' from C code, if MS_SHARED specified and > mountpoint does not exist (not mounted without MS_SHARED before), then > nothing will happen. Hmm not sure I follow. > The procedure is out of the scope adding a shared flag support to > file-system record. I see two variants: > > 1. Remove the modification from option-string->mount-flags and merge, > someone will add when required. > > 2. Modify option-string->mount-flags in such way, that it will return > multiple bitmasks or in some other way. I understand option #1 and it sounds reasonable to me. I=E2=80=99m not sure what option #2 means concretely? Thanks, Ludo=E2=80=99.