all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 56880@debbugs.gnu.org
Subject: [bug#56880] [PATCH] gnu: system: file-systems: Add shared flag.
Date: Fri, 05 Aug 2022 11:41:38 +0200	[thread overview]
Message-ID: <87fsibhvsd.fsf@gnu.org> (raw)
In-Reply-To: <87czdgqh67.fsf@gmail.com> (Oleg Pykhalov's message of "Thu, 04 Aug 2022 16:20:16 +0300")

Hi,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
> […]
>
>>> (option-string->mount-flags): Handle shared flag.
>
> I looked again on this procedure before merge.  With applied patch it
> will return a wrong bitmask according to the manual page:
>
> mount(2)
>
>     The  only other flags that can be specified while changing the propaga‐
>     tion type are MS_REC (described below)  and  MS_SILENT  (which  is  ig‐
>     nored).
>
> Also I tried to invoke 'mount' from C code, if MS_SHARED specified and
> mountpoint does not exist (not mounted without MS_SHARED before), then
> nothing will happen.

Hmm not sure I follow.

> The procedure is out of the scope adding a shared flag support to
> file-system record.  I see two variants:
>
> 1. Remove the modification from option-string->mount-flags and merge,
> someone will add when required.
>
> 2. Modify option-string->mount-flags in such way, that it will return
> multiple bitmasks or in some other way.

I understand option #1 and it sounds reasonable to me.

I’m not sure what option #2 means concretely?

Thanks,
Ludo’.




  reply	other threads:[~2022-08-05 10:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 11:23 [bug#56880] [PATCH] gnu: system: file-systems: Add shared flag Oleg Pykhalov
2022-08-03 15:21 ` Ludovic Courtès
2022-08-04 13:20   ` Oleg Pykhalov
2022-08-05  9:41     ` Ludovic Courtès [this message]
2022-08-10  4:19       ` bug#56880: " Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsibhvsd.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=56880@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.