From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UD/kMbzN7WL6WwEAbAwnHQ (envelope-from ) for ; Sat, 06 Aug 2022 04:11:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eMz8MbzN7WIgvQAA9RJhRA (envelope-from ) for ; Sat, 06 Aug 2022 04:11:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7893D3E42C for ; Sat, 6 Aug 2022 04:11:08 +0200 (CEST) Received: from localhost ([::1]:42502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oK9HP-0005T1-NE for larch@yhetil.org; Fri, 05 Aug 2022 22:11:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK9HK-0005Sq-38 for guix-patches@gnu.org; Fri, 05 Aug 2022 22:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oK9HJ-0003V9-QB for guix-patches@gnu.org; Fri, 05 Aug 2022 22:11:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oK9HJ-0005aa-LL for guix-patches@gnu.org; Fri, 05 Aug 2022 22:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package. Resent-From: Christopher Rodriguez Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Aug 2022 02:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56989 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Christopher Rodriguez , 56989@debbugs.gnu.org Received: via spool by 56989-submit@debbugs.gnu.org id=B56989.165975184921466 (code B ref 56989); Sat, 06 Aug 2022 02:11:01 +0000 Received: (at 56989) by debbugs.gnu.org; 6 Aug 2022 02:10:49 +0000 Received: from localhost ([127.0.0.1]:60828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK9H7-0005aA-5f for submit@debbugs.gnu.org; Fri, 05 Aug 2022 22:10:49 -0400 Received: from mail-qv1-f44.google.com ([209.85.219.44]:41961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK9H2-0005Zt-EX for 56989@debbugs.gnu.org; Fri, 05 Aug 2022 22:10:47 -0400 Received: by mail-qv1-f44.google.com with SMTP id i7so2926630qvr.8 for <56989@debbugs.gnu.org>; Fri, 05 Aug 2022 19:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc; bh=rwERjQKbiPWgPMgqM8zLbTa2nEDnh1f56UDo34e0Afs=; b=agz+gVNF8y/yi1z9Y6rfAPS45ldFvAzjQeapRepT1e1BrSgMBAAR0WAtOUgrvA6UKz ZCEi71P4iRmT4S1vaVkMp5U8NTGYkj86jdiHhhdYXBPQ0SU1b0b4oX6zHydujNBp8WqA z5PJ7pGlIUV1pSYkm3/ri+sGHaduF87PltaCO5aJo4QpjWZAFL2r4dhUW/Zz5jSd0NeM QMs5GZwQzRV82z/vN/drt2O4pyUCdzJ78qo+2EkUQl8Fa6Ec7H/2W4NjQFNknRJkh73H Tv6E8v9hdV0k9qF4UWd9j1uplmN/k9ZksETKjm++lSW4ChbRwWTHGPUxMCnj58hoJ09u cTaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc; bh=rwERjQKbiPWgPMgqM8zLbTa2nEDnh1f56UDo34e0Afs=; b=FIfcRju08XKz7HgczFWb4EmjZJ9pvt/wG+QeZ/gEq/RzLJO1Z+dYjHSkK0bW9f11xI AT7iOVpc/edI8Ur74gcQevJaYjxyPQ6dU8ghXdfOV/sGxCSQkPJIp6W2bvBFMz1Gv/ZF 62RLq7JI3wrDnfPeoqvhKlbwEg4Yyd6kBlkmnHRYHrrMKS4yL8WFZBSxLgLUC1Qrw6HU wk7i7kr8mm3eOD6mc1gWOkAdJm0k+kUczGVrpP/M0BYu7r5o/rSdY4vXaxcSj9FA5g4A RsWvn/SJP3+tFP7A7TvVQt3zlAxeN3nHzrztYZq0Jj4+M6429GplZa/Tp5iz+kJgaFUw lJzQ== X-Gm-Message-State: ACgBeo0PGO4D7KVLc9FNjL3fz3o8AzT5IWEgpYq2l8I/xZ28BEebvObi mMcAnNaXEZsqWM+0YOwXNzo= X-Google-Smtp-Source: AA6agR4f0NYoI+Lz6jsXH4eWAHEGPfsTPHR0yYjqm00cKAy7i1xx1EKG+nohSOdkqdTkeGCj0IzeLg== X-Received: by 2002:a05:6214:2aa6:b0:474:844b:24ff with SMTP id js6-20020a0562142aa600b00474844b24ffmr8270144qvb.51.1659751838860; Fri, 05 Aug 2022 19:10:38 -0700 (PDT) Received: from gmail.com ([2601:547:a00:7720::7bb0]) by smtp.gmail.com with ESMTPSA id h5-20020a05620a284500b006b8d977d87dsm4013919qkp.55.2022.08.05.19.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 19:10:38 -0700 (PDT) References: <20220805054616.30620-1-yewscion@gmail.com> <7742c07ce28494af40c74262277417e60fe6f500.camel@ist.tugraz.at> <87zggin1u0.fsf@gmail.com> <5bffe66896dbebfe4716b924eb3d7a13e8e6344b.camel@gmail.com> User-agent: mu4e 1.8.7; emacs 28.1 From: Christopher Rodriguez Date: Fri, 05 Aug 2022 21:47:32 -0400 In-reply-to: <5bffe66896dbebfe4716b924eb3d7a13e8e6344b.camel@gmail.com> Message-ID: <87fsiam8aa.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659751868; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rwERjQKbiPWgPMgqM8zLbTa2nEDnh1f56UDo34e0Afs=; b=Gui3uUfOgBaYSc588WMvh3h40N3ocCijWtrkEuaM+NIa3tjmDsnTI8a9+SCw4IrUH2e6TW THyfSLZwJKI7dbmjuN3TPim1lsaG0OJ0rF1/4yqOoFveHU/QAu5LYErp2doAIg5XCTZMXm 1+VyEPXULBvjx3Z0UqquEVg03Md1HX45WHs9QfTJQlBz/w928G89DrcnchDBa1iBU7gPjG bI8OXxjsFqfjEUYrqyxq9SzMRTxp1Wbf80z0Hwl9lKeHxZS8SWeKEMImKS3KS7ioDw0u2p rkKc5Hnp0nlOVsEFnMnRfP7LQ7jU2xAyYnkyvXLPBcXd7DV5O4twAa+7/yT+aw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659751868; a=rsa-sha256; cv=none; b=ci6S/3lJIR2mOThhDdD8Jy9VyRRrA8YY3ppYt57ZG6U8G+Ydi8JK7tE7lv+Yr3JdMKxu0e EXF2US5DdhE2DxoWe8od7GLbA4YRh/jjkWIr9OQKJTBWUuEJeXyuCF9iv4gPzkuanYrx1z E9BlqnvBeJgNS9fojxT9gdwF0CE/UYWCdkKG4W2PfWZbHQCj2dH7jvJzzIJs7xutNcnS4z B6fqI/n4WlhC5eFubWI1mfbORMqC0ywWAg6tEzJE3YXdZmsGRy2O3rMq0QdQaxaSbPhZW2 sMsYa/A+Dg9fR8FLdwxwUUyBJ5vrNYhQRiU/CLcBwNzQu8GtxR199FRE9dIoSg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=agz+gVNF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=agz+gVNF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7893D3E42C X-Spam-Score: 3.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: eWwSmdQh30G3 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler writes: > You should let-bind revision and commit. You should nt let-bind tag, > version and hash. Use git-version like (git-version "0.2.1" revision > commit). Copy that, I've implemented this change in the upcoming patch. > That isn't really a good argument not to have tests though. While > package maintainers should check that dependant packages still build, > having early failure for a broken package (courtesy of the check phase) > goes a long way. > I agree with this. I did check each test, and there were three failing in the cloned repo on my local machine=E2=80=A6 Until I ran them inside the package build environment, where they all passed 100%. I have run this with --check =2D-rounds=3D20 and have not seen a failure inside of the build environment, so I will leave them enabled. > Ah, yes, the infamous flip :) > (cons* #:options your-options rest) ? I've left these as (#:outputs (list outputs)), as that is less characters than the above and I'm just passing in a single variable (inside a list, as that is what the procedure is expecting) without any (other) modifications. > If there is no *variable* named "openjdk", I'd suggest using the lowest > one that works. If people are so inclined to use a newer jdk they can > modify the package graph (which is easier than walking back to the > earliest supported version), plus it's lower bootstrap for those of us > building from source. I've successfully built it using icedtea-8 (icedtea-7 failed), so I've switched the patch over to that. =2D- Christopher Rodriguez --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJMQbvYVxvZ0eF/84XZ6FgaGVz3sFAmLtzY0ACgkQXZ6FgaGV z3tB5w/+Oua4kkLS5hHAuuykT6vVlpWgya/wWnc4TCwHVzRJMIH71i90LgvI4SzJ 7mex9dkpitbR0YCEzX25eibEfPdnFlkk+kVCmBu6loAcFVuNQ+kwxJZiwR03SWut WIuvV0cK/tbw3RGQf+rj8meOUlVKrl5a122pcm2lSkcD7rSJ+Ga1yID5rh33bvM+ eypfl7C8v2GJw0+gyaYKBUc/pPxBT7VHGV6mZOazYRq+R+sW01OnA4TWO2XH9I4i 0tVijXHkaQN8Lh/9Jr/P+4utxN0jWOWm3tqMrLKYOuQx9qpSSYbs3AeStSddjbl+ Hi5pCpco96YoCOcUWxC2wgNySzYX8EQkN0Zu5k/MSBMxJZQfBuEr79nmpgjZo1i3 miXob3Sl6VU27+Blf22f6ZqDHRLgLEmtIW3Nkwv7D9TvQKS9Olz/ropYQ4DqNj8n VNN8ANjTUXfpd+SKVnV3GipnZH+0VWKncfPVKCigCcwVhPbNi32kZDFKW9Esf6yD gosoFjQDWUuPHg03blfkF0qTVK8ZxAaNQMOmPRCXTDLXFjUIwzABF0WrjlN/8LzA guk4T8DAIoXkVEkLVQn9bBNZToN+spWvVlXZFtroZbNRGl+nJ7SkgVaQ/pFuMozs W3OHMAdRk2YROnBcBgrPfc/IpCf+Ob0Vvi4g2k3tLb9/gRptmbM= =dtfS -----END PGP SIGNATURE----- --=-=-=--