From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8C4OHozLLmMHdQEAbAwnHQ (envelope-from ) for ; Sat, 24 Sep 2022 11:19:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gDM5HYzLLmNdHQEAG6o9tA (envelope-from ) for ; Sat, 24 Sep 2022 11:19:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E50EBFC39 for ; Sat, 24 Sep 2022 11:19:07 +0200 (CEST) Received: from localhost ([::1]:44834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oc1JT-0004JX-1A for larch@yhetil.org; Sat, 24 Sep 2022 05:19:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc1JO-0004JL-HK for guix-patches@gnu.org; Sat, 24 Sep 2022 05:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oc1JO-0006kg-9j for guix-patches@gnu.org; Sat, 24 Sep 2022 05:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oc1JN-0001Cw-TE for guix-patches@gnu.org; Sat, 24 Sep 2022 05:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57460] [PATCH 00/19] Refresh to specific version Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Sep 2022 09:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57460 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 57460@debbugs.gnu.org Received: via spool by 57460-submit@debbugs.gnu.org id=B57460.16640110974586 (code B ref 57460); Sat, 24 Sep 2022 09:19:01 +0000 Received: (at 57460) by debbugs.gnu.org; 24 Sep 2022 09:18:17 +0000 Received: from localhost ([127.0.0.1]:42286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc1If-0001Bs-7y for submit@debbugs.gnu.org; Sat, 24 Sep 2022 05:18:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc1Ic-0001Bg-Rn for 57460@debbugs.gnu.org; Sat, 24 Sep 2022 05:18:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc1IW-0006hP-7f; Sat, 24 Sep 2022 05:18:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=IIA2wQ0VWYBIetM3Z2keaz+98pZfFRDPKxbIK5zqNuc=; b=VpLx9j/fxTmU1wNmHEwy ofMmSL80mKQmwmXqddAmbxgWtPmW77RtdA0sPBSztlBGRJVDm0G2ajqItJE3nHVFlNbvL60YpvL/3 ox6C7+lQTjyrjESCHVl1q6mhw3WIW1cLLIcHBVttnSL1w+HWx8FfwwDSpcLrWJ/Id4cNVcr/dRKSb BN8P/A+0ufL0lMLBE3xpbFkZ4cYPoDvGNmBbWFykNoK9JSoHoT3vVta3vYt8F/WaYeOVMPpX90cd7 wzl0sWUOGsmO7vLZxz7ZyyKhU1Uhy7RfsMaiPxqIBvpgFW9va+RDJ20I0I1CjjkeamaV9iu/FnSMP Qmu58MSX6LHFrw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:60593 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc1IJ-0002dM-7u; Sat, 24 Sep 2022 05:18:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <51528a9d139e8178faa1365f49d29e55ed320ada.1661691694.git.h.goebel@crazy-compilers.com> Date: Sat, 24 Sep 2022 11:17:52 +0200 In-Reply-To: <51528a9d139e8178faa1365f49d29e55ed320ada.1661691694.git.h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Sun, 28 Aug 2022 15:18:31 +0200") Message-ID: <87fsghdtbz.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664011148; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IIA2wQ0VWYBIetM3Z2keaz+98pZfFRDPKxbIK5zqNuc=; b=Bdli1DEIplkuuiHIV4B+GqyJLfQFuTxplFan+xhwzDp+zS5IPfBMIy6N+iZH92yNzh9UUD 98FJkYT49CHeLbxVlMyDD/BTMjyEeXpwdjcpUlQQ9gO9hwbquqWsqNypGK3s3ynpT5EOv+ d7qTezmSkmoG1zlDAso/egZ6+Bym9s+FqwNntv2iiAnWhL5Sk44N/T8IJ1sJeJ89L/+3s1 5NYXs9RahU6151B19GrAPhL1DdHkKk0J6H8MG5J0aLce4+kXSee0CuE4KcYxRpax3wCy+z dksjUX/wKfPFt5oirTs3SPWBrnj8WCwSL1jnnELmx5xAWE9Q2++1t48wzVXl/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664011148; a=rsa-sha256; cv=none; b=B31rdgiP0CqUHmPCoBZYW3rTUr3M7ZlIRzQ3Z6XbugocutI+M6lgkMHEHKxqVjSPkEB39Y zbxvQ0+uj7D7ks5fPiCTBAu7PV5Mm6UpaozMXb019UGcwjUJQ75VykESfe7JoMMRKz6Moe 2gNKw/B+titI7rzyO1Ws5ggpK1PaHPnYNXcyvvTEOxEvBpJF7Xu9JB0MzdFCkWloTbwLuR 8Jqi6Yrb2OHw3INwUfPJulK+1JU8rD8ItjYulwolLEMC2pLkq3I+L31bPG7b7fxIpXQ+Ng xMhcPhFc76+5MK8aYyvSnqnOGjcdbUNuUVC2jZvy6nnzwkF9HREmS/gHg/fDrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="VpLx9j/f"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="VpLx9j/f"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E50EBFC39 X-Spam-Score: -3.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: UPS+zYCOjozq Hi, Hartmut Goebel skribis: > * guix/gnu-maintenance.scm > (latest-ftp-release): Rename to (import-ftp-release), > add keyword-argument 'version'. Nipick: should be =E2=80=9CRename to 'import-ftp-release' and add #:version argument.=E2=80=9D (Likewise below.) > * guix/import/gnu.scm(gnu->guix-package): Adjust function call. ^ Missing space. > + (let* ((release (if version > + (car (filter (lambda (r) (string=3D? version = (upstream-source-version r))) > + (coalesce-sources releases))) As you probably know, =E2=80=98car=E2=80=99 is frowned upon (info "(guix) D= ata Types and Pattern Matching"). Instead, you probably want to write: (find (lambda (upstream) (string=3D? (upstream-source-version upstream) version)) (coalesce-sources releases)) Otherwise LGTM. Ludo=E2=80=99.