From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WDYUMBgwemMlPgEAbAwnHQ (envelope-from ) for ; Sun, 20 Nov 2022 14:48:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8D3eLxgwemM8UwEAauVa8A (envelope-from ) for ; Sun, 20 Nov 2022 14:48:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 603963DE27 for ; Sun, 20 Nov 2022 14:48:08 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owkfq-0005hV-UL; Sun, 20 Nov 2022 08:47:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owkfo-0005gf-1u for guix-devel@gnu.org; Sun, 20 Nov 2022 08:47:52 -0500 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owkfm-0001GP-DG for guix-devel@gnu.org; Sun, 20 Nov 2022 08:47:51 -0500 Received: by mail-qv1-xf35.google.com with SMTP id cz18so153699qvb.13 for ; Sun, 20 Nov 2022 05:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=16YNv9MbJzajrDEoPXTgAO9QlQGS3hIob8Dli70rHk4=; b=oNadqw7sn1D9z2nhsD6DTeFR6eLSuQBAsKmRnt+ivbmVIvY1P5aRz5lGpxdE7jUpjM 653Jw0tlPhLA3fTr2b8ye3rwUsNzvrvPoQgwRotaGdNYDT2zg7jyvNLsmHAc+xGywhms NA3BNVXaODQfpvJujnWoVwX+dOVrQYtGipcdAAA3T3Owfg5GyVtVw+8pSx9UOJQLR/Yy 0y+bjTbAbCcJ4zjq47CDmmxUnJ8ZEbm4IZn5LyxSE7oOjqnmB+wYIPNtI9Z6zW0QFlui qiHtiZ+UCebyjFJ6KsztjBWexGZ6yC+4T1yoYyp6rqnFZw9xK4E8cMnJIX00a1kMJro3 wtQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=16YNv9MbJzajrDEoPXTgAO9QlQGS3hIob8Dli70rHk4=; b=jggUxMrmCI5X+PpgrTSmM874MhgZmppcDmPzJY9Px1dVlIgd0pMA+evPyZgiL1Q/lr imQfDwNUpsIQ8wf0mVibDjxONqcoVEVSmy/0SUx/JPA7BbXNrf+MpngQ4WYoXCv6wvzT JrNWg2UHVUvEBOOtYteCYlB/HePXTSpQkXaFptEZWaHAuPUQQCNhw6X+QjIBle8p+AGd Tx5X4E7ZaOQUy0tVSyihqyeVdnlSDyZhVm5ze0scuCubs3uqzNUVo7DPylnwYUUZ2uMN tTNVlTQNANxNIgg3DulA2PuCcDrtIDLa31IZBV4UrT4pKlZ7SWAwszoWdIRmgenPjsQo LPZg== X-Gm-Message-State: ANoB5pl56jg2k4uNTbB0fk3VgPEQixH02TR1mq9j+PjfuIH6LV4ymb1+ XmW+Mwxj8MB13p5ou7ltwmit97gxy7U= X-Google-Smtp-Source: AA0mqf7Cg0r8rzolLsp4waUI0VQXkK4/Yi3PxaSEQefchVH8l+UKaUJEXiMnHoeh5YnP0WzSwZPEsw== X-Received: by 2002:a05:6214:1027:b0:4c6:9127:b918 with SMTP id k7-20020a056214102700b004c69127b918mr189428qvr.105.1668952069072; Sun, 20 Nov 2022 05:47:49 -0800 (PST) Received: from hurd (dsl-141-193.b2b2c.ca. [66.158.141.193]) by smtp.gmail.com with ESMTPSA id do52-20020a05620a2b3400b006fba0a389a4sm6376221qkb.88.2022.11.20.05.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Nov 2022 05:47:48 -0800 (PST) From: Maxim Cournoyer To: Katherine Cox-Buday Cc: guix-devel@gnu.org Subject: Re: Layout of =?utf-8?Q?=E2=80=98define-configuration=E2=80=99?= records References: <20221029034716.11125-1-maxim.cournoyer@gmail.com> <20221029041649.12144-1-maxim.cournoyer@gmail.com> <87zgcpdx6q.fsf_-_@gnu.org> <8735ag43ga.fsf@gmail.com> <8735aevdq7.fsf@gmail.com> Date: Sun, 20 Nov 2022 08:47:47 -0500 In-Reply-To: <8735aevdq7.fsf@gmail.com> (Katherine Cox-Buday's message of "Sat, 19 Nov 2022 14:25:20 -0700") Message-ID: <87fsed3fgc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f35; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668952088; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=16YNv9MbJzajrDEoPXTgAO9QlQGS3hIob8Dli70rHk4=; b=WZP3FrcU1/vepvIGW+uq82f743B+NliX72upW/qAFkLSnHw+mKWsxpFAxVE/D5/wzdiuNC hz5vPVFXaByg8rhgpT9uB7Gi61+OA9keNcxp0ccQwbQRXWktfvDF+Kmyn9+1w+z9EbVK7s tHiPSnS8ePZaDuCtcll+yaj1ggOZaGM6nuoTQmYbRcsomxm3BkrbC10ji4XFpEFnPF/wFZ 0Z4SIHljAmi8gK4v+hAgsF0MHchPa8AZbKLT2y87/RD9C6b5LKZB9fKTKAoMtvjRhVRY6s wegneSM9GdJzEgl4JONs8yqzeMtAtlrCw4tsmfM7ZgjeRz1yqwubfmk11Q4qQw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668952088; a=rsa-sha256; cv=none; b=hJI4PWOnVYRtFSiFDvDxGLoaH8T2T6fZWWjh7bbfcIED0sM7AUHIcKZdDTIcVbH742MUmp Xv36FpC/Thd29kSUHv+Ot8FSkQAysWFJtLNjEZOFG8SnI8UkaQ2pZa7cALbaj+K0UYN6Sk 5Ut+yhc0kCA/IH7CpHc5NjaXgN0EwtOvRB6spal8kMe/Guv5Om0FKiXfGKmIZlMTOrqW5O gZEOSSLMib4AAtaqjcsCloAgUDeFEELu4N3fdaR102dyCxQXM6TOJwUyljvU2CfJQTeqwq BCYchm6F+1A2DJAVcgwiBt6ySuB2W2sqeqNqWDRnRHbwlkLGJVCwb78CGWkf2Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oNadqw7s; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.51 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oNadqw7s; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 603963DE27 X-Spam-Score: -2.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1rtPzA+1rN2d Hi Katherine, Katherine Cox-Buday writes: > Maxim Cournoyer writes: > >>> Moving the field last is problematic as we=E2=80=99ve seen for any user= that >>> uses =E2=80=98match=E2=80=99 on records=E2=80=94something that=E2=80=99= s not recommended but still >>> used a lot. > > Some feedback I hope is useful: > > I'm one such newbie, and had to stumble my way into discovering why some > of my services suddenly broke. All I had to go on was with "invalid > G-expression input" at a location in an `operating-system` declaration. > > Initially, because of the reference to gexps, I thought something had > changed with `local-file` which I am using to deploy source code off of > a local branch. Through trial and error and reading git logs, I > discovered this was not the case, and saw that `define-configuration` > had changed. From there I was able to discover the problem. > >> Yep. I had that on mind when I made the change, though I still missed >> a few occurrences. > > I came looking for an announcement of this change somewhere on a mailing > list (info-guix maybe?) or the Guix blog but couldn't find anything. I > understand the focus is on in-repo code, but could we consider > announcing changes which might affect channels and such? I don't always > have time to stay up to date with the changes to the project :( Apologies for causing grief! Ironically, the change was motivated by going through such pain myself when attempting to migrate the mcron-configuration from a define-record-type* to a define-configuration produced record, that's why I wanted to standardize their layout. I'm taking yours and Ludovic's feedback into account for the future and will reach out to guix-devel with heads-up when introducing breaking changes to Guix APIs. A side-note, it seems that Ludovic has been working toward eliminating the use of match patterns matching the fields directly, instead encouraging the use of 'match-record', see https://issues.guix.gnu.org/59390. I haven't checked if this is compatible with define-configuration records though. --=20 Thanks, Maxim