From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +AwDKhWAgWMBpAAAbAwnHQ (envelope-from ) for ; Sat, 26 Nov 2022 03:55:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2HsoKRWAgWNuGwAAG6o9tA (envelope-from ) for ; Sat, 26 Nov 2022 03:55:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 697523AA0C for ; Sat, 26 Nov 2022 03:55:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oylLM-0006PQ-40; Fri, 25 Nov 2022 21:55:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oylLK-0006P5-LJ for bug-guix@gnu.org; Fri, 25 Nov 2022 21:55:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oylLK-0004sa-Ct for bug-guix@gnu.org; Fri, 25 Nov 2022 21:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oylLK-0005bN-5d for bug-guix@gnu.org; Fri, 25 Nov 2022 21:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#59423: Invalid 'location' field generated in dovecot configuration Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 26 Nov 2022 02:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59423 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Pierre Langlois Cc: 59423@debbugs.gnu.org Received: via spool by 59423-submit@debbugs.gnu.org id=B59423.166943129921521 (code B ref 59423); Sat, 26 Nov 2022 02:55:02 +0000 Received: (at 59423) by debbugs.gnu.org; 26 Nov 2022 02:54:59 +0000 Received: from localhost ([127.0.0.1]:37580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oylLH-0005b3-15 for submit@debbugs.gnu.org; Fri, 25 Nov 2022 21:54:59 -0500 Received: from mail-qt1-f180.google.com ([209.85.160.180]:44012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oylLE-0005ap-GB for 59423@debbugs.gnu.org; Fri, 25 Nov 2022 21:54:57 -0500 Received: by mail-qt1-f180.google.com with SMTP id a27so3489861qtw.10 for <59423@debbugs.gnu.org>; Fri, 25 Nov 2022 18:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TpoxdryMtcLsBP8UWA9srG4OEY6EwVy291wH05v/wT0=; b=KWZSzRQb+Q5tKZYuRoXmaEzQQ2SVYJRku3eyVEzRVKduxbX8iBcMlQ4Cg7kaGqtY14 Vd4W4FRLGiVVGz+P1KK+Bo4di+FLFFMk0iVXO6zh+lA+LDkrY6JlWw1QA44l83B6Fgrw SGCB1uPtZiipU/rSdK2Gg6a+Cegq+TwGo9pnne8QqY7RqljMy8yM0PUWNAXVRQmmEDSh Sth69uTSOTfTtt8BvyBMqEHjdl3LQCMOmt6kOhpl144k/5BkzrQlPK9cnsDEFeWEbj1k 7Fwx4ttrfLonikWI4Bdse9oVroWAV47Mg52kYLx/hX/5o5chmvQD0bG9+LZ2qI45JR4C G9xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TpoxdryMtcLsBP8UWA9srG4OEY6EwVy291wH05v/wT0=; b=pdONAn9y7EHh1eCJoyLSTzNQKwTBcvAzNocP0iW/hQnmPMNpoW5ZlrYXlPav/ks4DP i05ic02X0PEz7fL5fOPjw90sPtck5jU5r+8QBK0E2rCXrasA/S6wo/qd/bQd7lLkdCpJ PYb2A4TLTp7BjnheL+xZK1K92kuv2FjjcpfOUIx15dzoQjulYU+XafB5KzsIHXsomNCV I8ucQspytGDS85eM3eRJxOf7LCzPqBKvNVZGQtmVu+zKxje4qePzZuV2x99OkGVZ9bkn j+OjyCzPnApPhkWgOObMgWmDYFTdDQeO4m9LOuM+QMq0nOQsVx6WI3YoVzAkWsVgr4Ui 96sw== X-Gm-Message-State: ANoB5pmXpjOFEAu9cNNKlFJDbtv13IUU95nR7qM6FBL3SMNiV+zQ9s5n ahf+P9l+diZwjZ945zTqcFkHr3tUXyI= X-Google-Smtp-Source: AA0mqf6DaPOSnXUtzS+0l4Pk6J2n0eHI15oPCYesi3Y49exa09wHrU6MQQ4QmYWJMl43qsEaxGfnHw== X-Received: by 2002:ac8:4987:0:b0:3a5:274c:611e with SMTP id f7-20020ac84987000000b003a5274c611emr38188613qtq.143.1669431290781; Fri, 25 Nov 2022 18:54:50 -0800 (PST) Received: from hurd (dsl-154-228.b2b2c.ca. [66.158.154.228]) by smtp.gmail.com with ESMTPSA id bp7-20020a05620a458700b006f956766f76sm3864203qkb.1.2022.11.25.18.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 18:54:50 -0800 (PST) From: Maxim Cournoyer References: <87y1s5wa4p.fsf@gmx.com> <87v8n2iytp.fsf@gmail.com> <875yf293ph.fsf@gmx.com> <87y1ry7o69.fsf@gmx.com> <87cz9a7n4y.fsf@gmx.com> Date: Fri, 25 Nov 2022 21:54:49 -0500 In-Reply-To: <87cz9a7n4y.fsf@gmx.com> (Pierre Langlois's message of "Fri, 25 Nov 2022 21:09:49 +0000") Message-ID: <87fse6fmrq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669431316; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TpoxdryMtcLsBP8UWA9srG4OEY6EwVy291wH05v/wT0=; b=HidpAH/YTJQjE+HVaACMDKqqP/slCFO1K3rzqs3Arx/ysuQ7yjY3E6A1F7Y6OvhKmaIUn6 YoaBpAOK1lCZELaJVv/IuU12OERd+76RK2I9e0Y/OMvRhDyAaj3fAydaAIVb2N5W4u9oRE SONnHQRyrx6H5Wj63VOYHj9bd4mM1ZZZXWhtTWOTnGwjRO1HTXh0sslTJUwcEshIXqbQtd zPXcgSFVPCs3TeQ+AVrvPUemnciGUH2MyG7QIQEpIENMgZbU/phh0Tno5d8OY7f2F/6FnY vtFEWHTkCmhsKNxP4pYtpCnjWUvZIIsuNpL6XxQBafISrACu8Fmt6L2CUIk1+A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669431316; a=rsa-sha256; cv=none; b=qBms3xIDl6RS8kSqwcl9sj0YxsHepVDTOtDhRkrFhVrJiLMcSvbiNSELRhdMHTSI77PIXu Sze8W7v3sH3Idtxd5eVfwWUsppNpmSjdHjyyW+RNYDgseBbJ3fzcY8P5tlj1vdArX9aENc lr0QK9hKu5xJQqri6MRz3Buzn4Gy6TH8e7dTpxGdiwUHjHA1SK9AW8samJAkOvKE3/i1jO VQ6oLVQRIVpmDegq1NUY13fE1AZOyu+LrlLSxVbpNYH8q9yYZw1wCpDkpMwnjL98h/PTF6 p7bMKzIjQLblw6ZvSG7r4pSetmnUMeK7GUmNPcxPxFYl9anqnaH4uZ8jNBgbhg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KWZSzRQb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KWZSzRQb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 697523AA0C X-Spam-Score: 6.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: SKxbzw85Tese Hi Pierre, Pierre Langlois writes: [...] >>>> I did: >>>> >>>> $ ./pre-inst-env guix system build -e '(@@ (gnu tests mail) %dovecot-os)' >>>> /gnu/store/gpl6g2ia84kc41zma7ik9y4p3kik5aiy-system >>>> >>>> Then: >>>> >>>> $ guix gc -R /gnu/store/gpl6g2ia84kc41zma7ik9y4p3kik5aiy-system | grep dovecot.conf >>>> /gnu/store/1ijjsm3sj8v0qj88fhlwqxgdszd6q6h7-dovecot.conf OK, after 'make clean-go' and rebuilding everything, I now see the issue with the above: --8<---------------cut here---------------start------------->8--- location=#< file: "gnu/tests/mail.scm" line: 297 column: 20> --8<---------------cut here---------------end--------------->8--- So, that's that. >>> Yeah I'm afraid I still see the same issue after a `git pull` just now: >>> >>> ~/code/guix [env]$ ./pre-inst-env guix system build -e '(@@ (gnu tests mail) %dovecot-os)' >>> /gnu/store/ayfvf5s561q955kv8wrkklrvq3ga3qpy-system >>> ~/code/guix [env]$ guix gc -R >>> /gnu/store/ayfvf5s561q955kv8wrkklrvq3ga3qpy-system | grep >>> dovecot\.conf | xargs grep "^location" >>> location=#< file: "gnu/tests/mail.scm" line: 297 column: 20> >>> >>> Have you tried to rebuild from scratch, after a `make clean-go'? When >>> first bisecting this, I was working from the git repo and couldn't >>> reproduce the bug. Then it worked by using `guix time-machine' to bisect >>> rather than work from git. >>> >>> So I'm guessing the change being in a macro, there could be residue .go >>> files that need recompiling? >> >> Oh, I just realized the change was reverted with >> 44554e7133aa60e1b453436be1e80394189cabd9, then I'm probably the one who >> needs to do a `make clean-go' :-). The change was reinstated as part of the mcron update, in 44554e7133aa60e1b453436be1e80394189cabd9. The bit that seems to cause the issue here (still not clearly understood) is probably this one: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm index 636c49ccba..dacfc52ba9 100644 --- a/gnu/services/configuration.scm +++ b/gnu/services/configuration.scm @@ -242,17 +242,17 @@ (define-record-type* #,(id #'stem #'< #'stem #'>) stem #,(id #'stem #'make- #'stem) #,(id #'stem #'stem #'?) - (%location #,(id #'stem #'stem #'-location) - (default (and=> (current-source-location) - source-properties->location)) - (innate)) #,@(map (lambda (name getter def) #`(#,name #,getter (default #,def) (sanitize #,(id #'stem #'validate- #'stem #'- name)))) #'(field ...) #'(field-getter ...) - #'(field-default ...))) + #'(field-default ...)) + (%location #,(id #'stem #'stem #'-location) + (default (and=> (current-source-location) + source-properties->location)) + (innate))) (define #,(id #'stem #'stem #'-fields) (list (configuration-field --8<---------------cut here---------------end--------------->8--- Reverting it would likely fix the issue (haven't tried), but it'd be nice to have a clear understanding of what's going on. It may have unmasked a bug waiting to bite. The issue seems to be with the serialization of the object nested in the record. I tried this at the REPL: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> ,m (gnu services mail) scheme@(gnu services mail)> (namespace-configuration (name "inbox")) $8 = #< name: "inbox" type: "private" separator: "" prefix: "" location: "" inbox?: #f hidden?: #f list?: #t subscriptions?: #t mailboxes: () %location: #f> scheme@(gnu services mail)> (serialize-configuration $8 namespace-configuration-fields) name=inbox type=private separator= prefix= location=#f inbox=no hidden=no list=yes subscriptions=yes $9 = # --8<---------------cut here---------------end--------------->8--- But as you can see, it doesn't reproduce in this environment. I'll keep experimenting. -- Thanks, Maxim