From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eH0mBwHUpGNU2gAAbAwnHQ (envelope-from ) for ; Thu, 22 Dec 2022 23:02:41 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MAAuBgHUpGMfiAAAG6o9tA (envelope-from ) for ; Thu, 22 Dec 2022 23:02:41 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D60181A7C8 for ; Thu, 22 Dec 2022 23:02:40 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8Tdf-0003wP-Ex; Thu, 22 Dec 2022 17:02:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8TdY-0003vm-GB for guix-devel@gnu.org; Thu, 22 Dec 2022 17:02:00 -0500 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8TdW-00080v-0H for guix-devel@gnu.org; Thu, 22 Dec 2022 17:02:00 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 56C441AC44; Thu, 22 Dec 2022 14:01:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1671746509; bh=w5WOhV6UNCsIME0kH1DYHNqxiceTkySvfcpG5bseVpI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DBubZnPPiFe7q0anvWFcZ/JcsIRfTPJYkifVTIYjPqZe8I2WPBJRCSyqnSXdr0EYt omkwA+rvTiS6K7IFqUVpy7z9zj+41SN/rTAYtTBQfsGITns+XJzHV9tIG1fmDUSFK8 34Ov1bgYK7msmFpCeRJMx2UOZ/HgrPdMUO7840CRpOGr8dqdPAUTeXN9UsrEGXMvEM ip2OoH91MlWHH4yi5nQaqOKhT6ne7vqKsPWcaqtG2UfC/FHKvEagFGwTW+EZznJUBe LY5MNHathM8FnG8RHhBWoicxT5FXQ8tKpT6mudbcT5DtyBIS2JVAQir49SB4yirheF oIUzjazeLA4yg== From: Vagrant Cascadian To: Maxim Cournoyer Cc: guix-devel@gnu.org Subject: Re: u-boot-am335x-boneblack -> u-boot-am335x-evm-boneblack In-Reply-To: <87v8m3w2sa.fsf@gmail.com> References: <87len0y1kk.fsf@contorta> <87v8m3w2sa.fsf@gmail.com> Date: Thu, 22 Dec 2022 14:01:44 -0800 Message-ID: <87fsd7ayif.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671746560; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GRnrjLWneM5pqyjIwSWEeuyOmTGQm7JczgNxCklxc64=; b=eBtA4opOuG+i/YYuA90cGho76E2Bda6hMFjlQRr3CenzRkfKZBa0ZcRlgmBTqz0LgFVU5X fXReZSFs29nyXxcMFh4cWWaIU8vIO2sNdlFdblSUuJp4Ta6K+3hfkls0gELCnbBd4KglSP nto2PBXv/T/sigmCB72sdvlXSSyOUvUdS+85dhwdu8lRog32WVxFMfGUNFJFzJ0221iHGP qHsvi18H+u6J+/rCds1gEmxeRWuoj+CvBtYcMKDOEJnwOTNC/6Zbs5HMXC2hQE/W//1ICg BCM9HZ/7gJ91o/xOcOiwT4yqFIiQJNtp7Y7zZIMgZgw2skfKVj1TDuQBdUB0uQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=DBubZnPP; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671746560; a=rsa-sha256; cv=none; b=KtGHRuOSS5CbpOJ7m3Wv3HF9IOTH5nv91rqc/FQ8jsSxRmNBq2MisPCL8LTE93AwVg/Uq3 unIN36R10+R61rIVQLEc8sSZpfmwZzD71vcmUj9SWAOVfcvQM4Ci2AlZz7nDKe0M3K6rDa clzRzz2CIMcM4H1YeOuL//1N1c9Py5MUJpkDNrLKt5UyoX0e4ebuABVFGN9uCFDOr+ueUL sjUL4Uo4lQqfVuYvP4IMxlxxb3ugRqjwcZ7PwgyzHaJxaKdcIT3Jl+YKN9OiuQQRSZv0rH KQZRcVJdgsYAoWcQtt3T/iaTKf2MpchhDEAIg8aUL4Ui5snf40LjsM75zDohjQ== X-Spam-Score: -9.36 X-Migadu-Queue-Id: D60181A7C8 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=DBubZnPP; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -9.36 X-TUID: UlCVeloyzj2i --=-=-= Content-Type: text/plain On 2022-12-22, Maxim Cournoyer wrote: > Vagrant Cascadian writes: > >> Wondering what necessitated this change from the old variable name to a >> new name... >> >> commit c04528d2a2597d79278833f3607c806278253446 >> Author: Maxim Cournoyer >> Date: Tue Dec 20 21:25:27 2022 -0500 >> >> gnu: u-boot-am335x-evm-boneblack: Fix variable name. >> >> * gnu/packages/bootloaders.scm (u-boot-am335x-boneblack): Rename to... >> (u-boot-am335x-evm-boneblack), to match the package name. >> * gnu/bootloader/u-boot.scm (u-boot-beaglebone-black-bootloader): Adjust >> accordingly. >> ... >> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm >> index bd9f7bb577..c8b8adbc93 100644 >> --- a/gnu/packages/bootloaders.scm >> +++ b/gnu/packages/bootloaders.scm >> @@ -889,7 +889,7 @@ (define*-public (make-u-boot-package board triplet >> (define-public u-boot-malta >> (make-u-boot-package "malta" "mips64el-linux-gnuabi64")) >> >> -(define-public u-boot-am335x-boneblack >> +(define-public u-boot-am335x-evm-boneblack >> (make-u-boot-package >> "am335x_evm" "arm-linux-gnueabihf" >> ;; Patch out other device trees to build an image small enough to fit >> >> The u-boot-am335x-boneblack was named to match the original target that >> was removed from upstream, adapting the upstream am335x-evm to fit into >> a smaller gap in the partition tables... (e.g. 2MB partition offset >> instead of 4MB offset required by the default am335x-evm board >> configuration). > > The problem was that the *name* of the package was > "u-boot-am335x-evm-boneblack", as computed by the MAKE-U-BOOT-PACKAGE > procedure, which includes the board argument in its name (it's been like > this since its inception in 862e38d5518, 2017). > > If the previous variable name should have been its name, the name field > would have needed to be overridden to it (or perhaps we could introduce > a #:name argument that would take precedence over any cleverness). > > I noticed of the problem when trying to build the package; "guix build > u-boot-am335x-boneblack" would tell me it didn't exist. > > I considered making a deprecated alias but decided against, because in > the past we didn't when moving/renaming packages *variables*. Odd. I was certainy able to build u-boot-am335x-boneblack from commit 6b99afeef89233b71d113a63cf04a6b4b49a4679 when it was introduced in 2019, though it has been quite some time since I tested it... I will take a guess that it was commit c2c1dfdf5760873f1db86d14873f725a105f7feb which removed the "name" bit: (define-public u-boot-am335x-boneblack - (let ((base (make-u-boot-package - "am335x_evm" "arm-linux-gnueabihf" - ;; Patch out other device trees to build an image small enough - ;; to fit within typical partitioning schemes where the first - ;; partition begins at sector 2048. - #:configs '("CONFIG_OF_LIST=\"am335x-evm am335x-boneblack\"")))) - (package - (inherit base) - (name "u-boot-am335x-boneblack") live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY6TTyQAKCRDcUY/If5cW qtANAPwILW+2PXAvtuWZFUZzxZU94G4YBD3/d53Ccd2nWER70wD/RxxEr8WF0LSB bLPbFtauJcCI8ke+91X5wwlqv+HqFgA= =lW2u -----END PGP SIGNATURE----- --=-=-=--