From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2Fl2FhZI7mOwfgEAbAwnHQ (envelope-from ) for ; Thu, 16 Feb 2023 16:13:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4OdsFhZI7mOSGwEA9RJhRA (envelope-from ) for ; Thu, 16 Feb 2023 16:13:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BDD91447D for ; Thu, 16 Feb 2023 16:13:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSfwX-0000O2-E9; Thu, 16 Feb 2023 10:13:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSfwU-0000MM-FW for guix-patches@gnu.org; Thu, 16 Feb 2023 10:13:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSfwU-0007Ee-3G for guix-patches@gnu.org; Thu, 16 Feb 2023 10:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSfwT-0006g7-UR for guix-patches@gnu.org; Thu, 16 Feb 2023 10:13:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61255] [PATCH 0/5] Add support for the RPM format to "guix pack" Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Feb 2023 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61255 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 61255@debbugs.gnu.org Received: via spool by 61255-submit@debbugs.gnu.org id=B61255.167656036025636 (code B ref 61255); Thu, 16 Feb 2023 15:13:01 +0000 Received: (at 61255) by debbugs.gnu.org; 16 Feb 2023 15:12:40 +0000 Received: from localhost ([127.0.0.1]:37263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSfw8-0006fQ-FU for submit@debbugs.gnu.org; Thu, 16 Feb 2023 10:12:40 -0500 Received: from mail-qv1-f48.google.com ([209.85.219.48]:45868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSfw6-0006fC-Fk for 61255@debbugs.gnu.org; Thu, 16 Feb 2023 10:12:38 -0500 Received: by mail-qv1-f48.google.com with SMTP id s17so421838qvq.12 for <61255@debbugs.gnu.org>; Thu, 16 Feb 2023 07:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=fBiWcdGBTkJH5dq+KlF/ZxyWbu6PJmgfFGBRtXsJ/8w=; b=BqLbU7WCNDG40TyvykJne2u8LdWgmqXBHSSqKhpRDy84bitG8rCJXmIG8QNHpzyH0I 5/ReaYLaWs53l4gnS195mn2bRKHQXbQq3Jfstp82l4TW4neCbir/5PTLGzIfoSm85qB7 idHWSmid2vJiBEm07/eAcNdBNLxRRhmZQ8KAKN6N+tWctkZuQQipHJAX+3v6Nsg/HOt2 JNl5rS6LtFh+CHyriIBxq5rhpl3Gai/t215rKOYtzpkPkefTjs7KMxlzfgPtJGPPg+4y rxigotsGB0+SCVglF3q8bxSZ1B5FkRndR/dDCOngAA0X+s12ZcbW1mD1BL6E0GM/js0F c3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fBiWcdGBTkJH5dq+KlF/ZxyWbu6PJmgfFGBRtXsJ/8w=; b=trIfeboj1TosAAB2JLcj7uKUE/BWM6rvH0MGCFPDOCtXdik0X4uapgpeMzvl4pDN1g gpoS8EpJrw8WvXVPQdwHyTWqPD0JV7rlSffFWY72M0GiJV5ZTn9TaAzBTxAZjZhgGi+s nbSe/CCVoOJS43GMpJvDZSQfs4KKWkWIW6Qt0cl7zBRbbmodYfRJvGNhr3e1aol9SEHQ c5ILefj7bQ9gYXzEKZLHEYCns4pLbPF+JAneo6x0LiGta4uAz+wKA8mAdja2xi5xHUXG 5ZXqu4XE63j2SXhXQ0Dg0fjju8wregKdnr4oskRfQVMosXSezd1unUK3jBsrFkCCSis/ rMbQ== X-Gm-Message-State: AO0yUKU6/x5vTDDR/53ob9cUojujw5MKb6VIN0YRbsuZ+k8XoADhvuhA D6ocBlSElNmvjHiaZ5viCIc+ub7NxP2giyQc X-Google-Smtp-Source: AK7set/N4VfQHhqJmnZZnsplmkt3mD5Vc1gKeDmxtnanA7fJHdQKK5+9nQPfpJ7nwK1eIqoe5CbZcw== X-Received: by 2002:a05:6214:d89:b0:56f:37a:4561 with SMTP id e9-20020a0562140d8900b0056f037a4561mr1761456qve.34.1676560352686; Thu, 16 Feb 2023 07:12:32 -0800 (PST) Received: from hurd (dsl-152-188.b2b2c.ca. [66.158.152.188]) by smtp.gmail.com with ESMTPSA id l67-20020a378946000000b0073b9ae1c022sm806522qkd.135.2023.02.16.07.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 07:12:32 -0800 (PST) From: Maxim Cournoyer References: <20230203221409.15886-2-maxim.cournoyer@gmail.com> <20230203221409.15886-3-maxim.cournoyer@gmail.com> <877cwyw7yc.fsf@gnu.org> <87h6w2p02y.fsf@gmail.com> <87a61ilpi6.fsf_-_@gnu.org> Date: Thu, 16 Feb 2023 10:12:30 -0500 In-Reply-To: <87a61ilpi6.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 12 Feb 2023 19:14:57 +0100") Message-ID: <87fsb5wso1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676560406; a=rsa-sha256; cv=none; b=B9eXsL8Pdnvl/spekBnwaCaBlcjdIyJVwsrH+MRb0coViC7hN3XoEi1ixRTl3kS/AH6NK7 Ym6KlfHuZ4EsQm2GYujapRz665xCI67Gii7gDyjejHLq4kKN4z/um9lo6nhHgueRS/u/sq D67EcSt4cq0GT5iRa5CskBkZ11ELzl9aFOeMYPQTKc6It2J0CgoQsxAJtzfIT8+8L+vhxn /PgL2us8Brc/BLKK0Qzj6i/2y+ry3v1Ml9XVtGcliNlFueC/xQtcb7WzQ3U1a/xLotouER K92Ye4mVcfRzO45mMBaYr40vI5HZiLJOobrA+ltCMTgQkc6ySgStsNW/zPJ1xg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=BqLbU7WC; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676560406; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fBiWcdGBTkJH5dq+KlF/ZxyWbu6PJmgfFGBRtXsJ/8w=; b=BuScBIrh5amnoUjX/Dtiu6JV2CivHdT9YPNXbui109mRr8Uh5+E1ckzt5SZUrRSCzXYGaM IL5KnojsPAmyyn5wwLx0JjJIKpInA1MZzswB5SS/lbGXrNJquyVjJWOBGP6dNbN2iR3DQC so1BlztV21N5nWcDTIX9bRmCFtETybyUH29xFfAobpya0EPmotsSdXDoiNOUKkBRoWFVZW H7JdZdGgDg1q5SFbHz1Krp+v0NnCyl5eLlq5yAZpDNfAesgZgUoCI3jTGXmAOyCxPmiJcH BpggDBEde/g6iUSKX34itq+D60kms0MM5ukJJdCUVjUfdhXSuL8eM9V+Es/W+g== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=BqLbU7WC; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: 0.98 X-Spam-Score: 0.98 X-Migadu-Queue-Id: 3BDD91447D X-Migadu-Scanner: scn1.migadu.com X-TUID: 3PAwLNOTWHLn Hi Ludovic! Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Hello! >>> >>> Maxim Cournoyer skribis: >>> >>>> * guix/gexp.scm (computed-file): Set the default value of the #:guile = argument >>>> to that of the %guile-for-build parameter. >>> >>> [...] >>> >>>> (define* (computed-file name gexp >>>> - #:key guile (local-build? #t) (options '())) >>>> + #:key (guile (%guile-for-build)) >>>> + (local-build? #t) (options '())) >>> >>> I think that would lead =E2=80=98computed-file=E2=80=99 to pick (%guile= -for-build) at >>> the wrong time (time of call instead of time of lowering). >>> >>> Commit ab25eb7caaf5571cc9f8d6397a1eae127d7e29d1 made it #f such that >>> =E2=80=98gexp->derivation=E2=80=99 gets to resolve it at the =E2=80=9Cr= ight=E2=80=9D time. >> >> I see! I think you are right. Would making the change in the >> associated gexp compiler do the right thing? Currently it ignores the >> %guile-for-build fluid as set in the tests/pack.scm test suite for >> example. Something like this: > > I don=E2=80=99t fully understand the context. My preference would go to = doing > like the =E2=80=98computed-file=E2=80=99 tests in =E2=80=98tests/gexp.scm= =E2=80=99, where we explicitly > pass #:guile %bootstrap-guile. With the refactoring done in patch 3/5 ("pack: Extract populate-profile-root from self-contained-tarball/builder."), a computed-file is used in the factorized building block 'populate-profile-root'. Without this patch, the tests making use of it would attempt to build Guile & friends in the test store. > That said, it seems like patch #5 in this series doesn=E2=80=99t actually= use > =E2=80=98computed-file=E2=80=99 in =E2=80=98tests/pack.scm=E2=80=99, does= it? It does, indirectly. I hope that helps! --=20 Thanks, Maxim