From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SPkvJZjviWTAzgAASxT56A (envelope-from ) for ; Wed, 14 Jun 2023 18:49:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8C9MJZjviWSVgwEA9RJhRA (envelope-from ) for ; Wed, 14 Jun 2023 18:49:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5340425B8F for ; Wed, 14 Jun 2023 18:49:28 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9TgA-0002rW-Rw; Wed, 14 Jun 2023 12:49:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Tg7-0002p4-7w for bug-guix@gnu.org; Wed, 14 Jun 2023 12:49:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9Tg6-0001DN-RG for bug-guix@gnu.org; Wed, 14 Jun 2023 12:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9Tg6-0003pv-NC for bug-guix@gnu.org; Wed, 14 Jun 2023 12:49:02 -0400 Subject: bug#63869: [shepherd] `guix system reconfigure` forgets `herd disable mysrv` Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Wed, 14 Jun 2023 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63869 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: Attila Lendvai , 63869-done@debbugs.gnu.org Mail-Followup-To: 63869@debbugs.gnu.org, ludo@gnu.org, attila@lendvai.name Received: via spool by 63869-done@debbugs.gnu.org id=D63869.168676128414536 (code D ref 63869); Wed, 14 Jun 2023 16:49:02 +0000 Received: (at 63869-done) by debbugs.gnu.org; 14 Jun 2023 16:48:04 +0000 Received: from localhost ([127.0.0.1]:45365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Tf9-0003mM-Qr for submit@debbugs.gnu.org; Wed, 14 Jun 2023 12:48:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Tf8-0003lG-2K for 63869-done@debbugs.gnu.org; Wed, 14 Jun 2023 12:48:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Tf0-00016C-JG; Wed, 14 Jun 2023 12:47:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3vwR9s1zx0tKmrR3lp/m3QSS27HNyypSeM1E6VZ/hpk=; b=gNj3OG2YEvGpT/dqXQW1 tKB5H6AOKXjXMceJzS4qabLLuEGpDY+qFLMVorIHrBdmBqO7/DXZpbytrCCjEMOnqk4sQpVwkfd2D JYWm4wz3eyRQZ7wOjDbko6PLDP41y9H8nDvkxG8ZsCpERjF4dVID4O1snJJwMigmWa4LsLy/1VGvM Rj6tciZf3ueUpn9pKLVq6dOGqmkpqhPBQ2fMmQ/jAT8nNhFL9pxyyAab64wfsiCN+h95B+0NTDT13 fqaPcR/9xAt61UnuLCl35nlyQiaXWcmUb5UdMUvhYTTWXvU15lOu83On3V5PYaxSbz3PwcK/sm65/ 14t5msx1zraRDQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Tez-00010g-Se; Wed, 14 Jun 2023 12:47:54 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <0-BRpRybKIwoQqvJIFAqQXuRYKM-U2rlt_Gn9XVlAfxUXoNw8PHqgmoQ5qRREt_sD4UffMLKEyindAKpHdYxHb5QMq1jzybHMMq6eLnkBU4=@lendvai.name> <87pm6ajsi9.fsf@gnu.org> <87jzwgczm4.fsf@gmail.com> <87fs70wz28.fsf@gnu.org> <87a5x8bkjl.fsf@gmail.com> Date: Wed, 14 Jun 2023 18:47:51 +0200 In-Reply-To: <87a5x8bkjl.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 09 Jun 2023 13:41:18 -0400") Message-ID: <87fs6urnwo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686761368; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3vwR9s1zx0tKmrR3lp/m3QSS27HNyypSeM1E6VZ/hpk=; b=GJp94/MWibAnZ/LZqpnOLpC1hql5Muipw2J2U954uSwcz2Wu8sRaoe5xxKujNmDG9KvkVV MviZ349uas6pMbNisrlGunWWQoYr8+X6868/rLF1GIW9eiGrq6Gb3QJwj1hA0j1Uphm3G9 h5bJZ5b0uAyoZhfa76vvj3qp9UPKdPgIw9s7FWtH8o9W02EbOy3QURkEbDXcuK8p546MjL ZucuwrezDvJWL+EHp+Cv88eegSOEDZoyBVZOArDt840mEeTr4/jlN19zXHseCGfSamgcdm 5JQ2kL5P4Fndiiu52gdoSdT1RHHWjjOzvxXP0X7LhzE54ky8QH8KsVz/nj+8sQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gNj3OG2Y; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686761368; a=rsa-sha256; cv=none; b=EQXp3ToVQPJ6O8ZmEEiraNaBQ+1yNL6zhwRAc2anQ10modVLlSmvweBawKudj5fcmNd2N5 CDOKDGyehXXFoMggLcMp17Vs9/VjdixNxPlbhkJyu22kkb+FJJdtJGK0brIXjWCVHhvZU+ IhZls+zWlmEf0XbWFo/yGD+uAM4BTXQ6kE6UfV5piPQ5W2JuyYt1vVSKqPUPmfEwYzZgo4 N1O1eorvWQAx9hl4JkKCcGZKN6ZYeHxmmrkAsrP02jMtvop/cGuOrgms9fPvitH03nJoht VkdHD6fnzGorhVCJfLx+HflWmkbwQ50rSBkbICj82m+kRUdtu4x6PEVbJjxqjQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=gNj3OG2Y; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5340425B8F X-Spam-Score: -4.13 X-TUID: rxbv7meI414Q Hi Maxim & Attila, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: [...] >>>> When a service is stopped at the time of reconfigure, it is immediately >>>> replaced and then started. >>>> >>>> Replacing works by unregistering the old instance from the registry and >>>> registering a new one. As a side effect, you end up with an instance >>>> that=E2=80=99s enabled (see =E2=80=98service-registry=E2=80=99 in (she= pherd services)). >>>> >>>> I never thought it could be a problem. WDYT? >>> >>> I think it probably goes against users' expectation (i.e., systemd) that >>> a disabled service stays disabled unless manually re-enabled (I think >>> that's the way it is for systemd, even when the system is upgraded?). >> >> Does systemd have a notion of enabled/disabled? > > Yes! 'systemctl disable ' [0]. It does stick around until the > user changes it, I can confirm the behavior which I've recently seen on > a Debian system upgrade (the service remained disabled and the updater > warned it wouldn't be restarted because of that). > > [0] https://www.freedesktop.org/software/systemd/man/systemctl.html#disa= ble%20UNIT%E2%80%A6 > >> I=E2=80=99m fine either way. We can also change it such that replacing a >> disabled service does not re-enable it; that=E2=80=99s probably more log= ical. > > I guess sticking to the established convention set by systemd would > cause the least friction down the road. If we agree on this, we should > reopen this bug (and eventually fix it :-)). Agreed, fixed in Shepherd commit 52db31e5b061440cd110da4848ab230ce09f365a. Thanks! Ludo=E2=80=99.