From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wJmoDK3ytmTdCgAASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 22:14:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QJ2jC63ytmThIgEAG6o9tA (envelope-from ) for ; Tue, 18 Jul 2023 22:14:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB73D3D23A for ; Tue, 18 Jul 2023 22:14:36 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=YfmdekFp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689711277; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=kNnFV1yzhEvYMAHqsbeL/x2uwZcRgM12jf3YYnERSiI=; b=iTjbnu2VznfQmntWKbmm5d4xgnqU3CvUJm0HDhCPh1dy53340VaYtz2jnIv/yywzFGDcb3 tBEvSXfK0z1h/mRzCPwfoZOmSt1qDQ1U127a0soOJHoIJP7DTkFJrG36CAv/eu+7vxdRCI sS9pJtBJZIkgT4tTFTNqEl3NV0LRfvZm/A4Vl+i2nJezL9fJn47P5uviJXOL3V9gdLdnPM jyr170uiw8yArL+1VZ25pYScnaWqBu17TO+RnKBC/BFrUAEYtUjChowIbKKj0rCegY6ldp LKZfAKo74cKryLTKXOPm2/wYJhltml/DeDuDaV35F93ibxwjREZ4LaSw2aD0XA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689711277; a=rsa-sha256; cv=none; b=nPcUaTZy//9PuO9AK2j3lneRoaiXRbNdLwctBlBK4ud0mvLtII9RiUHAG4chTgjM11t/Ln aYHix/t9SzlxQmo0RhQX1eyLpcOC8QUv+GzG08OhCiCkRZUNnq6sapKjh0ooevXkzTiHkE EggaqUCx09tS85Kv/f0ImrzLIoKOAj9zWnBYhlOPf2Cyvn2SZ2IHT4wX+yrH8WIWZW8X0K rD0awdGilmKj+0Maha9W0bu4kdRrDAuuslhdLEB0XdF5MP9KNiNSHtj9Nf9DH3EdmqkO03 lu0LRURPfzWSm6QXuQKObJa93/37v65No2m4nP7slz0Gahkxk/7gjSIAM+FuWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=YfmdekFp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLr59-00087Y-W1; Tue, 18 Jul 2023 16:14:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr58-00086n-BU for guix-patches@gnu.org; Tue, 18 Jul 2023 16:14:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLr58-00009K-3j for guix-patches@gnu.org; Tue, 18 Jul 2023 16:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLr57-0003y9-Vx for guix-patches@gnu.org; Tue, 18 Jul 2023 16:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64711] [PATCH 39/43] gnu: harfbuzz: Support build for the Hurd. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: Raghav Gururajan , 64711@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 64711-submit@debbugs.gnu.org id=B64711.168971122915223 (code B ref 64711); Tue, 18 Jul 2023 20:14:01 +0000 Received: (at 64711) by debbugs.gnu.org; 18 Jul 2023 20:13:49 +0000 Received: from localhost ([127.0.0.1]:54385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLr4v-0003xO-63 for submit@debbugs.gnu.org; Tue, 18 Jul 2023 16:13:49 -0400 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:42401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLr4p-0003wy-VO for 64711@debbugs.gnu.org; Tue, 18 Jul 2023 16:13:44 -0400 Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-403b3273074so511821cf.1 for <64711@debbugs.gnu.org>; Tue, 18 Jul 2023 13:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689711218; x=1692303218; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kNnFV1yzhEvYMAHqsbeL/x2uwZcRgM12jf3YYnERSiI=; b=YfmdekFpm/EuwaJiqfTqh+pPGrWS1t64bEZbuZljy7+EZJE1urei8u+n8G8S6UBF+A v8/ZUOQcf4F6YhDbziu9/2f/DOnfX4Oz7XBVdGp+Uw/wai/krZDmGsSDT3hpRWBhT+N0 U81m97Q3BDr9628cbAbTvPz+joueRZyjhKwvX1Ad1D9P9iqbb7/YNZ5JVMYI97TIw1PE kmfLp/cTEUGvMRICS9PifFyYKYus4H2PWnUPsgAfAChvliaqIkld6VdEq7vtRk0DKAX3 8tO9ibhJGQDNZBcy44DKZQSkK0LqZJ7VAPs0J2v5xvompmNayZ3KAodgEMo1Lqum/0Zf BC7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689711218; x=1692303218; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kNnFV1yzhEvYMAHqsbeL/x2uwZcRgM12jf3YYnERSiI=; b=hM6a4cMfdl6RZuVg4nTkxyKoDEh2U1trn4AIEjG5e9ZVAzHpoR37FsTkCDp3H48oHd wkfNZeB88n5b0JXI0q2LhRNG7bcVUxPljbY5iPfJiwL8prVtTSiXc4sWDrou5dzI8LM5 ZI3CNT6wGsATXke7JC3jnuxMzY2F08G7jSAjmiV9PcPWO0/jD8sPpcPoqhH9Jwn26XuE sMhHu3tfDOA6DvJUnTUV9HFw65du+ERyzBmZ3MT24alD/p/Q7icCwVAfjCju1+Z1dTBF wT1gyApD8yPXutmP8ya3N0dp924ugPO2d5KfBVWitd4Zo9g+MSIgXHTfnWfFcY8tFNyE iSVw== X-Gm-Message-State: ABy/qLbgIHIM3hqMH8UGDLAh/wGpbkvF77HlN1BrdeH/mbkei7xD4P/f tYQ2pz1Mrr931zX9nIazWSo= X-Google-Smtp-Source: APBJJlGhOCD3aaZZ6aT7ElmycXhnLjSM8Tr4sxFNw/lSfDBn20ovm3F4Md7qE1lLt2Xr5GmPXvm8zQ== X-Received: by 2002:ac8:5703:0:b0:403:aa3a:36d with SMTP id 3-20020ac85703000000b00403aa3a036dmr316813qtw.5.1689711218138; Tue, 18 Jul 2023 13:13:38 -0700 (PDT) Received: from raisin ([2607:fad8:4:6::984a]) by smtp.gmail.com with ESMTPSA id c23-20020ac84e17000000b0040335131048sm855666qtw.93.2023.07.18.13.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 13:13:37 -0700 (PDT) From: Maxim Cournoyer References: <9fc9a0ae11de8c4484558c0cbac047330ca909f6.1689690897.git.janneke@gnu.org> Date: Tue, 18 Jul 2023 16:13:37 -0400 In-Reply-To: <9fc9a0ae11de8c4484558c0cbac047330ca909f6.1689690897.git.janneke@gnu.org> (Janneke Nieuwenhuizen's message of "Tue, 18 Jul 2023 16:40:32 +0200") Message-ID: <87fs5lt1u6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: 5.86 X-Spam-Score: 5.86 X-Migadu-Queue-Id: EB73D3D23A X-TUID: PqWV/GjVFM3Y Hi, Janneke Nieuwenhuizen writes: > * gnu/packages/gtk.scm (harfbuzz)[native-inputs]: Do not include > gobject-introspection when building for the Hurd. > --- > gnu/packages/gtk.scm | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > index eb69a88221..853696c7f5 100644 > --- a/gnu/packages/gtk.scm > +++ b/gnu/packages/gtk.scm > @@ -276,11 +276,13 @@ (define-public harfbuzz > ;; There are all in the Requires or Requires.private field of '.pc'. > (list glib graphite2 icu4c)) > (native-inputs > - (list `(,glib "bin") ;for glib-mkenums > - gobject-introspection > - pkg-config > - python-wrapper > - which)) > + `((,glib "bin") ;for glib-mkenums > + ,@(if (target-hurd?) > + '() > + (list gobject-introspection)) > + ,pkg-config > + ,python-wrapper > + ,which)) Here also (basically when it's touching label-free inputs), I'd use append with a conditional to avoid the unquote noise. Otherwise LGTM. -- Thanks, Maxim