all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: pinoaffe <pinoaffe@gmail.com>
To: Vinicius Monego <monego@posteo.net>
Cc: 66199@debbugs.gnu.org
Subject: [bug#66199] [PATCH v2 1/2] gnu: Add fontobene-qt5.
Date: Wed, 27 Sep 2023 18:11:02 +0200	[thread overview]
Message-ID: <87fs2zbnls.fsf@gmail.com> (raw)
In-Reply-To: <ddca56ed-f32d-eba6-d283-4239ff834536@posteo.net>

Thanks for the review!

Vinicius Monego <monego@posteo.net> writes:

> Hi,
>
> Em 26/09/2023 09:16, pinoaffe escreveu:
>> +    (description "A header-only library to parse FontoBene stroke fonts with
>> +C++11/Qt5.")
> Descriptions should be full sentences (subject + predicate). The
> linter should be able to catch this. Otherwise LGTM.

For whatever reason it didn't catch this, but this should be fixed with
v3 of the patch series

Kind regards, pinoaffe




  reply	other threads:[~2023-09-27 16:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 20:27 [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0 pinoaffe
2023-09-26  0:37 ` Vinicius Monego
2023-09-26 12:08   ` pinoaffe
2023-09-27  0:35     ` Vinicius Monego
2023-09-27 16:06       ` pinoaffe
2023-09-26 12:16 ` [bug#66199] [PATCH v2 1/2] gnu: Add fontobene-qt5 pinoaffe
2023-09-26 12:16   ` [bug#66199] [PATCH v2 2/2] gnu: librepcb: Update to 1.0.0 pinoaffe
2023-09-27  0:39   ` [bug#66199] [PATCH v2 1/2] gnu: Add fontobene-qt5 Vinicius Monego
2023-09-27 16:11     ` pinoaffe [this message]
2023-09-27 16:14 ` [bug#66199] [PATCH v3 " pinoaffe
2023-09-27 16:14   ` [bug#66199] [PATCH v3 2/2] gnu: librepcb: Update to 1.0.0 pinoaffe
2023-09-27 18:45     ` pinoaffe
2023-09-27 18:46 ` [bug#66199] [PATCH v4 1/2] gnu: Add fontobene-qt5 pinoaffe
2023-09-27 18:46   ` [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0 pinoaffe
2023-09-30  1:34     ` Vinicius Monego
2023-10-03 23:39       ` pinoaffe
2023-10-07  1:16         ` bug#66199: " Vinicius Monego
2023-10-04  0:15 ` [bug#66199] [PATCH v5 1/2] gnu: Add fontobene-qt5 pinoaffe
2023-10-04  0:15   ` [bug#66199] [PATCH v5 2/2] gnu: librepcb: Update to 1.0.0 pinoaffe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs2zbnls.fsf@gmail.com \
    --to=pinoaffe@gmail.com \
    --cc=66199@debbugs.gnu.org \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.