From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uEySE86pJGU5CgAAauVa8A:P1 (envelope-from ) for ; Tue, 10 Oct 2023 03:33:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uEySE86pJGU5CgAAauVa8A (envelope-from ) for ; Tue, 10 Oct 2023 03:33:02 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ACF0F76C0D for ; Tue, 10 Oct 2023 03:33:01 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="mS+/+XDp"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696901582; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=J7lIkAuAqEGrkKnXm8WvCzOQxbcaGTSrXNUnbsfNdr0=; b=BGKH574FYR8juhyO1g3orjDoDy1peas5w/gPb6jIheVh5PRMLl8fXNJgr+2E4P80aECJ3M cmJFIzgFsDbXGnZkA3kgHSdxEIzOXdSHwggQQ7UVQx0RR57S9H/BjuM/Vk4nbokWb9iXZu gRGGvWkhH0bNzDxt1nEDZKrIB9Rt4c3OCyqqsTdIBKHCQNeD2PxRF9Oi28t5gKqmq7A/hr p1R7oj7t5o4tkoDgbkVaAlpSsGQvzDQivPfoogyjZaMks3Yovngfi0Yl2AQ9OTGQM5/f0K BASP77fTO1cykUTCmACYtLBQKg8VN458AunNIKqqTHrmYhGjoeH8FZPdKPSEUA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696901582; a=rsa-sha256; cv=none; b=BhoQVw1U/VvawoL/jQBMEydihw0zECTk80004v+aA83SQO5dtF3zxDU0ilQlI8k2PLFmCG 2gOLD36kiQBCesocDDETLMtLNY93bMFVqbApfYjYGHGRPb8GWYrvzk+Z33htofLFGG7PsU zcTfsJ3e7eNsBX0O6WW0B3OlbGs/cGPy0pvWd5lJk+FrIiqn5cy0Egr8J2FH5yuj+DVIkJ uXLtP3muZ7Wxy92dcJLdS2vz0H4Yhbhds81mLPF+xsA19FL9jxnYdOoMah4H6UTN6QS+vT 9k9EfIKr4pwusdB0v7OhUf9qNe9euPY9tu1gTQV64WV7UxX/acxfDmeyWDTfUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="mS+/+XDp"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qq1c4-0001Yx-Fw; Mon, 09 Oct 2023 21:32:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qq1c2-0001Xa-MY for guix-patches@gnu.org; Mon, 09 Oct 2023 21:32:42 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qq1c2-0002YK-ER for guix-patches@gnu.org; Mon, 09 Oct 2023 21:32:42 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qq1cM-0006yt-Ku for guix-patches@gnu.org; Mon, 09 Oct 2023 21:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66426] [PATCH 00/65] Export %default-gnu-imported-modules and %default-gnu-modules. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 10 Oct 2023 01:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66426 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Bruno Victal , 66426@debbugs.gnu.org Received: via spool by 66426-submit@debbugs.gnu.org id=B66426.169690153826776 (code B ref 66426); Tue, 10 Oct 2023 01:33:02 +0000 Received: (at 66426) by debbugs.gnu.org; 10 Oct 2023 01:32:18 +0000 Received: from localhost ([127.0.0.1]:33680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qq1bb-0006xj-Fq for submit@debbugs.gnu.org; Mon, 09 Oct 2023 21:32:18 -0400 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]:60916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qq1bV-0006xS-RJ for 66426@debbugs.gnu.org; Mon, 09 Oct 2023 21:32:14 -0400 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-65cff6a6878so29524576d6.1 for <66426@debbugs.gnu.org>; Mon, 09 Oct 2023 18:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696901503; x=1697506303; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J7lIkAuAqEGrkKnXm8WvCzOQxbcaGTSrXNUnbsfNdr0=; b=mS+/+XDpFjGFOARAXn8HZJar9JMBPT1C5tn9fjelDjVID26Heul5Q7XXhvje8ZoBgF H5KcXq1Ii23U/mSGWn627xpZ1i49Mxt6PlwchY6Jb6709oJAETzACInDmV68DaK7zSbr 9ifAGkg3pvPcCcBF3bzYN/ctlKi/S/6/lLIsJMA6Pfhqb9LxijH62sI6LY97pIAT1AFY sWOY7JYG1JsaIEw3cReH1oUfnIlZH5OmVTqZ0u57Qo//ZggWbBUVnHwovfOcNQ/3HtWq CCIAIcb0wrFC4Vo/jTarXih6u/rnF6MlvEjA6K9gAKWk9Zzcli/pPS5jHOoxoC86K4fU 8dMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696901503; x=1697506303; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J7lIkAuAqEGrkKnXm8WvCzOQxbcaGTSrXNUnbsfNdr0=; b=RvAPiEE6yQtIcL1J7D5yWjtooZFMpRHYPglIPWmYlBUHOmoH9FAt6SN8gun/xl8Dp1 2jN7vLND9tZQ3Vh7ya6hRXf7QAfuIOSabxquoSTHgwXl06zOm+ck2c9FO6rZWGtCKyh6 /DWRl6CH1o9LZzvFfL7snulK4zPCUAzyunkx7Y0AKSuKhOtGPK3ZuczcIApJpnozpS6t fRlAEJqv29QIn4aySA1rGL53Eok9a7H/xzj/UEeaXU0QbHLfwK8RRc+AalDtjx2HGuPN AvH8BnblhAdwwjUthoEN2z3dtHtklfl2i51pGPl9VRpYVW9YgmUV85Sx2bYvVo6eDPQH QCHA== X-Gm-Message-State: AOJu0YwIRZa5kHzM441op8AldyEf2i29O6rA3UT1zrIdules2oQu3vey JKY+0avfBuNs0fJTAGtQ/SU= X-Google-Smtp-Source: AGHT+IHFzGwSM9KLFsqWGTUx4+1ro0BJZxauItyUK6z8zZUS1GD6q5n8CZK4hsDbl0NDBm6dUVNcYg== X-Received: by 2002:a0c:b298:0:b0:658:c75c:1946 with SMTP id r24-20020a0cb298000000b00658c75c1946mr15166292qve.52.1696901502942; Mon, 09 Oct 2023 18:31:42 -0700 (PDT) Received: from hurd (dsl-10-149-16.b2b2c.ca. [72.10.149.16]) by smtp.gmail.com with ESMTPSA id x19-20020a0cb213000000b00656e2464719sm4362251qvd.92.2023.10.09.18.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 18:31:42 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <2e6bfb0e40fddb7f0df045aa3b234c1cf45494cf.camel@gmail.com> (Liliana Marie Prikler's message of "Mon, 09 Oct 2023 21:45:59 +0200") References: <87y1gb8u73.fsf@gmail.com> <2e6bfb0e40fddb7f0df045aa3b234c1cf45494cf.camel@gmail.com> Date: Mon, 09 Oct 2023 21:31:41 -0400 Message-ID: <87fs2j8dqa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.11 X-Spam-Score: -5.11 X-Migadu-Queue-Id: ACF0F76C0D X-TUID: 3+VATAN9uN8Q Hi Liliana, Liliana Marie Prikler writes: > Am Montag, dem 09.10.2023 um 15:36 -0400 schrieb Maxim Cournoyer: >> Hello, >>=20 >> Liliana Marie Prikler writes: >>=20 >> > Am Montag, dem 09.10.2023 um 12:33 -0400 schrieb Maxim Cournoyer: >> > > This series introduces default variable bindings for the default >> > > gnu-build-system IMPORTED-MODULES and MODULES values.=C2=A0 The lack >> > > of a %default-gnu-modules caused enough confusion, as made >> > > apparent by this series. >> > If we're going to do this anyway, let's go big: add modules and >> > imported-modules to the fields of build-system and allow users to >> > use that. >>=20 >> I don't understand; what would that look like in practice?=C2=A0 Isn't >> this already how it works?=C2=A0 Build systems have #:modules and >> #:imported-modules arguments, which are provided via the 'arguments' >> field of a package. > Well, no. The build-system record currently contains a name, > description and lowering procedure, but no "immediately helpful" data > for package writers. > >> > Perhaps also add short-hands so that (default-modules gnu) >> > expands to (build-system-modules gnu-build-system) and likewise for >> > imported-modules. >>=20 >> Ah!=C2=A0 I understand the idea now.=C2=A0 It feels a bit strange to me = to >> attach such metadata to the build-system record itself though.=C2=A0 At >> any rate, we could discuss this separately and do it in a future >> iteration, perhaps? >> The series posted here already has value in itself, and if we ever go >> to attach this information to build system objects instead of plain >> variables, we could use sed to adjust the code base. >>=20 >> What do yo think? > Hmm, at the very least I'd like to bikeshed the variable names, hence > my suggestion to encode it into the build system itself, which would > allow any name locally. %default-anything reads weird to me, plus it's > a mouthful for imported modules. It seems conventional to me: we have %default-subtitute-urls, %default-channels, %default-include (thousands of matches for '%default-' upon grepping). > WDYT about %gnu-build-modules and %gnu-build-system-modules, where > %gnu-build-system-modules keeps its current intent for being imported? > Alternatively we could also rename it to %gnu-build-imported-modules > with a deprecated alias. People have been adding %gnu-build-system-modules to #:modules erroneously. Not renaming that would ensure this keeps happening. Having 'imported-modules' in the name seems like it'd make things a bit easier to remember; thus, I think the proposed naming is adequate? --=20 Thanks, Maxim