From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oIFQLqFCLWXAEwEAG6o9tA:P1 (envelope-from ) for ; Mon, 16 Oct 2023 16:03:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oIFQLqFCLWXAEwEAG6o9tA (envelope-from ) for ; Mon, 16 Oct 2023 16:03:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 21D5861A46 for ; Mon, 16 Oct 2023 16:03:02 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ScN8m2rd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697464982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8CEcurRHneGOxycmS99b2LowP5HOdfWaoCykFc0SO+U=; b=t4R3shQ/LIITx8h9Os9umUZDstvddjrD71Fk42PMxmrbYFQevUKxaPhoW5KYaYMHJ7Sk2o x0IlWpbpJJ5FP5Ut+/OzgyzakLHAmFDNYBKKBmD95UzgZk+0W7Y6oMML6as+5jVemEBNjU hX0CSwwbW888WguDyGJtIzBBOZEcJ19WlFg/DYOsPvhtEiZaH2DQ0/FJcM210yz7oo5Y/8 /IMKkeIwyoVJAfnn1KqxBIr19dqvgrMP1j3LUc4TbVJUeASB8IWaaZV3HLF2lK5nGbzxjE ntiXFCwwC+kif+7gDDDRXYv4tMp09g1ex0BLKpCNMPYyGeCT0IYPuUrTK34UHQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697464982; a=rsa-sha256; cv=none; b=mRDVTFCEFSjNnIIf8qMUlvScS0MkcrAcZR1t3+8XK4U4EU4cQodwMbsb+/ShaXizKUSy6z M7nChZuL38EM+HamDLdKo9kiXedaCeHOvyCmMG/Hk6VdKvbqcO0t+E9vHLUWkW/Ji5ezRK xJLb0KTCWLlGefQ7JPOHQ5Xx/NYChxr0dOCD+cqKyE/9NiCW7Z9mtUuPox43Ylifmpl224 6RZXdI7EcntHrmKAHYOXqYnC3fOwvgW+Sj45A+OPGYRb+AvdQdyQU1DuvtTkCnXsHL3FgW o0OQLGP9qzuvEo1LmElqdyX3C6M+QrPWhoXafEyOu/BjTusxZiczpS9RYMVJEg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ScN8m2rd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsOB8-0008Q9-Ah; Mon, 16 Oct 2023 10:02:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsOB3-0008Pe-Oh for guix-patches@gnu.org; Mon, 16 Oct 2023 10:02:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qsOB3-0007qu-GR for guix-patches@gnu.org; Mon, 16 Oct 2023 10:02:37 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qsOBS-0002pw-98 for guix-patches@gnu.org; Mon, 16 Oct 2023 10:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2023 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169746496710880 (code B ref 66436); Mon, 16 Oct 2023 14:03:02 +0000 Received: (at 66436) by debbugs.gnu.org; 16 Oct 2023 14:02:47 +0000 Received: from localhost ([127.0.0.1]:57439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsOBD-0002pQ-3t for submit@debbugs.gnu.org; Mon, 16 Oct 2023 10:02:47 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:61750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsOBA-0002pD-Ky for 66436@debbugs.gnu.org; Mon, 16 Oct 2023 10:02:45 -0400 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7742be66bd3so330079585a.3 for <66436@debbugs.gnu.org>; Mon, 16 Oct 2023 07:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697464934; x=1698069734; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8CEcurRHneGOxycmS99b2LowP5HOdfWaoCykFc0SO+U=; b=ScN8m2rdFpa7D8wzr67L9hw00VV9AzjoGJvFgx2MRM0gKgvhEKXsZ0Yu9rwXKg2pHH k4LsGsUrM3d5CVTxIyZhp+iMHe9SFjwQ4vbY8Tt7tum3X8okGBa4OQzf3IBVG7vz6Zlp /jRcGUSgPt2cB4gI8/eJrSHlyXAlfDj5mkDemAETOKrCA1KP2IzDVgWrmoNKrSuCH/wX 4AfxMhoxvgum93XHFIm94yN/pw1AjWwRVGFDbEBiFSUzcGpITrvdcbNR0Ra3oIrnAeJF lG+pYxH9B0X5knA/swVrB3KD0/j1AEzIjJh1bo4RI99Zjnc2c0/0L5IJEYF1i7OB61Vx xlmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697464934; x=1698069734; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8CEcurRHneGOxycmS99b2LowP5HOdfWaoCykFc0SO+U=; b=sbwN/W5Hr4o28bSKdRw6UQaiXdMQ2rxGaR8CXTnAMhZpXHSxqB7UN7zZaTPh+w9Rzy 0JDtqaRWCarnUJRtzPGa1TWiP2fyFvgvuyBeGjmbrpcUoE7HJ+9GTY+wdBQcg7fYl6x5 pgFxJ8526snkDlIw2D2I8lYeSbcQ/8oqyrWUHsN2xZeshfVYMaSUkmehclDOMnNrIzYm FsSCwwuvZe/Bd5KHHRMy7DsMFlTfGLgcdHWpNjtNPjF+rp8/d86GXUw1jk5hAjKAbBXW mBC+77gbaMp+QB6zYdUNBHWCBhq5YMS41yU+EcopOwLqvOQSUabYe6xyWm2UsGbdp6vU 62LA== X-Gm-Message-State: AOJu0YzAzjErVTTFh9glDe708KvdSDj2Vp0tWtAEo0LLVfa4xPRRXJVW SI6t9jkRaAGeHQ2Mu6sNXV8= X-Google-Smtp-Source: AGHT+IFQWfeJJe7zEfR3g3yKNm0KdPTEZgS7bct+Z1Qoli1lhmXOEhu0LV3wY5EHZO0JEQJ6ZgvyUQ== X-Received: by 2002:a05:620a:4008:b0:775:92ac:a0af with SMTP id h8-20020a05620a400800b0077592aca0afmr42423715qko.13.1697464934033; Mon, 16 Oct 2023 07:02:14 -0700 (PDT) Received: from hurd (dsl-10-149-74.b2b2c.ca. [72.10.149.74]) by smtp.gmail.com with ESMTPSA id w9-20020ae9e509000000b0076d08d5f93asm2997162qkf.60.2023.10.16.07.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 07:02:13 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87jzroyzuk.fsf@jpoiret.xyz> (Josselin Poiret's message of "Sun, 15 Oct 2023 11:55:15 +0200") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87jzroyzuk.fsf@jpoiret.xyz> Date: Mon, 16 Oct 2023 10:02:12 -0400 Message-ID: <87fs2azmvv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 3.53 X-Migadu-Queue-Id: 21D5861A46 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 3.53 X-TUID: iy/J4Nz4hwl0 Hello, Josselin Poiret writes: > Hi Maxim, > > Maxim Cournoyer writes: > >> +@cindex LGTM, Looks Good To Me >> +When you deem the proposed change adequate and ready for inclusion >> +within Guix, the following well understood/codified @acronym{LGTM, Looks >> +Good To Me} phrases should be used to sign off as a reviewer, meaning >> +you have reviewed the change and that it looks good to you: >> + >> +@itemize >> +@item >> +If the @emph{whole} series (containing multiple commits) looks good to >> +you, reply with a @samp{This series LGTM!} to the cover page if it has >> +one, or to the last patch of the series otherwise. >> + >> +@item >> +If you instead want to mark a @emph{single commit} as reviewed (but not >> +the whole series), simply reply with @samp{LGTM!} to that commit >> +message. >> +@end itemize > > Some mbox -> patches tools (like b4) are able to automatically apply > trailers like "Reviewed-by: some ident <...>" found as replies to patch > series [1]. I also like the very clear meaning of it: there's no way > you would type this without meaning "Yes, I officially vouch that this > patch series has been reviewed by me". Maybe this could be codified > here? Reading about it at , it seems 'b4 -t' is about adding the 'Review-by' git trailers found in replies to *cover letters*, and inserting them on each commit of the series when applied. Do you use such a tool when applying patches working with Guix review? I'm not too fond of adding tool-specific bits to the otherwise tool-agnostic section above, but perhaps we could add a note or something. -- Thanks, Maxim