From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 2N3uKDesR2VQAgAA9RJhRA:P1 (envelope-from ) for ; Sun, 05 Nov 2023 15:52:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2N3uKDesR2VQAgAA9RJhRA (envelope-from ) for ; Sun, 05 Nov 2023 15:52:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 96235166D0 for ; Sun, 5 Nov 2023 15:52:39 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=aBXQ8MG9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699195959; a=rsa-sha256; cv=none; b=N3xExw/Loun3ZjEXSd/LZMD6JDWKmPLUDISgGx5Pd5tN0w/nlBUXkT/ZNfM0XXzVYqNFkD PgXBmAbSkyrlKJ5W1P+xmd3ilEC34zKwLIwRRNZHNs0ZVftaTTF/meqG+ojxNC1vSpUbS8 z9PX6Y+PR28Dpwix9RPjTRS+MkNuZHOqF7m+aO7t7EilfcdqvE4TyMWkcXynj+RFHCGJN2 utthqOI/WRbgh05oAob7CimeP82KO8VF1svImef/aqc6SpZU3XGUMOwCAAhwVgr0PP5IJu KZSAYXcZUkDK4Rp1wFRp+fgazcqOob0Kht9e06f9YDqg+CsXIGwsa1WCJRB1Kw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=aBXQ8MG9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699195959; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LWIxKQd0cmCc6MLnw8VIjZQbaiU9rCujCXzAPKkrIFU=; b=VMuIqH1KokaN1cNY8e8d9oHg7JpG6DMw6yHJoffsMsXKCaecxhH/2TDOrZkLDZkGEv5u/0 ka/oVrhaIlj+/dlDb0lghgXK/Q4TFc5sxGECQ0Vs10rvhg2x+9QFHSwj+JyP1ZbCZJh9dF 63jr8cdIVzWc40GFwdwJyvmlYAkkyt/rqV+QNjsQFkUHAOaFl3URpmQt8VxweefqO3yFAC SuLtosBVdwW2iZozm/K4zzVTGWpZpWQiMGX0OAYXd5zrnEudBSFPf8CIv5L/ZW0igItx6r 6YLgOzz4cgflj+XndeZQ3FZC6qLd5m89NzP52iCkng9Z/DeYhpT1MRjsWWsG6g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzeUF-0001pW-6i; Sun, 05 Nov 2023 09:52:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzeUD-0001p9-7q for guix-patches@gnu.org; Sun, 05 Nov 2023 09:52:25 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzeUC-00058P-VY for guix-patches@gnu.org; Sun, 05 Nov 2023 09:52:24 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzeUn-0005DG-Nh for guix-patches@gnu.org; Sun, 05 Nov 2023 09:53:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v3] doc: Add some guidelines for reviewing. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Nov 2023 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, dev@jpoiret.xyz, zimon.toutoune@gmail.com Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169919594119986 (code B ref 66436); Sun, 05 Nov 2023 14:53:01 +0000 Received: (at 66436) by debbugs.gnu.org; 5 Nov 2023 14:52:21 +0000 Received: from localhost ([127.0.0.1]:36416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzeU9-0005CI-AJ for submit@debbugs.gnu.org; Sun, 05 Nov 2023 09:52:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzeU7-0005C4-9r for 66436@debbugs.gnu.org; Sun, 05 Nov 2023 09:52:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzeTQ-00054y-Jn; Sun, 05 Nov 2023 09:51:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=LWIxKQd0cmCc6MLnw8VIjZQbaiU9rCujCXzAPKkrIFU=; b=aBXQ8MG9WU5sudDGyjAX lxOk/2+kTKY5SOROUsVOVpk3E8fy/4oZslO2wNVmCGQ0Rz0aJTNNXg0KyqtxLdZO+Oi9Fd04jjVqm G7jlcqVfuLu4Tep/RSpJJP8fFkjGUbWbzC+ax8ujDUaJ467gu28Muh6oV90KX+HCuMUr43wU7v3Vd 3nj7yGUMkObyF1MVrcrE8B1XVTwMQqXgBalFCbHRBIViwj7KnSMnICGkJnkoZkL5RRjdOtCqzHydG gMFhVUa4sGy19dqiSZQl7qxlhiJEGBIqfWhKiL9o9C4JruaPYwNAbY4Yds1eYHKQFK1y3dicA0vJk ck1lqic4LMH6xA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Maxim Cournoyer's message of "Wed, 1 Nov 2023 15:23:23 -0400") References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 Brumaire an 232 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Dindon X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 05 Nov 2023 15:51:32 +0100 Message-ID: <87fs1k1cej.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 96235166D0 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.29 X-Spam-Score: -5.29 X-TUID: 8Okv+EuKWH+f Hello, Maxim Cournoyer skribis: > * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: New > section. > (Debbugs Usertags): Expound with Emacs Debbugs information and document t= he > 'reviewed-looks-good' usertag. > > Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b > --- > > Changes in v3: > - Replace LGTM with Reviewed-by Git tag > - Add b4 config > - Link to the Submitting Patches section for check list > - Fuse further suggestions by both Ludovic and Simon Could you mention the b4 change in the commit log? Otherwise LGTM! > +[b4] > + attestation-check-dkim =3D off > + attestation-policy =3D off > + linkmask =3D https://yhetil.org/guix/%s > + linktrailermask =3D https://yhetil.org/guix/%s > + midmask =3D https://yhetil.org/guix/%s Really cool to have the b4 workflow documented and a default config in place! Ludo=E2=80=99.