From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id CDqWOy42oWVjlgAAkFu2QA (envelope-from ) for ; Fri, 12 Jan 2024 13:53:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YAbKOC42oWXXQQAA62LTzQ (envelope-from ) for ; Fri, 12 Jan 2024 13:53:02 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=WZVXWAyO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705063982; a=rsa-sha256; cv=none; b=ODEZRpZYApgccb7lhUr5H8g7Zfb+sOqOd+IsgAyfzexE+lQQo26LWda65ocgxaSEGC22h5 dm1IYBHyfZOg186CMjEu76FwIhG0sQvsh2yE7NGEdwpmL5UYeDvi5tUgHWBFjtArwYfXx5 BO1NGP1nxBvSv1w8A3GWOAzDh0H152+gSLA9n6YsGCG1VqJ+pMCGnipL9LsEODRWGY3nA/ swgPhkhjBL/N2+FMiKRzfUxWiNNQ/CqfEpQ+VebxLwUVveFVu8ph5W5MOXmjhpTtgfkqSp UrIN35t4TBcHqeUdzX/dK1U87UHCgyt7gbSlRGHn+Ls2D9ziPgn8IIIW7bzxmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=WZVXWAyO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705063982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oGh5+ImILUt/53jfdo8eFv80wgF4Be882afc0O8DkZM=; b=o2Sux5HQ94uKbbcl2OtJgiRSHKVaPIygJW9uHweZS0ZBadmiuVaywArVm+LTOdSEDoWfTF gSIosb1mSYFA109zi1PKpvYe8SMCjCAahddcngY2s1wSSLappIffDEWp+SHLRDeppO5bKB lv09yhK6nCOd1Xk/fBGIX7K+/y5Bz0sQeoWuoMiReBr4fc1++/HMNijGGmHiiDGPzwv2Hs yeAGHe9ymonvwQqxTgUpEVO/9tEQfA5TuZ4FIM+V83V5+75/WjR8D1EbMDSI/Yd05+pbGJ 6f2sFZSKyKEUdFHcjpnSwK6bBAulKgttmwrHx8VpPKbKTbSJCt1dxpDtUD1bMg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D51FA3363A for ; Fri, 12 Jan 2024 13:53:02 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOH1M-0005Zo-7P; Fri, 12 Jan 2024 07:52:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOH14-0005Ug-9T for guix-patches@gnu.org; Fri, 12 Jan 2024 07:52:06 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOH14-0004jO-04 for guix-patches@gnu.org; Fri, 12 Jan 2024 07:52:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOH11-0004Dw-Tu for guix-patches@gnu.org; Fri, 12 Jan 2024 07:52:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66592] [PATCH v3] scripts: archive: Check compatibility of command line options. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Jan 2024 12:52:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66592 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines , 66592@debbugs.gnu.org Received: via spool by 66592-submit@debbugs.gnu.org id=B66592.170506388916134 (code B ref 66592); Fri, 12 Jan 2024 12:52:03 +0000 Received: (at 66592) by debbugs.gnu.org; 12 Jan 2024 12:51:29 +0000 Received: from localhost ([127.0.0.1]:35156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOH0S-0004C4-QN for submit@debbugs.gnu.org; Fri, 12 Jan 2024 07:51:29 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:38931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOH0M-0004AJ-0s for 66592@debbugs.gnu.org; Fri, 12 Jan 2024 07:51:22 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-33686565c35so1131866f8f.0 for <66592@debbugs.gnu.org>; Fri, 12 Jan 2024 04:51:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705063878; x=1705668678; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=oGh5+ImILUt/53jfdo8eFv80wgF4Be882afc0O8DkZM=; b=WZVXWAyOQot+yH99KWueyouIUSXzcOkKFXzZMmsWFXT8toECZ339SBJr4s3uuEesCh CdSWJSEMOdA6yaKZvy83ARbSPBk2aH5t1c9T5FBxcQLtPRDDPxutrgyFWWswP38JB4uN qrH2VE607ufLAAHSjncjP5G6VoWYy7XPq8jxuVI1FmKuECxpQWN11IoYMxZTa/+2pwuf f5s44Xg7VuPsXDDmf4Scx4hLRjjOhg1yjAABHWF6AtuIybFjVxqhZCKqIbWjkUDh9EgZ dk1undLMcfvEBDqs+8lwPc6iN3dFOvUa4Uf01z1iicTmo12Yw7FfniM+PvohcDUvmdp9 qIew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705063878; x=1705668678; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oGh5+ImILUt/53jfdo8eFv80wgF4Be882afc0O8DkZM=; b=jQOtbYPWA1WDDopgu1uW6V6IITn6WU06bOZh0qdzUBOubOoj4KHFQPPx7LgbKb3qNv N4b8u/1ZQz+y2DNWowvabzjiI/GQkEgV0dH7zlwMgVDbAFD8G4e3+WvxaTmYQpihqrro FPYSoRfEdGD9f+zkkrZ4dMcmez/VH2V0JpSRBDaYKS8xt+oiK73Ej2IXG1Qe8aZfyLmu qjPp7nBhqqU6M1rsVOGz6YHoFK4IQxp1jcTQ4l6qnioNasvhWO2+NN1G59wwjSVdtBaC PY0Na28B+UEzGoVs7ZFkosMzJN9IVSgJNm2c4rxWLKvJyJJYbHsz5nsH9XnGASXWSuZZ A/xQ== X-Gm-Message-State: AOJu0YzmG30untezq8H7+TElJekhwXubtokvVI5Tp1J9pw8u80vj1MwP SB64CUePmxzLARk/ZfT3yqdGw6j9k9k= X-Google-Smtp-Source: AGHT+IG/DErG1lJLwYIqSH8y9/xkXxmxU3q8IglJUTJ4t1a8Q9LEirp4mIdj8BDc4Fj/8PMB7p/rIw== X-Received: by 2002:a05:6000:1c1:b0:337:476f:9964 with SMTP id t1-20020a05600001c100b00337476f9964mr1505785wrx.3.1705063878249; Fri, 12 Jan 2024 04:51:18 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id o12-20020a5d474c000000b00336aac53e75sm3790474wrs.97.2024.01.12.04.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 04:51:18 -0800 (PST) From: Simon Tournier In-Reply-To: <87r0k1r44u.fsf@gmail.com> References: <9f5c22f6fe1f4feba5d3561cef011b0c3f55df06.1701340510.git.zimon.toutoune@gmail.com> <87r0k1r44u.fsf@gmail.com> Date: Fri, 12 Jan 2024 11:16:38 +0100 Message-ID: <87frz2yhyx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -2.28 X-Spam-Score: -2.28 X-Migadu-Queue-Id: D51FA3363A X-TUID: K5h5yRyLaAo6 Hi Maxim, On Mon, 04 Dec 2023 at 17:31, Maxim Cournoyer w= rote: >> + (define* (compatible-option options #:key actions) >> + "Return the OPTIONS if it is compatible with the list of ACTIONS." > > Sorry for not mentioning this in my first review, but re-reading this > code, I think it should be named like: (check-compatibility options > actions). There's no point making actions an optional argument since > the only point of using this procedure is when you have actions to check > compatibility with, right? Well, the point was not about an optional argument but about a key argument =E2=80=93 I find easier at call-location. I do not know. (BTW, I have not raised the issue for other commands, but this =E2=80=99check-compatibility=E2=80=99 could be also applied. Let as an exe= rcise for future potential contributor. ;-)) > Would you mind sending a v4 with the above suggestion? Then I think > we'd be good. I will. Cheers, simon