From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 8OekLaXpTWaFxgAAe85BDQ:P1 (envelope-from ) for ; Wed, 22 May 2024 14:48:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8OekLaXpTWaFxgAAe85BDQ (envelope-from ) for ; Wed, 22 May 2024 14:48:37 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=j4Pn+Z3i; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716382117; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=afMCZI8oM3k56/P27G4uBR138cXIpozQ5cf05ckaybo=; b=O9BS0yIJMkvPBNso5/EjrNbo1t3d+h7sCMkm9jCcGC9uQn8tqhWxZ363X51iireIQ7TROI kXP6Sm25TiBWLNVI5zhplZb2Xx07Lvd+SJX5Xij1AnhaL1lLTlmFyb4/fjRRgSjHVJFODj 7nzr3tTTAp2NgmlW5oWtX5bn5ZX03bhGKZlD8Ugtp3i9iXU2Lz/pnpvGyNPfVxn4xAdLOM slrzXwOZQ8s/KZ4YIVhGivqu7JFd0YxFlY+QNFn3qMB1fl5LZzTLXpORdTkgW3nFTchDRO BfPcLD0lLgKYoUFOZGv2i8jXXh7yxhXIzzrulaQJS7YESZPriV6pOVF39Jzs2g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716382117; a=rsa-sha256; cv=none; b=Dqc0MwECL/nfFlEiXqjKuGQ+zZJulwUHTbUsjyHrZoPl83HuiGiDVycxsIOSrqKOswnPjA TAoFhEU/CPvP78LOeU/98esdjsJsxLa2LGB2lU7qIW62Bq8lw5mzkl8d7lL6dVKgLlu0cL 0IADN+vH6kiHRWSAOk+JVWm4JStozZmBGYzpuOuDbezuShrH8uAyw10Ul9gyCX7j0qzPUM VLJpydK82cJY++dLCGsjPbpnggQiy17AkoSkkGJ0uWFuzo7paJ9MWv7TiiVtqgOOH2C4Y7 kg+vsjPMQHA3qq03DVOZs6yYruAMswQoMBdFYZ+HtYy+kYWyltwM9YYGxuRXWA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=j4Pn+Z3i; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 30F4264AD9 for ; Wed, 22 May 2024 14:48:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9l8Q-0004rT-6g; Wed, 22 May 2024 08:31:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9l8O-0004qe-QZ for guix-patches@gnu.org; Wed, 22 May 2024 08:31:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9l8O-0005rC-HM for guix-patches@gnu.org; Wed, 22 May 2024 08:31:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9l8U-0002CI-7a for guix-patches@gnu.org; Wed, 22 May 2024 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 May 2024 12:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71022 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Simon Tournier , Vagrant Cascadian , Richard Sent , 71022@debbugs.gnu.org, Efraim Flashner , Florian Pelz , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Matthew Trzcinski , Janneke Nieuwenhuizen Received: via spool by 71022-submit@debbugs.gnu.org id=B71022.17163810788436 (code B ref 71022); Wed, 22 May 2024 12:32:02 +0000 Received: (at 71022) by debbugs.gnu.org; 22 May 2024 12:31:18 +0000 Received: from localhost ([127.0.0.1]:55665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9l7m-0002C0-BV for submit@debbugs.gnu.org; Wed, 22 May 2024 08:31:18 -0400 Received: from mail-yw1-f171.google.com ([209.85.128.171]:52429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9l7j-0002Bs-SQ for 71022@debbugs.gnu.org; Wed, 22 May 2024 08:31:16 -0400 Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-627788ce780so8237477b3.0 for <71022@debbugs.gnu.org>; Wed, 22 May 2024 05:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716381004; x=1716985804; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=afMCZI8oM3k56/P27G4uBR138cXIpozQ5cf05ckaybo=; b=j4Pn+Z3iG1ltITPQ6kTgtKsGHsviKuOB9qxxyb9ewcnKkaXBFYfvdya6I9tNBLrjOl dh0w2AGwVuSWM8LzrMO4Q+SY9/G1ziZJpPYe+q8BHvjUBo3vaa0IIiMZ6PKbFN4XmDaB LKF5NN9S5Iuk8Qu+Fbu3VQXO2Wg9yGZ57wtdwpi00lV7QJjfmKCDwQGgUUSpfadU4LdZ obp31fBuTB0Gm855Ieb5gLWQrmvt3+IKd+V6wHsjT905HyHg93ZrWGh+Ro5Y0shaoksp LPGP7ibK23OZ8GZ9Gl2vtYqzgpGgost3Av6bCw1PX3joj9PfvyC6vPO5AY7Gbtnol/jr YQyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716381004; x=1716985804; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=afMCZI8oM3k56/P27G4uBR138cXIpozQ5cf05ckaybo=; b=hR3y6aObuVu9Bh/y/sPaiBMGXX+ny/ilFQ53QVVphyyckWCjnDMl3J+4SnjGr5vvaW DVoUGeReKh5jjMsUn+Pl+siyhmGlk/UnPQ6JlWBQK+0Mi+jURx2YdU7ZpOiI/2fSsr1p BKrc3daR2BmEzpVtnKlY27O1ObFEB75czd/wqS9tYm/r9+/rX4KEAlcduHtw8BJB8QcL Cf7HVHz/yLS5KID4Oyv/LWnslogcUnWDuwDtghUI8Ml2aPKp0KRFU8U7P3QUlv2ZKAQc Kr4wareX/Yc07GQJvWt99Ohi4hgXfuom5w+rcj/Gn15l3HDz1/JqsQPvDbrl+g+irGc2 QAfg== X-Gm-Message-State: AOJu0Yx5wShwssCUJWbjrH+KFqrA0UzqzegGhNH1TvG27kRRiXV/NFP+ 1Iz6IvHRFRlgwqJi0QhLZgrH2qONRQDtNmyPrLmAufPvIUU+fSIi X-Google-Smtp-Source: AGHT+IHer5QeQDZINeUSSgjSVE96txYTISQNx9ImegfOWawG2Wad1MemLwjL6YgUV3PUK4SsXbsV1w== X-Received: by 2002:a05:6902:2191:b0:de6:4ff:3167 with SMTP id 3f1490d57ef6-df4e0dfa469mr2250587276.57.1716381003981; Wed, 22 May 2024 05:30:03 -0700 (PDT) Received: from hurd (dsl-148-133.b2b2c.ca. [66.158.148.133]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43e1c32e8basm125267081cf.36.2024.05.22.05.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 05:30:03 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87ttit3n11.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 19 May 2024 16:16:10 +0200") References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> <87ttit3n11.fsf@gnu.org> Date: Wed, 22 May 2024 08:30:01 -0400 Message-ID: <87frua3u7q.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.76 X-Spam-Score: -0.76 X-Migadu-Queue-Id: 30F4264AD9 X-Migadu-Scanner: mx11.migadu.com X-TUID: MZFTPIl76G2C Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> The Guix standard configuration uses a localstatedir of /var and a sysco= nfdir >> of /etc. To ease things for everyone, make the default values match that >> standard expected configuration. See >> fo= r a >> related discussion. >> >> * configure.ac: Default $prefix to '' unless already set. >> * doc/contributing.texi (Building from Git): Streamline doc. >> * doc/guix-cookbook.texi (Guix environment via direnv): Likewise. >> >> Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212 > > [...] > >> +dnl Set some sane default directory variables for use with the Guix. T= his >> +dnl also causes localstatedir to be /var and sysconfdir to be /etc. >> +test "$prefix" =3D NONE && prefix=3D > > Shouldn=E2=80=99t it read =E2=80=9Cprefix=3D/=E2=80=9D? This is what I went for originally, but it would cause this error: --8<---------------cut here---------------start------------->8--- configure: error: chosen localstatedir '//var' does not match that of the e= xisting installation '/var' Installing may corrupt /gnu/store! Use './configure --localstatedir=3D/var'. --8<---------------cut here---------------end--------------->8--- So it seems Autoconf's generated configure script expects --prefix to *not* contain a trailing '/', which is the case for --prefix=3D/. > Might be good to check whether this breaks =E2=80=9Cmake distcheck=E2=80= =9D, so I > suppose it should be fine. Good suggestion; I just tested the target and the tarball was successfully generated. > Apart from that it LGTM. Thanks for this patch! Thanks for reviewing it! I'll send a v2, and wait for further comments, if any. --=20 Maxim