all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Sent <richard@freakingpenguin.com>
To: 71886@debbugs.gnu.org
Subject: bug#71886: Diffoscope test suite fails with openssh 9.8p1
Date: Mon, 01 Jul 2024 17:50:20 -0400	[thread overview]
Message-ID: <87frssdboj.fsf@freakingpenguin.com> (raw)

Hi all,

With Guix 6522f93ed098fa13f51f6d017035607e26237d31 diffoscope's test
suite fails. I'm reporting this here in case we want to try to implement
some kind of workaround in the meantime.

Diffoscope does not seem to have an upstream issue opened yet. I tried
reporting it but was blocked by the classic "yet another gitlab account
that needs manual approval" problem. It's possible this problem is
unique to Guix though.

I tried upgrading Guix's Diffoscope to 271 and encountered the same
issue.

--8<---------------cut here---------------start------------->8---
=================================== FAILURES ===================================
__________________________________ test_diff ___________________________________

differences = []

    @skip_unless_tool_is_at_least("ssh-keygen", openssh_version, "6.9")
    def test_diff(differences):
        expected_diff = get_data("openssh_pub_key_expected_diff")
>       assert differences[0].unified_diff == expected_diff
E       IndexError: list index out of range

tests/comparators/test_openssh_pub_key.py:60: IndexError
__________________________ test_compare_non_existing ___________________________

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fffefd20190>
opensshpubkey1 = <<class 'abc.PublicKeyFile'> /tmp/guix-build-diffoscope-271.drv-0/source/tests/data/test_openssh_pub_key1.pub>

    @skip_unless_tools_exist("ssh-keygen")
    def test_compare_non_existing(monkeypatch, opensshpubkey1):
        monkeypatch.setattr(Config(), "new_file", True)
        difference = opensshpubkey1.compare(
            MissingFile("/nonexisting", opensshpubkey1)
        )
        assert difference.source2 == "/nonexisting"
>       assert len(difference.details) > 0
E       assert 0 > 0
E        +  where 0 = len([])
E        +    where [] = <Difference /tmp/guix-build-diffoscope-271.drv-0/source/tests/data/test_openssh_pub_key1.pub -- /nonexisting []>.details

tests/comparators/test_openssh_pub_key.py:70: AssertionError
--8<---------------cut here---------------end--------------->8---


-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.




             reply	other threads:[~2024-07-01 21:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 21:50 Richard Sent [this message]
2024-07-03 22:31 ` bug#71886: Diffoscope test suite fails with openssh 9.8p1 Richard Sent
2024-07-05  0:06 ` Kaelyn
2024-07-05 19:13   ` Vagrant Cascadian
2024-07-05 19:28     ` Vagrant Cascadian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frssdboj.fsf@freakingpenguin.com \
    --to=richard@freakingpenguin.com \
    --cc=71886@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.