From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp0.migadu.com ([2001:41d0:303:e16b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms13.migadu.com with LMTPS
	id MBDFHe040GbangAAqHPOHw:P1
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 29 Aug 2024 09:01:33 +0000
Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0.migadu.com with LMTPS
	id MBDFHe040GbangAAqHPOHw
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 29 Aug 2024 11:01:33 +0200
X-Envelope-To: larch@yhetil.org
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=o+1bHdLM;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JmttLIrM;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=gnu.org
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1724922093;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=PfyPV5Pt5ezeleVuwI3qMH8kpq12NgRaOAIdfRCrDtA=;
	b=sLOcMRnER4uiXYaLZc+l0AfsZ+v3g9zDsJEcyip9/6w+uEqVUNYhZmqvg/ca5gpwa/kayH
	lTc1lZqUBRCmG1MDDQIByLQqA5pHm7g3AWwaNFLTSSscJjrPdNEtoj0ASFcmbxa+Oe2cJ1
	dTlCzxJXoBmfFkjoIxNUDuaHpWkibVtOLo6ocMNuQaRoP8+Vz+OkcTPmPSu8vrsgI4TO/U
	nXBh4cWrTMo0vRk32STM8zPneH0K4YJIbwkC/RW974emNLQKP0rJzPyvZHq0/iax/OL69R
	vUO0cpVcnWJ0wjid7aYFZUq0m4hHj9zHHyVmJulgVzVRRyN71TJhQzG8LtGJuw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=o+1bHdLM;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JmttLIrM;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=gnu.org
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1724922093; a=rsa-sha256; cv=none;
	b=FQGEXPknX1+FHdwqm2jPIHGOpCyO+eco9TJtatbn9ST3ALgC9CHD8ICMMZY3XDVQuJHUTP
	nVp4mnlfnB4bVYIZ7BwFrQvn4Bdad8QiI1AlEkPgcwhPBZgJm+kz2r5CiqPf/xveBtwKli
	mP5ZcyJZIEZeLzYPXNwJKZ8YWG+6dB+sm+wiqcXZySXKYTQ6W6ih1OoEdCtNmhqr04jOam
	WcjQHZBV8mH4BH6Tq7tjF3djxJa8uDaKdznvDLEeIjPVs25GSJIJgufRm0PU6wM+au692W
	3mfdpd+qigF05VP19U7RI81f5bY3RyUdn7xpyecm3d9xhDZmvCnDRzmLzt0zig==
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 6090510D61
	for <larch@yhetil.org>; Thu, 29 Aug 2024 11:01:33 +0200 (CEST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1sjb1k-0002qh-Eh; Thu, 29 Aug 2024 05:01:12 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1sjb1f-0002qC-JY
 for guix-patches@gnu.org; Thu, 29 Aug 2024 05:01:10 -0400
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1sjb1e-0002B9-UC
 for guix-patches@gnu.org; Thu, 29 Aug 2024 05:01:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=debbugs.gnu.org; s=debbugs-gnu-org; 
 h=MIME-Version:Date:References:In-Reply-To:From:To:Subject;
 bh=PfyPV5Pt5ezeleVuwI3qMH8kpq12NgRaOAIdfRCrDtA=; 
 b=o+1bHdLM0uVU4uiOH/j4X/EB2JVMQvdc/z6Z9gv5v9UPZgACoB8blSeeDfyEvIFd0/f4TA8Lj42XWIPUB7AHU3egPH/vydJVMkb/cctMTO/l2h1ZA5BaoBBu0l3WPF1QAPRho/SXF8ThJqtUSbctMoBmp531mTZj4wy8fawbfGY4ZTAySiKu87jrh3qgC1WK0kAtx1/WTwxMTMBMKwBrMwPVEe327YBTNqobYOPF0JuxwBe7nYDpI3beETx+j302DkJtaKfC+N40+edBuznhatXdtNh6jQdOA5cwuK/KBA7xcX8OyEW/pl66r7tKF8LguYE3osClm8E+MYqGIKB0Ug==;
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1sjb2Y-00088i-0V
 for guix-patches@gnu.org; Thu, 29 Aug 2024 05:02:02 -0400
X-Loop: help-debbugs@gnu.org
Subject: [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Thu, 29 Aug 2024 09:02:01 +0000
Resent-Message-ID: <handler.72867.B72867.172492208931238@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 72867
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Nigko Yerden <nigko.yerden@gmail.com>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
 Simon Tournier <zimon.toutoune@gmail.com>, Mathieu Othacehe <othacehe@gnu.org>,
 Tobias Geerinckx-Rice <me@tobias.gr>, Christopher Baines <guix@cbaines.net>,
 72867@debbugs.gnu.org
Received: via spool by 72867-submit@debbugs.gnu.org id=B72867.172492208931238
 (code B ref 72867); Thu, 29 Aug 2024 09:02:01 +0000
Received: (at 72867) by debbugs.gnu.org; 29 Aug 2024 09:01:29 +0000
Received: from localhost ([127.0.0.1]:50402 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1sjb21-00087m-9T
 for submit@debbugs.gnu.org; Thu, 29 Aug 2024 05:01:29 -0400
Received: from eggs.gnu.org ([209.51.188.92]:54472)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@gnu.org>) id 1sjb1y-00087S-OP
 for 72867@debbugs.gnu.org; Thu, 29 Aug 2024 05:01:27 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1sjb0z-00028b-QC; Thu, 29 Aug 2024 05:00:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=PfyPV5Pt5ezeleVuwI3qMH8kpq12NgRaOAIdfRCrDtA=; b=JmttLIrM78Ee/iK2UdIJ
 hPKEf9KSepvrK1LcT3iqQJMbjaaxsbq50otcPiwZbtXcwspO6ua2UZjh7RbbZWvmFJ+fcMzHXoGfk
 umaJh6z2oZGT+1hDralDyrt9sFbicMkmGCgcQetaUaVGpQFQuDQ18baTiJ6laKfSUXqhrYK6EzvxR
 kf42TNC4r3ujupQtLqOCMJC4UIXNSM9lzcwwwBOFZ32ByOOiz2ifYXVtLnmKs2acCdbO44ZbsgjwV
 NdaWsCKIEdf5apSPmCiIlke3r+xYWU3Uou0F4K+k+Lho/55Q0Eb1M2/RV8/4WMOMYIoS6YXIX+NcK
 jRDhjO5oKCcnDQ==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
In-Reply-To: <e2bf165fc2905bcc8d33d23293eb3d31f3fbe4b8.1724911574.git.nigko.yerden@gmail.com>
 (Nigko Yerden's message of "Thu, 29 Aug 2024 11:06:14 +0500")
References: <e2bf165fc2905bcc8d33d23293eb3d31f3fbe4b8.1724911574.git.nigko.yerden@gmail.com>
Date: Thu, 29 Aug 2024 11:00:16 +0200
Message-ID: <87frqnhffj.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Country: US
X-Migadu-Flow: FLOW_IN
X-Migadu-Queue-Id: 6090510D61
X-Migadu-Scanner: mx13.migadu.com
X-Migadu-Spam-Score: -7.58
X-Spam-Score: -7.58
X-TUID: FzZt0CE/or3z

Hi Nigko,

Nigko Yerden <nigko.yerden@gmail.com> skribis:

> Fixes <https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00047.htm=
l>
>
> While the issue can be easily fixed (a one line change in 'absolute-dirna=
me')
> by changing 'current-source-directory' so that it always follows symlinks,
> such a change may break someone else's code. Instead, this patch keeps the
> original behavior of 'current-source-directory' macro and adds optional
> 'follow-symlinks?' argument to it.
>
> This patch is the result of collective work of
> Florian Pelz <pelzflorian@pelzflorian.de> and
> Nigko Yerden <nigko.yerden@gmail.com>

I haven=E2=80=99t read the thread above.  Could you come up with a test case
that shows the problem being fixed?  (That is, the test should fail when
run on current =E2=80=98master=E2=80=99.)

That will allow us to =E2=80=9Cformalize=E2=80=9D the issue and to make sur=
e it doesn=E2=80=99t
come back later.

Thanks for your work,
Ludo=E2=80=99.