From: "Ludovic Courtès" <ludo@gnu.org>
To: Nigko Yerden <nigko.yerden@gmail.com>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
Simon Tournier <zimon.toutoune@gmail.com>,
Mathieu Othacehe <othacehe@gnu.org>,
Tobias Geerinckx-Rice <me@tobias.gr>,
Christopher Baines <guix@cbaines.net>,
72867@debbugs.gnu.org
Subject: [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks.
Date: Thu, 29 Aug 2024 11:00:16 +0200 [thread overview]
Message-ID: <87frqnhffj.fsf@gnu.org> (raw)
In-Reply-To: <e2bf165fc2905bcc8d33d23293eb3d31f3fbe4b8.1724911574.git.nigko.yerden@gmail.com> (Nigko Yerden's message of "Thu, 29 Aug 2024 11:06:14 +0500")
Hi Nigko,
Nigko Yerden <nigko.yerden@gmail.com> skribis:
> Fixes <https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00047.html>
>
> While the issue can be easily fixed (a one line change in 'absolute-dirname')
> by changing 'current-source-directory' so that it always follows symlinks,
> such a change may break someone else's code. Instead, this patch keeps the
> original behavior of 'current-source-directory' macro and adds optional
> 'follow-symlinks?' argument to it.
>
> This patch is the result of collective work of
> Florian Pelz <pelzflorian@pelzflorian.de> and
> Nigko Yerden <nigko.yerden@gmail.com>
I haven’t read the thread above. Could you come up with a test case
that shows the problem being fixed? (That is, the test should fail when
run on current ‘master’.)
That will allow us to “formalize” the issue and to make sure it doesn’t
come back later.
Thanks for your work,
Ludo’.
next prev parent reply other threads:[~2024-08-29 9:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 6:06 [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks Nigko Yerden
2024-08-29 7:01 ` [bug#72867] when should local-file and current-source-directory not follow symlinks? Attila Lendvai
2024-08-29 9:00 ` Ludovic Courtès [this message]
2024-08-29 10:10 ` [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks pelzflorian (Florian Pelz)
2024-08-30 12:07 ` Nigko Yerden
2024-08-30 14:00 ` [bug#72867] when should local-file and current-source-directory not follow symlinks? Nigko Yerden
2024-08-31 17:10 ` pelzflorian (Florian Pelz)
2024-09-01 14:13 ` Tobias Geerinckx-Rice via Guix-patches via
2024-09-02 4:41 ` [bug#72867] [PATCH v2] gexp: Make 'local-file' follow symlinks Nigko Yerden
2024-09-02 7:53 ` [bug#72867] [PATCH v3] " Nigko Yerden
2024-09-03 15:05 ` pelzflorian (Florian Pelz)
2024-09-05 5:06 ` Nigko Yerden
2024-09-05 4:16 ` [bug#72867] [PATCH v4] " Nigko Yerden
2024-09-06 4:17 ` [bug#72867] [PATCH v5] " Nigko Yerden
2024-09-07 7:35 ` pelzflorian (Florian Pelz)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frqnhffj.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=72867@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=me@tobias.gr \
--cc=nigko.yerden@gmail.com \
--cc=othacehe@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.