all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#72181] [PATCH] gnu: services: power-profiles-daemon: Beautify service.
@ 2024-07-18 19:28 Dariqq
  2024-11-20 22:43 ` bug#72181: " Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Dariqq @ 2024-07-18 19:28 UTC (permalink / raw)
  To: 72181; +Cc: Dariqq

* gnu/services/pm.scm (power-profiles-daemon-shepherd-service): Change indentation.
[requirement]: Add user-processes.
[documentation]: Change name to Power Profiles Daemon.

(power-profiles-daemon-service-type)
[description]: Change name to Power Profiles Daemon.

Change-Id: Ibbd06cf1fbadd812ad3f0eac92b9772e3387f875
---

Addressing some of the feedpack I got after the original patch #70460 was already pushed: Changing power-profiles-daemon to Power Profiles Daemon in descriptons and make the service require user-processes. Also let the indentation of the shepherd service match other services.

 gnu/services/pm.scm | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm
index 47f0bf7812..5e8e7efda2 100644
--- a/gnu/services/pm.scm
+++ b/gnu/services/pm.scm
@@ -52,14 +52,15 @@ (define (power-profiles-daemon-shepherd-service config)
   (match-record
       config <power-profiles-daemon-configuration>
       (power-profiles-daemon)
-    (list (shepherd-service
-           (provision '(power-profiles-daemon))
-           (requirement '(dbus-system))
-           (documentation "Run the power-profiles-daemon.")
-           (start #~(make-forkexec-constructor
-                     (list #$(file-append power-profiles-daemon
-                                          "/libexec/power-profiles-daemon"))))
-           (stop #~(make-kill-destructor))))))
+    (list
+     (shepherd-service
+      (provision '(power-profiles-daemon))
+      (requirement '(user-processes dbus-system))
+      (documentation "Run the Power Profiles Daemon.")
+      (start #~(make-forkexec-constructor
+                (list #$(file-append power-profiles-daemon
+                                     "/libexec/power-profiles-daemon"))))
+      (stop #~(make-kill-destructor))))))
 
 (define %power-profiles-daemon-activation
   #~(begin
@@ -83,7 +84,7 @@ (define power-profiles-daemon-service-type
                   (service-extension activation-service-type
                                      (const %power-profiles-daemon-activation))))
      (default-value (power-profiles-daemon-configuration))
-     (description "Run the power-profiles-daemon"))))
+     (description "Run the Power Profiles Daemon"))))
 
 \f
 

base-commit: e3dfed59d39ac60dd2e2b9ef9f4ef63a2a081f41
-- 
2.45.2





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#72181: [PATCH] gnu: services: power-profiles-daemon: Beautify service.
  2024-07-18 19:28 [bug#72181] [PATCH] gnu: services: power-profiles-daemon: Beautify service Dariqq
@ 2024-11-20 22:43 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2024-11-20 22:43 UTC (permalink / raw)
  To: Dariqq; +Cc: 72181-done

Dariqq <dariqq@posteo.net> skribis:

> * gnu/services/pm.scm (power-profiles-daemon-shepherd-service): Change indentation.
> [requirement]: Add user-processes.
> [documentation]: Change name to Power Profiles Daemon.
>
> (power-profiles-daemon-service-type)
> [description]: Change name to Power Profiles Daemon.
>
> Change-Id: Ibbd06cf1fbadd812ad3f0eac92b9772e3387f875

Applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-20 22:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-18 19:28 [bug#72181] [PATCH] gnu: services: power-profiles-daemon: Beautify service Dariqq
2024-11-20 22:43 ` bug#72181: " Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.