From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id sEbZDDWQYWcqmwAA62LTzQ:P1 (envelope-from ) for ; Tue, 17 Dec 2024 14:52:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id sEbZDDWQYWcqmwAA62LTzQ (envelope-from ) for ; Tue, 17 Dec 2024 15:52:37 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Us9cMgs2; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Abqi5GTW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734447157; a=rsa-sha256; cv=none; b=k5J961IyHj39LvN4DjPubda9xtBUadM3vVa+Zwjpviq4Lmhrz8qDD+QH5CrRqcgdIhGfMm f0JepjI7yZM4pj4Qs2bFwBa+jLMJwznixzALOx7Atub3iDGmgj8Mb0Th5HVsktmBUM3cjS 7oKYx12QrPPCCCfYs98g3CEgHnblHy90BopT5c3mP2c8tNrHhY84prD+IdzHZGe2rPuuEO /qaQkqwcIWz6LwCxb9D//yNyJ/5sdk5kMGTB7VvxUNP0gyKkG19chGUCNh2q54kT9FPHMj eaK8K6hdF7p3n8xM7AaAuG5wVxisnCgaEz4xRGNZTHtXE+dTqYuVJxaK1VZv1w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Us9cMgs2; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Abqi5GTW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734447157; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=thliptRBZjZnRZa8B7gPwFYaEkpgB4ec6dsU4CugelM=; b=BWGAeKcQgtDkXZdYUD3jCgPvpNK2HkwJO6BYw8M4IshtlyPGtiMgxH0l+6ZRTyJ4jWxjCm Kr79BPx67AauMoyZWU362oi3oWn7W6lXXGzuPxILtSDM5GkzV9xQyw6iqljE69do+scZlK VcoCvmmHd9ldz5AECoSUqW3rafozKQa3F3sEhiUffuDj2W9ayZd6rGKdSVDX0E4q53trdi 7gd6J2tpIrVwFZdtxMr2Cft9uQ/lXGomzoijbSvTpPEWpdX+btuQqsZgvsM+fVgwnNQiDB lyXulD7I2ouJanDAsuENjLBK9O679ddBW3TPQ9EOo9HueqX9y9qsMwzZKmh0TQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 00E707AEB9 for ; Tue, 17 Dec 2024 15:52:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNYvy-0005PE-9C; Tue, 17 Dec 2024 09:52:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNYvb-0005Nt-QA for guix-patches@gnu.org; Tue, 17 Dec 2024 09:52:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNYvb-0008Fy-ID for guix-patches@gnu.org; Tue, 17 Dec 2024 09:52:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=thliptRBZjZnRZa8B7gPwFYaEkpgB4ec6dsU4CugelM=; b=Us9cMgs2SK0XNRwhteAAokBmGcMIkxtGYYbJiLFGUa0FYdgCbGYWKHnbY3KrbRotGKKeILR0AXSJDgDEawn1HW8OmtP9J/H6i/TZPbvXhq3b9H+7Xdi9YIcOVmaYiljpvjB7eH0JdQX32WiawCM/k7jox4+RHHdA98h0wio18ahPLL+GfPsg24v26zV+G6gDQ8+VwrMCW+Ma4Sb1fVPFJh6EIidyBOSK6mxWM8KejmMgniAtD4WLqxyM9NFfZiXztqerAA5e3BTMlLajXgLiPO+UsYP4PYlpAtrjtIta6nk9w5PoVAfd9kctF3l1ZXpGx+4GVmPahZlwYAMdCuXoeQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNYva-0003q9-G7 for guix-patches@gnu.org; Tue, 17 Dec 2024 09:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74394] [PATCH 0/2] Skip slow tests by default and run 'check' in Git pre-push hook. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Dec 2024 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74394 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 74394@debbugs.gnu.org Received: via spool by 74394-submit@debbugs.gnu.org id=B74394.173444710614729 (code B ref 74394); Tue, 17 Dec 2024 14:52:02 +0000 Received: (at 74394) by debbugs.gnu.org; 17 Dec 2024 14:51:46 +0000 Received: from localhost ([127.0.0.1]:58300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNYvJ-0003pT-RT for submit@debbugs.gnu.org; Tue, 17 Dec 2024 09:51:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:32812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNYvF-0003os-Px for 74394@debbugs.gnu.org; Tue, 17 Dec 2024 09:51:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNYvA-0008Bz-A5; Tue, 17 Dec 2024 09:51:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=thliptRBZjZnRZa8B7gPwFYaEkpgB4ec6dsU4CugelM=; b=Abqi5GTWHxrjfe3Va9tz tv1OVi9I3LTMj9f/6U4J/Ha9z1xVBfIK1bxo4NiBi2q7h4f+qt8k6LhPOhOAh6w8hy6TYAuQBFdVx FdK667rakqjQZPOW46umt70v6nyXASf255Tr5CDP4OSb1IHLZzsRqPbNbyQfTo8xcUQKISzAqpyuq efPHsnZp/ONXPf1G+35gVl3Wya4gYdrgUSBCYh5bq7YsS1vM3XVkhYuLVN0RTcQSFXCI/ODnc8T45 dqo+5FjHIS9kjvLnJ/+Rnur92q3HfN9n4L3p8OnhhgIYdq+be0s+7CTq/XsNEeZ6nT/pXhknFO70l rEGzxqZWAMQwfQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87zfkvrw38.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 17 Dec 2024 09:28:59 +0900") References: <87y1122w3k.fsf@gnu.org> <87zfkvrw38.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 27 Frimaire an 233 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du =?UTF-8?Q?Li=C3=A8ge?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Dec 2024 15:51:33 +0100 Message-ID: <87frmmnz0q.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.40 X-Migadu-Queue-Id: 00E707AEB9 X-Migadu-Spam-Score: -8.40 X-TUID: 7zgq6DNuaZoL Hi Maxim, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: [...] >> I agree with the goal, of course, but not with the method: even without >> expensive tests, =E2=80=9Cmake check=E2=80=9D is going to take maybe 5= =E2=80=9310 minutes, and >> having that happen when you run =E2=80=9Cgit push=E2=80=9D can be a terr= ible development >> experience (especially since the developer most likely either already >> ran the test suite or part of it right before, or pushes package changes >> that have infinitely small probability of breaking =E2=80=9Cmake check= =E2=80=9D). > > As I wrote, 'make check' with this change takes about 1 minute on my > machine; Right now, without your patch, we have: --8<---------------cut here---------------start------------->8--- $ wget -qO- $(guix build --log-file guix --no-grafts)|gunzip |grep "\`check= '" starting phase `check' phase `check' succeeded after 2049.2 seconds --8<---------------cut here---------------end--------------->8--- More than 30mn on the fast machines of the build farm, and with some of the expensive tests already skipped (those that require network access: time-machine, pack -RR, etc.). This patch is not dividing wall-clock time by 30, is it? >> This variable itself may still be useful though (I=E2=80=99d call it >> =E2=80=98RUN_EXPENSIVE_TESTS=E2=80=99 or something like that=E2=80=94tha= t=E2=80=99s the name used in >> Coreutils=E2=80=94, =E2=80=9Cexpensive=E2=80=9D being the key word). I = would also keep it on by >> default. > > One of the tests that was unbearably long when I measured was the > time-machine test. It took about 20 minutes to fetch the git repository > with guile-git and run the test (which does extra work compared to the > CLI like validating each object). I don't think we want this kind of > experience by default (because that'd probably convince people that > running the test suite often is not a reasonable thing to do). The > other tests were more reasonable, with the longer ones in the 2-3 > minutes range on my machine, IIRC. Perhaps we could have this 20 minute > outlier skipped by default, maybe with a RUN_PROHIBITIVE_TESTS flag that > would default to 0 (false). Yeah okay, maybe we should skip them by default, and maybe we can find a way to ensure developers do run them periodically. > A long time ago I had read a blog post that argued that unit tests > should be small and fast [0], I actually agree. :-) Thanks! Ludo=E2=80=99.