From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] utils: Add 'wrap-program'.
Date: Sun, 03 Mar 2013 22:29:39 +0100
Message-ID: <87ehfwyxx8.fsf@gnu.org>
References: <877gm7f01v.fsf@gnu.org> <87obfigz7g.fsf@karetnikov.org>
	<87y5el6hph.fsf@gnu.org> <87fw0rom1n.fsf@karetnikov.org>
	<87ehgbql5w.fsf@gnu.org> <87hal5ftyu.fsf@karetnikov.org>
	<874nh4ju7b.fsf@gnu.org> <87hakzwdzu.fsf@karetnikov.org>
	<87wqtu3n0z.fsf@gnu.org> <87ehg0rwfd.fsf@karetnikov.org>
	<87bob38ord.fsf@gnu.org> <87sj4f6u39.fsf@karetnikov.org>
	<87hakv6ndr.fsf@gnu.org> <87mwula74u.fsf@karetnikov.org>
	<87ehfx32wi.fsf@gnu.org> <87sj4ck5my.fsf_-_@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:43255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UCGTe-0001qo-1a
	for bug-guix@gnu.org; Sun, 03 Mar 2013 16:29:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UCGTc-00034N-Vt
	for bug-guix@gnu.org; Sun, 03 Mar 2013 16:29:49 -0500
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=53984
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UCGTc-00033F-Q7
	for bug-guix@gnu.org; Sun, 03 Mar 2013 16:29:48 -0500
In-Reply-To: <87sj4ck5my.fsf_-_@karetnikov.org> (Nikita Karetnikov's message
	of "Sun, 03 Mar 2013 16:52:05 +0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org

Nikita Karetnikov <nikita@karetnikov.org> skribis:

>> I wouldn=E2=80=99t bother, though, because it will be used in contexts w=
here
>> there=E2=80=99s no risk of =E2=80=98prog=E2=80=99 being used while we=E2=
=80=99re fiddling with it
>> (single-threaded, after =E2=80=98make install=E2=80=99).
>
> Better safe than sorry.  So I added '.PROG-tmp'.

Good.  :-)

> +    (copy-file prog prog-real)

You lack a (chmod prog-real #o755), I think.

> +    (with-output-to-file prog-tmp
> +                         (lambda ()

Opening bracket aligned with the =E2=80=98i=E2=80=99, please.  :-)

Other than that it looks perfect, and ready to be pushed.

Thanks!

Ludo=E2=80=99.