From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add goffice and gnumeric
Date: Sun, 29 Jun 2014 22:30:13 +0200
Message-ID: <87egy7foh6.fsf@gnu.org>
References: <1403964151-4537-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X1Ljw-0004tW-Iz
	for guix-devel@gnu.org; Sun, 29 Jun 2014 16:30:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X1Ljr-000333-T5
	for guix-devel@gnu.org; Sun, 29 Jun 2014 16:30:20 -0400
In-Reply-To: <1403964151-4537-1-git-send-email-jmd@gnu.org> (John Darrington's
	message of "Sat, 28 Jun 2014 16:02:31 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> gnu/packages/gnome.scm (goffice, gnumeric): New variables.

Nice!  Comments below:

> +    (license=20
> +     `(license:gpl2
> +       license:gpl3))))

Remember this field must be either a <license> object or a list thereof
(the one above is a list of symbols.)  So change it to:

  (license (list license:gpl2 license:gpl3))

Also, please add a comment stating what this means exactly: is it
dual-licensed?  Does it mean that some files are GPLv2-only and others
are GPLv3-only (which would be a problem)?

Does it mean some files are GPLv2-or-later and others are
GPLv3-or-later?  In that case, the value should be =E2=80=98license:gpl3+=
=E2=80=99.

> +    (arguments
> +     `(;; The gnumeric developers don't worry much about failing tests.
> +       ;; See https://bugzilla.gnome.org/show_bug.cgi?id=3D732387
> +       #:tests? #f=20
> +       :phases

Should be #:phases.

> +       alist-cons-before

Missing opening parenthesis.

> +       'configure 'pre-conf
> +       (lambda* (#:key outputs #:allow-other-keys)
> +         ;; Make install tries to write into the directory of goffice
> +         ;; I am informed that this only affects the possibility to embe=
d a
> +         ;; spreadsheet inside an abiword document.   So presumably when=
 we
> +         ;; package abiword we'll have to refer it to this directory.

=E2=80=9CAbiword=E2=80=9D.

> +    (description  "Gnumeric is a spreadsheet program for GNOME.")

A bit terse.  ;-)  Maybe there=E2=80=99s a paragraph from README or so that
could be used?

> +    (license=20
> +     `(license:gpl3
> +       license:gpl2))))

Same as above.

Thanks,
Ludo=E2=80=99.