Re: [PATCH] gnu: Add goffice and gnumeric

[ludo@gnu.org (Ludovic Courtès)]

John Darrington <jmd@gnu.org> skribis:

> gnu/packages/gnome.scm (goffice, gnumeric): New variables.

Nice!  Comments below:

> +    (license 
> +     `(license:gpl2
> +       license:gpl3))))

Remember this field must be either a <license> object or a list thereof
(the one above is a list of symbols.)  So change it to:

  (license (list license:gpl2 license:gpl3))

Also, please add a comment stating what this means exactly: is it
dual-licensed?  Does it mean that some files are GPLv2-only and others
are GPLv3-only (which would be a problem)?

Does it mean some files are GPLv2-or-later and others are
GPLv3-or-later?  In that case, the value should be ‘license:gpl3+’.

> +    (arguments
> +     `(;; The gnumeric developers don't worry much about failing tests.
> +       ;; See https://bugzilla.gnome.org/show_bug.cgi?id=732387
> +       #:tests? #f 
> +       :phases

Should be #:phases.

> +       alist-cons-before

Missing opening parenthesis.

> +       'configure 'pre-conf
> +       (lambda* (#:key outputs #:allow-other-keys)
> +         ;; Make install tries to write into the directory of goffice
> +         ;; I am informed that this only affects the possibility to embed a
> +         ;; spreadsheet inside an abiword document.   So presumably when we
> +         ;; package abiword we'll have to refer it to this directory.

“Abiword”.

> +    (description  "Gnumeric is a spreadsheet program for GNOME.")

A bit terse.  ;-)  Maybe there’s a paragraph from README or so that
could be used?

> +    (license 
> +     `(license:gpl3
> +       license:gpl2))))

Same as above.

Thanks,
Ludo’.