From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add cmatrix.
Date: Tue, 01 Jul 2014 12:28:08 +0200
Message-ID: <87egy5z83r.fsf@gnu.org>
References: <87k37xqtr3.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X1vIP-000768-7Y
	for guix-devel@gnu.org; Tue, 01 Jul 2014 06:28:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X1vII-0007N3-DG
	for guix-devel@gnu.org; Tue, 01 Jul 2014 06:28:17 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:55430)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1X1vII-0007Mv-4j
	for guix-devel@gnu.org; Tue, 01 Jul 2014 06:28:10 -0400
In-Reply-To: <87k37xqtr3.fsf@gmail.com> (Cyrill Schenkel's message of "Tue, 01
	Jul 2014 12:05:20 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

Cyrill Schenkel <cyrill.schenkel@gmail.com> skribis:

> From b2f37807cbf4fa150272c5ff77eba7a8aeecfcef Mon Sep 17 00:00:00 2001
> From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
> Date: Tue, 1 Jul 2014 12:02:26 +0200
> Subject: [PATCH] gnu: Add cmatrix.
>
> * gnu-system.am (GNU_SYSTEM_MODULES): Add new package.
> * gnu/packages/cmatrix.scm: New file.


[...]

> +(define-module (gnu packages acl)

Copy/paste error here.

Also, what about putting it in games.scm instead?

> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:phases
> +       (alist-cons-before
> +        'patch-source-shebangs 'autoreconf
> +        (lambda args
> +          (system* "autoreconf" "-fi"))
> +        %standard-phases)))

This shouldn=E2=80=99t be needed because the tarballs includes ./configure,
Makefile.in, etc.

> +    (inputs `(("ncurses" ,ncurses)
> +              ("autoconf" ,autoconf)
> +              ("automake" ,automake)))

Likewise: no need to depend on Autoconf and Automake.

> +    (synopsis "CMatrix simulates the display from \"The Matrix\"")

In general the synopsis shouldn=E2=80=99t repeat the package name, so:

  Simulate the display from \"The Matrix\"

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.