From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/4] gnu: Add potrace.
Date: Tue, 07 Oct 2014 23:26:59 +0200 [thread overview]
Message-ID: <87egujvae4.fsf@gnu.org> (raw)
In-Reply-To: <87a957wzz7.fsf@gmail.com> (Eric Bavier's message of "Tue, 07 Oct 2014 12:29:00 -0500")
Eric Bavier <ericbavier@gmail.com> skribis:
> Ludovic Courtès writes:
>
>> Eric Bavier <ericbavier@gmail.com> skribis:
>>
>>> From f178a122f3805cbc23119b20c2144cf2a59bed3f Mon Sep 17 00:00:00 2001
>>> From: Eric Bavier <bavier@member.fsf.org>
>>> Date: Tue, 7 Oct 2014 11:13:35 -0500
>>> Subject: [PATCH 1/4] gnu: Add potrace.
>>>
>>> * gnu/packages/fontutils.scm (potrace): New variable.
>>
>> This part looks good to me, but...
>
> Ok.
>
>>
>>> gnu/packages/fontutils.scm | 28 ++++++++++++++
>>> gnu/packages/giflib.scm | 90 ++++++++++++++++++++++++++++++++++++++++++++
>>
>> What about the giflib.scm changes? Were they intended?
>
> No, those changes were not intended.
OK.
>> Perhaps giflib 5.x can be added in image.scm?
>
> I was experimenting with the latest version of fontforge, which can use
> giflib 5.x. For the time being it can be left out.
>
> An updated patch is attached.
>
>
> From 6721d6e9e31af8aff5e781d813e55347dea378c9 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Tue, 7 Oct 2014 12:27:37 -0500
> Subject: [PATCH] gnu: Add potrace.
>
> * gnu/packages/fontutils.scm (potrace): New variable.
LGTM!
Ludo'.
next prev parent reply other threads:[~2014-10-07 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 16:37 [PATCH 1/4] gnu: Add potrace Eric Bavier
2014-10-07 16:59 ` Ludovic Courtès
2014-10-07 17:29 ` Eric Bavier
2014-10-07 21:26 ` Ludovic Courtès [this message]
2014-10-07 17:39 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egujvae4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.