From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: Add ntp
Date: Sat, 18 Oct 2014 12:24:56 -0400
Message-ID: <87egu5qraf.fsf@yeeloong.lan>
References: <1413645106-14116-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XfWp9-000828-JJ
	for guix-devel@gnu.org; Sat, 18 Oct 2014 12:25:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XfWp4-0004T0-TJ
	for guix-devel@gnu.org; Sat, 18 Oct 2014 12:25:47 -0400
In-Reply-To: <1413645106-14116-1-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Sat, 18 Oct 2014 17:11:46 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> writes:

> +(define-public ntp
> +  (package
> +   (name "ntp")
> +   (version "4.2.6p5")
> +   (source (origin
> +	    (method url-fetch)
> +	    (uri (string-append "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-"
> +                                (string-take version 3) "/ntp-" 

Instead of 'string-take', please import (srfi srfi-1) and then do this:

  (string-join (take (string-split version #\.) 2)
               ".")

We use this pattern in a number of other places -- search for
"string-join" in gnu/packages/*.scm to find them.  I suppose we should
add a procedure specifically for this, but it can wait, and it should be
in a separate commit anyway.

> +                                version ".tar.gz"))
> +	    (sha256
> +	     (base32
> +	      "077r69a41hasl8zf5c44km7cqgfhrkaj6a4jnr75j7nkz5qq7ayn"))))
> +   (native-inputs `(("which" ,which)))
> +   (build-system gnu-build-system)
> +   (synopsis "Real time clock synchonization system")
> +   (description "NTP is a system designed to synchronize the clocks of
> +computers over a network.")
> +   (license (x11-style 
> +             "http://www.eecis.udel.edu/~mills/ntp/html/copyright.html"
> +             "A non-copyleft free licence from the University of Delaware"))
> +   (home-page "http://www.ntp.org")))

Okay to commit with the change above.

    Thanks!
      Mark