From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH]: add freepats and timidity Date: Thu, 19 Feb 2015 21:10:10 +0100 Message-ID: <87egplll25.fsf@mango.localdomain> References: <87h9uhlpig.fsf@mango.localdomain> <20150219200320.GA7712@debian> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOXQW-0001ee-6W for guix-devel@gnu.org; Thu, 19 Feb 2015 15:10:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOXQS-0002Jr-Qc for guix-devel@gnu.org; Thu, 19 Feb 2015 15:10:24 -0500 Received: from sender1.zohomail.com ([74.201.84.155]:30277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOXQS-0002JV-Ia for guix-devel@gnu.org; Thu, 19 Feb 2015 15:10:20 -0500 In-reply-to: <20150219200320.GA7712@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: Guix-devel Andreas Enge writes: > On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote: >> +(define-public timidity++ >> + (package >> + (name "timidity++") > > Back to names... I would call this "timidity". The package guidelines only > state that underscores are replaced by "-", but the general idea would be > to replace special characters with dashes, and to rather drop them at the end > (or beginning) of a package name. The homepage of TiMidity++ says TiMidity++ is based on TiMidity 0.2i, written by Tuukka Toivonen *1, released on 1995. No new version of this original project is developed since then. Development has been continued by Masanao Izumo et al. in the new project named TiMidity++. ++ is to show the difference from original project. I'd rather not change the name. For reference, Fedora calls the package "timidity++" as well. >> + (let ((out (string-append (assoc-ref %outputs "out") >> + "/share/timidity"))) >> + (mkdir-p out) >> + (call-with-output-file >> + (string-append out "/timidity.cfg") > > It is a bit strange to have config files in /share and not in /etc, but that > is indeed where by default timidity looks for its config file. Nevertheless, > I would use > (string-append (assoc-ref %outputs "out") "/etc/timidity") > and then add the configure flag > (string-append "--with-default-path=" (assoc-ref %outputs "out") "/etc/timidity") I don't mind either way, but I do agree that coercing TiMidity++ to look in a more traditional location for the configuration file sounds like a good idea. ~~ Ricardo