all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: taylanbayirli@gmail.com (Taylan Ulrich Bayırlı/Kammer)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: .dir-locals.el vs. guix-devel-mode
Date: Mon, 28 Sep 2015 22:05:19 +0200	[thread overview]
Message-ID: <87eghi1f9c.fsf@T420.taylan> (raw)
In-Reply-To: <878u7qybjn.fsf_-_@gmail.com> (Alex Kost's message of "Mon, 28 Sep 2015 15:26:52 +0300")

Alex Kost <alezost@gmail.com> writes:

> [...]
>
> More generally, I'm strongly against using "eval" in .dir-locals.  IMO
> this file should be used only to set local variables, and ideally it
> shouldn't evaluate an arbitrary code.

Just to clarify: I suppose you mean using eval for things other than
which Emacs can automatically determine to be safe.  E.g.

    (eval . (put 'foo 'scheme-indent-function <n>))

for integer <n> is safe; Emacs will eval that silently if I'm not
mistaken.

But for things where Emacs pesters the user because it finds it
"unsafe," I find that very annoying.

> So I think .dir-locals.el is not the proper place for indentation rules.
> IMHO they should be moved to "guix-devel.el" and the manual should
> recommend using 'guix-devel-mode' for editing guix package files as it
> provides the proper indenting, highlighting and some useful key
> bindings.

IMO anything that can be put into .dir-locals.el without making Emacs
pester the user should be put there.  It's a delight for a Guix newb to
get such settings automatically, because otherwise M-q and TAB will
break existing correct indentation in edited source files, which is very
annoying, and also it might lead to extra patch review round-trips when
the user creates a patch with wrong indentation without noticing.

Just my two cents as a passerby in this thread...

Taylan

  reply	other threads:[~2015-09-28 20:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25  8:05 [PATCH] emacs: devel: Highlight 'modify-phases' keywords Alex Kost
2015-09-25 19:22 ` Ludovic Courtès
2015-09-26 19:48   ` Alex Kost
2015-09-27 20:29     ` Ludovic Courtès
2015-09-28 12:26       ` .dir-locals.el vs. guix-devel-mode Alex Kost
2015-09-28 20:05         ` Taylan Ulrich Bayırlı/Kammer [this message]
2015-09-29 11:06           ` Alex Kost
2015-09-29 11:22             ` Taylan Ulrich Bayırlı/Kammer
2015-09-29 19:16         ` Ludovic Courtès
2015-10-01 21:10           ` Alex Kost
2015-10-01 21:34             ` Ludovic Courtès
2015-10-02 12:46               ` Alex Kost
2015-10-02 12:51                 ` Ludovic Courtès
2015-10-02 17:25                   ` Alex Kost
2015-10-12  9:33                   ` [PATCH] emacs: devel: Add indentation rules Alex Kost
2015-10-13  9:45                     ` Ludovic Courtès
2015-10-13 17:50                       ` Alex Kost
2015-10-14 20:00                         ` Ludovic Courtès
2015-10-15 17:42                           ` Alex Kost
2015-10-01 21:39             ` .dir-locals.el vs. guix-devel-mode Mathieu Lirzin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eghi1f9c.fsf@T420.taylan \
    --to=taylanbayirli@gmail.com \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.